From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.124] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NjnMn-0000B7-Sv for ltp-list@lists.sourceforge.net; Tue, 23 Feb 2010 05:31:29 +0000 Received: from e4.ny.us.ibm.com ([32.97.182.144]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1NjnMl-0006il-Ml for ltp-list@lists.sourceforge.net; Tue, 23 Feb 2010 05:31:29 +0000 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e4.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o1N5KYrk011896 for ; Tue, 23 Feb 2010 00:20:34 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o1N5VBht132380 for ; Tue, 23 Feb 2010 00:31:11 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o1N5VBOO032685 for ; Tue, 23 Feb 2010 02:31:11 -0300 Message-ID: <4B836817.6030103@linux.vnet.ibm.com> Date: Tue, 23 Feb 2010 11:01:03 +0530 From: Subrata Modak MIME-Version: 1.0 References: <4B823681.7010300@linux.vnet.ibm.com> <20100222164921.GC2992@linux.vnet.ibm.com> <364299f41002221017y4b49a212qd81ebc248d4b89d2@mail.gmail.com> In-Reply-To: <364299f41002221017y4b49a212qd81ebc248d4b89d2@mail.gmail.com> Subject: Re: [LTP] [ANNOUNCEMENT]: Intermediate release for FEB'10 List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7263549873488897432==" Errors-To: ltp-list-bounces@lists.sourceforge.net To: Iranna D Ankad , Rishikesh K Rajak Cc: LTP , Vishukumar S Shetty This is a multi-part message in MIME format. --===============7263549873488897432== Content-Type: multipart/alternative; boundary="------------020701090908060903030301" This is a multi-part message in MIME format. --------------020701090908060903030301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Garrett Cooper wrote: > On Mon, Feb 22, 2010 at 8:49 AM, Rishikesh K Rajak > wrote: > >> Hi Iranna, >> >> >> Thanks for reporting this build failure and helping, as it will >> really help to make ltp more stable. >> >> Here is the quick patch i am attaching which solves the problem. >> >> Signed-off By: Rishikesh K Rajak >> Tested By: Rishikesh K Rajak >> --- >> diff --git a/testcases/kernel/syscalls/mbind/mbind01.c >> b/testcases/kernel/syscalls/mbind/mbind01.c >> index 5d7eb69..847186a 100644 >> --- a/testcases/kernel/syscalls/mbind/mbind01.c >> +++ b/testcases/kernel/syscalls/mbind/mbind01.c >> @@ -74,6 +74,7 @@ int TST_TOTAL = 2; /* total number of tests >> in this file. */ >> #include >> #include "include_j_h.h" >> #include "numa_helpers.h" >> +#include >> And also, including in any application(s) other than the kernel itself is better avoided. Regards-- Subrata >> #if ! defined(LIBNUMA_API_VERSION) || LIBNUMA_API_VERSION < 2 >> > > No. This patch shouldn't be committed because of namespace collisions > between numa and mempolicy (thank the developers for just copy-pasting > constants, macros, etc instead of properly requiring numa on the > target system in order for mempolicy to work...). > > Thanks, > -Garrett > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > --------------020701090908060903030301 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Garrett Cooper wrote: 
On Mon, Feb 22, 2010 at 8:49 AM, Rishikesh K Rajak
<risrajak@linux.vnet.ibm.com> wrote:
  
Hi Iranna,


Thanks for reporting this build failure and helping, as it will
really help to make ltp more stable.

Here is the quick patch i am attaching which solves the problem.

Signed-off By: Rishikesh K Rajak<risrajak@linux.vnet.ibm.com>
Tested By: Rishikesh K Rajak<risrajak@linux.vnet.ibm.com>
---
diff --git a/testcases/kernel/syscalls/mbind/mbind01.c
b/testcases/kernel/syscalls/mbind/mbind01.c
index 5d7eb69..847186a 100644
--- a/testcases/kernel/syscalls/mbind/mbind01.c
+++ b/testcases/kernel/syscalls/mbind/mbind01.c
@@ -74,6 +74,7 @@ int  TST_TOTAL = 2;           /* total number of tests
in this file.   */
 #include <unistd.h>
 #include "include_j_h.h"
 #include "numa_helpers.h"
+#include <linux/mempolicy.h>
And also, including <linux/*.h> in any application(s) other than the kernel itself is better avoided.

Regards--
Subrata
 #if ! defined(LIBNUMA_API_VERSION) || LIBNUMA_API_VERSION < 2
    

No. This patch shouldn't be committed because of namespace collisions
between numa and mempolicy (thank the developers for just copy-pasting
constants, macros, etc instead of properly requiring numa on the
target system in order for mempolicy to work...).

Thanks,
-Garrett

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

--------------020701090908060903030301-- --===============7263549873488897432== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --===============7263549873488897432== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list --===============7263549873488897432==--