From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.124] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1Ntwa2-0002rZ-76 for ltp-list@lists.sourceforge.net; Tue, 23 Mar 2010 05:23:06 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sfi-mx-4.v28.ch3.sourceforge.com with esmtp (Exim 4.69) id 1NtwZz-0004tx-Qy for ltp-list@lists.sourceforge.net; Tue, 23 Mar 2010 05:23:06 +0000 Message-ID: <4BA85020.9040202@cn.fujitsu.com> Date: Tue, 23 Mar 2010 13:22:40 +0800 From: Shi Weihua MIME-Version: 1.0 References: <4B9B0B3A.3080008@cn.fujitsu.com> <364299f41003122227w6859d6f3i829466a6fc5099f2@mail.gmail.com> <364299f41003122313i47334168u25a6b12c6c64a7d9@mail.gmail.com> <4BA74116.9020009@cn.fujitsu.com> <364299f41003222057i6caa2cc8g6b1786f3cee86a74@mail.gmail.com> In-Reply-To: <364299f41003222057i6caa2cc8g6b1786f3cee86a74@mail.gmail.com> Subject: Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: ltp-list at 2010-3-23 11:57, Garrett Cooper wrote: > On Mon, Mar 22, 2010 at 3:06 AM, Shi Weihua wrote: >> Hi Garrett >> >> at 2010-3-13 15:13, Garrett Cooper wrote: >>> On Fri, Mar 12, 2010 at 10:27 PM, Garrett Cooper wrote: >>>> On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua wrote: >>>>> An error message occured when i tested proc01. >>>>> --------- >>>>> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable >>>>> --------- >>>>> >>>>> If "service acpid start", this message will be turned to: >>>>> --------- >>>>> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy >>>>> --------- >>>>> >>>>> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c. >>>> >>>> No, that's making things too complicated and won't scale as every >>>> distro has developed a different means for specifying the status for a >>>> service. Why not just add EAGAIN for that /proc node? >>> >>> And FWIW the error condition is correct in my opinion if kernel >>> acpi hasn't been enabled, which was the case here. >> >> I think we should to give a warning message to LTP users. >> How do you think the following patch? >> >> diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c >> index 2d4a5fd..62d44b1 100644 >> --- a/testcases/kernel/fs/proc/proc01.c >> +++ b/testcases/kernel/fs/proc/proc01.c >> @@ -101,6 +101,7 @@ const Mapping known_issues[] = { >> {"read", "/proc/fs/nfsd/filehandle", EINVAL}, >> {"read", "/proc/fs/nfsd/.getfs", EINVAL}, >> {"read", "/proc/fs/nfsd/.getfd", EINVAL}, >> + {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled >> {"", "", 0} >> }; > > Looks good minus the C++ style comment ;). ok, let's use C style comment. diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c index 2d4a5fd..355b7dd 100644 --- a/testcases/kernel/fs/proc/proc01.c +++ b/testcases/kernel/fs/proc/proc01.c @@ -101,6 +101,7 @@ const Mapping known_issues[] = { {"read", "/proc/fs/nfsd/filehandle", EINVAL}, {"read", "/proc/fs/nfsd/.getfs", EINVAL}, {"read", "/proc/fs/nfsd/.getfd", EINVAL}, + {"read", "/proc/acpi/event", EAGAIN}, /* EAGAIN will be returned if acpi daemon disabled */ {"", "", 0} }; > Thanks again! > -Garrett > > -- Shi Weihua ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list