* [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test()
@ 2010-05-06 9:25 Shi Weihua
2010-05-06 18:01 ` Garrett Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Shi Weihua @ 2010-05-06 9:25 UTC (permalink / raw)
To: subrata; +Cc: ltp-list
We should to check the return value of trigger_eventfd_overflow()
in overflow_poll_test().
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
diff --git a/testcases/kernel/syscalls/eventfd/eventfd01.c b/testcases/kernel/syscalls/eventfd/eventfd01.c
index 83eb86e..ce55746 100644
--- a/testcases/kernel/syscalls/eventfd/eventfd01.c
+++ b/testcases/kernel/syscalls/eventfd/eventfd01.c
@@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
int ret;
ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
- if (fd == -1) {
+ if (ret == -1) {
tst_resm(TBROK, "error triggering eventfd overflow");
return;
}
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test()
2010-05-06 9:25 [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test() Shi Weihua
@ 2010-05-06 18:01 ` Garrett Cooper
2010-05-07 5:46 ` Subrata Modak
0 siblings, 1 reply; 3+ messages in thread
From: Garrett Cooper @ 2010-05-06 18:01 UTC (permalink / raw)
To: Shi Weihua; +Cc: ltp-list
On Thu, May 6, 2010 at 2:25 AM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> We should to check the return value of trigger_eventfd_overflow()
> in overflow_poll_test().
>
> Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
> ---
> diff --git a/testcases/kernel/syscalls/eventfd/eventfd01.c b/testcases/kernel/syscalls/eventfd/eventfd01.c
> index 83eb86e..ce55746 100644
> --- a/testcases/kernel/syscalls/eventfd/eventfd01.c
> +++ b/testcases/kernel/syscalls/eventfd/eventfd01.c
> @@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
> int ret;
>
> ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
> - if (fd == -1) {
> + if (ret == -1) {
> tst_resm(TBROK, "error triggering eventfd overflow");
> return;
> }
Acked-by: Garrett Cooper <yanegomi@gmail.com>
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test()
2010-05-06 18:01 ` Garrett Cooper
@ 2010-05-07 5:46 ` Subrata Modak
0 siblings, 0 replies; 3+ messages in thread
From: Subrata Modak @ 2010-05-07 5:46 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
On Thu, 2010-05-06 at 11:01 -0700, Garrett Cooper wrote:
> On Thu, May 6, 2010 at 2:25 AM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> > We should to check the return value of trigger_eventfd_overflow()
> > in overflow_poll_test().
> >
> > Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
> > ---
> > diff --git a/testcases/kernel/syscalls/eventfd/eventfd01.c b/testcases/kernel/syscalls/eventfd/eventfd01.c
> > index 83eb86e..ce55746 100644
> > --- a/testcases/kernel/syscalls/eventfd/eventfd01.c
> > +++ b/testcases/kernel/syscalls/eventfd/eventfd01.c
> > @@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
> > int ret;
> >
> > ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
> > - if (fd == -1) {
> > + if (ret == -1) {
> > tst_resm(TBROK, "error triggering eventfd overflow");
> > return;
> > }
>
> Acked-by: Garrett Cooper <yanegomi@gmail.com>
Thanks. Just checked in.
Regards--
Subrata
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-07 5:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 9:25 [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test() Shi Weihua
2010-05-06 18:01 ` Garrett Cooper
2010-05-07 5:46 ` Subrata Modak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox