[LTP] problems building mallopt01.c for uClinux

[LTP] problems building mallopt01.c for uClinux

[David Marlin]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]


The testcase mallopt01 skips performing the test when UCLINUX=1, but the
mallinfo structure is defined outside the #if !defined(UCLINUX) block.

Attached is a patch to move the mallinfo structure definition inside the
#if !defined(UCLINUX) block.


Signed-off-by: d.marlin <dmarlin@redhat.com>




[-- Attachment #2: mallopt01.c.patch --]
[-- Type: text/x-patch, Size: 497 bytes --]

--- testcases/kernel/syscalls/mallopt/mallopt01.c.orig2	2010-08-13 10:28:12.318231000 -0500
+++ testcases/kernel/syscalls/mallopt/mallopt01.c	2010-08-13 10:44:06.279068760 -0500
@@ -56,10 +56,10 @@
 extern int Tst_COUNT;		/* Test Case counter for tst_routines */
 
 void printinfo();
-/*****	*	*	*****/
-struct mallinfo info;
 
 #if !defined(UCLINUX)
+/*****	*	*	*****/
+struct mallinfo info;
 
 /*--------------------------------------------------------------*/
 int main(int argc, char *argv[])

[-- Attachment #3: Type: text/plain, Size: 224 bytes --]

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] problems building mallopt01.c for uClinux

[Garrett Cooper]

On Tue, Aug 17, 2010 at 11:30 AM, David Marlin <dmarlin@redhat.com> wrote:
>
> The testcase mallopt01 skips performing the test when UCLINUX=1, but the
> mallinfo structure is defined outside the #if !defined(UCLINUX) block.
>
> Attached is a patch to move the mallinfo structure definition inside the
> #if !defined(UCLINUX) block.

ACK.

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] problems building mallopt01.c for uClinux

[Mike Frysinger]

On Tue, Aug 17, 2010 at 3:47 PM, Garrett Cooper wrote:
> On Tue, Aug 17, 2010 at 11:30 AM, David Marlin wrote:
>> The testcase mallopt01 skips performing the test when UCLINUX=1, but the
>> mallinfo structure is defined outside the #if !defined(UCLINUX) block.
>>
>> Attached is a patch to move the mallinfo structure definition inside the
>> #if !defined(UCLINUX) block.
>
> ACK.

meaning you're going to merge it ? ;)  this change looks fine of course.
-mike

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] problems building mallopt01.c for uClinux

[Garrett Cooper]

On Tue, Aug 17, 2010 at 1:00 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tue, Aug 17, 2010 at 3:47 PM, Garrett Cooper wrote:
>> On Tue, Aug 17, 2010 at 11:30 AM, David Marlin wrote:
>>> The testcase mallopt01 skips performing the test when UCLINUX=1, but the
>>> mallinfo structure is defined outside the #if !defined(UCLINUX) block.
>>>
>>> Attached is a patch to move the mallinfo structure definition inside the
>>> #if !defined(UCLINUX) block.
>>
>> ACK.
>
> meaning you're going to merge it ? ;)  this change looks fine of course.

Yeah. ACK -> all's good, I'm going to commit later. I kind of adopted
it after looking at the yum list, because it's a lot quicker to say
and less redundant than:

Acked-by: Garrett Cooper <yanegomi@gmail.com>

;)...

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] problems building mallopt01.c for uClinux

[Mike Frysinger]

On Tue, Aug 17, 2010 at 4:05 PM, Garrett Cooper wrote:
> On Tue, Aug 17, 2010 at 1:00 PM, Mike Frysinger wrote:
>> On Tue, Aug 17, 2010 at 3:47 PM, Garrett Cooper wrote:
>>> On Tue, Aug 17, 2010 at 11:30 AM, David Marlin wrote:
>>>> The testcase mallopt01 skips performing the test when UCLINUX=1, but the
>>>> mallinfo structure is defined outside the #if !defined(UCLINUX) block.
>>>>
>>>> Attached is a patch to move the mallinfo structure definition inside the
>>>> #if !defined(UCLINUX) block.
>>>
>>> ACK.
>>
>> meaning you're going to merge it ? ;)  this change looks fine of course.
>
> Yeah. ACK -> all's good, I'm going to commit later. I kind of adopted
> it after looking at the yum list, because it's a lot quicker to say
> and less redundant than:
>
> Acked-by: Garrett Cooper <yanegomi@gmail.com>

ok, but following the original LKML style, people who ACK usually
arent the ones who actually pick up & merge
-mike

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list