From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] open_posix_testsuite: Fix variable type error
Date: Mon, 18 Oct 2010 18:24:04 +0800 [thread overview]
Message-ID: <4CBC2044.3040202@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTinQjHvu=F1rnB19Bzv4g27anHt4QM9JJJAh_bBA@mail.gmail.com>
Garrett Cooper wrote:
> On Mon, Oct 18, 2010 at 2:32 AM, Gui Jianfeng
> <guijianfeng@cn.fujitsu.com> wrote:
>> Hi
>>
>> Currently, the variable "timeout" type is int, We should make it to be "unsigned long".
>> Otherwise, we'll get an unexpected value in thread function, consequently, test fails.
>>
>> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
>> ---
>> .../functional/threads/pi_test/pitest-1.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/testcases/ /functional/threads/pi_test/pitest-1.c b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-1.c
>> index b8969a8..9fac992 100644
>> --- a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-1.c
>> +++ b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-1.c
>> @@ -296,7 +296,7 @@ int main(int argc, char **argv)
>>
>> /* Start TB thread (boosting thread) */
>> DPRINTF(stderr,"Main Thread: start TB thread\n");
>> - int timeout = multiplier * 20;
>> + unsigned long timeout = multiplier * 20;
>> rc = pthread_create(&threadtb, &threadattr, thread_tb,
>> &timeout);
>> if (rc != 0) {
>
> Please try this patch out instead and let me know how it goes.
Works good for me.
Gui
> Thanks,
> -Garrett
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2010-10-18 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 9:32 [LTP] [PATCH] open_posix_testsuite: Fix variable type error Gui Jianfeng
2010-10-18 9:56 ` Garrett Cooper
2010-10-18 10:24 ` Gui Jianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBC2044.3040202@cn.fujitsu.com \
--to=guijianfeng@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox