* [LTP] [PATCH] Fix all tests pass error
@ 2010-10-28 1:54 Gui Jianfeng
2010-10-28 2:40 ` Mitani
0 siblings, 1 reply; 3+ messages in thread
From: Gui Jianfeng @ 2010-10-28 1:54 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list, mitani
ret_code comes from "set +x" which always return 0, this makes all tests PASS.
Actually, "set +x" isn't needed here, just get rid of it.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
testcases/open_posix_testsuite/bin/run-tests.sh | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/testcases/open_posix_testsuite/bin/run-tests.sh b/testcases/open_posix_testsuite/bin/run-tests.sh
index 6a03856..04a39dd 100755
--- a/testcases/open_posix_testsuite/bin/run-tests.sh
+++ b/testcases/open_posix_testsuite/bin/run-tests.sh
@@ -48,8 +48,6 @@ run_test() {
sh -c "$SCRIPT_DIR/t0 $TIMEOUT_VAL ./$1 $(cat ./$(echo "$1" | sed 's,\.[^\.]*,,').args 2>/dev/null)" > $complog 2>&1
- set +x
-
ret_code=$?
if [ "$ret_code" = "0" ]; then
--
1.7.0.4
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [LTP] [PATCH] Fix all tests pass error
2010-10-28 1:54 [LTP] [PATCH] Fix all tests pass error Gui Jianfeng
@ 2010-10-28 2:40 ` Mitani
2010-10-28 16:55 ` Garrett Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Mitani @ 2010-10-28 2:40 UTC (permalink / raw)
To: 'Gui Jianfeng'; +Cc: ltp-list
> -----Original Message-----
> From: Gui Jianfeng [mailto:guijianfeng@cn.fujitsu.com]
> Sent: Thursday, October 28, 2010 10:55 AM
> To: Garrett Cooper
> Cc: mitani@ryobi.co.jp; ltp-list@lists.sourceforge.net
> Subject: [PATCH] Fix all tests pass error
>
> ret_code comes from "set +x" which always return 0, this makes all tests
> PASS.
> Actually, "set +x" isn't needed here, just get rid of it.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
> testcases/open_posix_testsuite/bin/run-tests.sh | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/bin/run-tests.sh
> b/testcases/open_posix_testsuite/bin/run-tests.sh
> index 6a03856..04a39dd 100755
> --- a/testcases/open_posix_testsuite/bin/run-tests.sh
> +++ b/testcases/open_posix_testsuite/bin/run-tests.sh
> @@ -48,8 +48,6 @@ run_test() {
>
> sh -c "$SCRIPT_DIR/t0 $TIMEOUT_VAL ./$1 $(cat ./$(echo "$1"
> | sed 's,\.[^\.]*,,').args 2>/dev/null)" > $complog 2>&1
>
> - set +x
> -
> ret_code=$?
>
> if [ "$ret_code" = "0" ]; then
> --
> 1.7.0.4
Great!
I was forestalled :)
I have the same opinion, too.
Thank you--
-Tomonori Mitani
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [LTP] [PATCH] Fix all tests pass error
2010-10-28 2:40 ` Mitani
@ 2010-10-28 16:55 ` Garrett Cooper
0 siblings, 0 replies; 3+ messages in thread
From: Garrett Cooper @ 2010-10-28 16:55 UTC (permalink / raw)
To: Mitani; +Cc: ltp-list
On Wed, Oct 27, 2010 at 7:40 PM, Mitani <mitani@ryobi.co.jp> wrote:
>> -----Original Message-----
>> From: Gui Jianfeng [mailto:guijianfeng@cn.fujitsu.com]
>> Sent: Thursday, October 28, 2010 10:55 AM
>> To: Garrett Cooper
>> Cc: mitani@ryobi.co.jp; ltp-list@lists.sourceforge.net
>> Subject: [PATCH] Fix all tests pass error
>>
>> ret_code comes from "set +x" which always return 0, this makes all tests
>> PASS.
>> Actually, "set +x" isn't needed here, just get rid of it.
>>
>> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
>> ---
>> testcases/open_posix_testsuite/bin/run-tests.sh | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/open_posix_testsuite/bin/run-tests.sh
>> b/testcases/open_posix_testsuite/bin/run-tests.sh
>> index 6a03856..04a39dd 100755
>> --- a/testcases/open_posix_testsuite/bin/run-tests.sh
>> +++ b/testcases/open_posix_testsuite/bin/run-tests.sh
>> @@ -48,8 +48,6 @@ run_test() {
>>
>> sh -c "$SCRIPT_DIR/t0 $TIMEOUT_VAL ./$1 $(cat ./$(echo "$1"
>> | sed 's,\.[^\.]*,,').args 2>/dev/null)" > $complog 2>&1
>>
>> - set +x
>> -
>> ret_code=$?
>>
>> if [ "$ret_code" = "0" ]; then
>> --
>> 1.7.0.4
>
>
> Great!
>
> I was forestalled :)
> I have the same opinion, too.
Fixed -- thanks :/...
-Garrett
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-28 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-28 1:54 [LTP] [PATCH] Fix all tests pass error Gui Jianfeng
2010-10-28 2:40 ` Mitani
2010-10-28 16:55 ` Garrett Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox