From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1PD6O3-0003Of-D6 for ltp-list@lists.sourceforge.net; Tue, 02 Nov 2010 02:14:11 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.69) id 1PD6O0-0003yY-KI for ltp-list@lists.sourceforge.net; Tue, 02 Nov 2010 02:14:11 +0000 Message-ID: <4CCF7388.1060706@cn.fujitsu.com> Date: Tue, 02 Nov 2010 10:12:24 +0800 From: Bian Naimeng MIME-Version: 1.0 References: <4CCF6B53.5050109@cn.fujitsu.com> <4CCF7166.1050105@cn.fujitsu.com> In-Reply-To: Subject: Re: [LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: ltp-list@lists.sourceforge.net Garrett Cooper 写道: > On Mon, Nov 1, 2010 at 7:03 PM, Bian Naimeng wrote: >>>> --- >>>> .../conformance/interfaces/shm_open/2-1.c | 4 +++- >>>> 1 files changed, 3 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c >>>> index f4bab48..b0adce6 100644 >>>> --- a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c >>>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c >>>> @@ -17,7 +17,9 @@ >>>> >>>> int main() >>>> { >>>> - printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description."); >>>> + printf("Will not test that the shm_open() function create an open file" >>>> + "description that refers to the shared memory object and a file" >>>> + "descriptor that refers to that open file description.\n"); >>>> return PTS_UNTESTED; >>>> } >>> Actually, that will look a lot worse because you just removed some >>> spaces in areas. description should be descriptor, etc. >> Yes, it's my mistake. Thank you for pointing out it. ^_^ > > I'm tempted to just delete this test because it's a no-op. Anyone object? > It looks good to me. > > -- Regards Bian Naimeng ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list