From: Carmelo AMOROSO <carmelo.amoroso@st.com>
To: Hannu Heikkinen <hannuxx@iki.fi>
Cc: "ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] ltp_clone alignment issues.
Date: Tue, 9 Nov 2010 12:24:27 +0100 [thread overview]
Message-ID: <4CD92F6B.9040508@st.com> (raw)
In-Reply-To: <20101004190552.GA997@debian-master.elisa-laajakaista.fi>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/4/2010 9:05 PM, Hannu Heikkinen wrote:
> On 04/10/10 15:04 +0200, Carmelo AMOROSO wrote:
> -clip-
> >
> > Hannu,
> > I don't think that it is a good to force the alignment; we could need to
> > write a test case that calls LTP_clone with an unaligned stack just to
> > test the behavior of the clone implementation.
> >
> > Likely, it should be useful to add a check inside the C lib clone
> > implementation (arch specific) to protect against unaligned stack, but
> > this is a different matter.
> >
> > I would just leave the LTP_clone passing the argument to the clone as
> > they came from the caller.
> >
> > Regards,
> > Carmelo
> >
>
> Hi Carmelo,
>
> you've got point, yes. I was just so worried about the fact that in ARM
> architectures that previous eg clone02 failed due to alignment errors.
> But your fix of course fixed that issue, and it gives as a possiblity
> to make test case against alignment issues, quite right.
>
> br,
> Hannu
>
Folks,
any change to get this included for the next release ?
Carmelo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkzZL2sACgkQoRq/3BrK1s/jqwCfakEHVCtM3Rpfx6rKU1MlXz5H
g4oAmwQ/VMZPc3IxkhKa0Tmgni7K1+zS
=MrS2
-----END PGP SIGNATURE-----
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-11-09 11:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 13:34 [LTP] ltp_clone alignment issues Carmelo AMOROSO
2010-09-29 13:34 ` Carmelo AMOROSO
2010-09-30 13:31 ` Hannu Heikkinen
2010-09-30 10:42 ` Carmelo AMOROSO
2010-10-01 4:06 ` Hannu Heikkinen
2010-10-04 13:04 ` Carmelo AMOROSO
2010-10-04 13:28 ` Garrett Cooper
2010-10-04 19:09 ` Hannu Heikkinen
2010-10-04 20:00 ` Hannu Heikkinen
2010-10-04 20:57 ` Garrett Cooper
2010-10-05 6:05 ` Carmelo AMOROSO
2010-10-04 19:05 ` Hannu Heikkinen
2010-11-09 11:24 ` Carmelo AMOROSO [this message]
2010-11-11 7:57 ` Subrata Modak
2010-11-11 8:08 ` Carmelo AMOROSO
2010-11-11 9:59 ` Garrett Cooper
2010-11-15 7:29 ` Carmelo AMOROSO
2010-11-21 3:34 ` Garrett Cooper
2010-11-24 8:30 ` Carmelo AMOROSO
2010-11-24 8:44 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD92F6B.9040508@st.com \
--to=carmelo.amoroso@st.com \
--cc=hannuxx@iki.fi \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox