From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1PFmKc-0001v6-6H for ltp-list@lists.sourceforge.net; Tue, 09 Nov 2010 11:25:42 +0000 Received: from eu1sys200aog103.obsmtp.com ([207.126.144.115]) by sog-mx-4.v43.ch3.sourceforge.com with smtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1PFmKa-0006aW-Mb for ltp-list@lists.sourceforge.net; Tue, 09 Nov 2010 11:25:42 +0000 From: Carmelo AMOROSO Date: Tue, 9 Nov 2010 12:24:27 +0100 Message-ID: <4CD92F6B.9040508@st.com> References: <4CA09D4D.6050708@st.com> <4CA34070.9070505@st.com> <20100930133120.GA4070@hannu-debian.research.nokia.com> <4CA469A0.5090700@st.com> <20101001040609.GA2090@hannu-ubuntu> <4CA9D0EB.5090309@st.com> <20101004190552.GA997@debian-master.elisa-laajakaista.fi> In-Reply-To: <20101004190552.GA997@debian-master.elisa-laajakaista.fi> MIME-Version: 1.0 Subject: Re: [LTP] ltp_clone alignment issues. List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Hannu Heikkinen Cc: "ltp-list@lists.sourceforge.net" -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/4/2010 9:05 PM, Hannu Heikkinen wrote: > On 04/10/10 15:04 +0200, Carmelo AMOROSO wrote: > -clip- > > > > Hannu, > > I don't think that it is a good to force the alignment; we could need to > > write a test case that calls LTP_clone with an unaligned stack just to > > test the behavior of the clone implementation. > > > > Likely, it should be useful to add a check inside the C lib clone > > implementation (arch specific) to protect against unaligned stack, but > > this is a different matter. > > > > I would just leave the LTP_clone passing the argument to the clone as > > they came from the caller. > > > > Regards, > > Carmelo > > > > Hi Carmelo, > > you've got point, yes. I was just so worried about the fact that in ARM > architectures that previous eg clone02 failed due to alignment errors. > But your fix of course fixed that issue, and it gives as a possiblity > to make test case against alignment issues, quite right. > > br, > Hannu > Folks, any change to get this included for the next release ? Carmelo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzZL2sACgkQoRq/3BrK1s/jqwCfakEHVCtM3Rpfx6rKU1MlXz5H g4oAmwQ/VMZPc3IxkhKa0Tmgni7K1+zS =MrS2 -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list