[LTP] [RFC][PATCH]Skip DOTS category always

[LTP] [RFC][PATCH]Skip DOTS category always

[Bian Naimeng]

After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught
when install test suite.

make[2]: Entering directory `/home/biannm/ltp-882ad81/testcases/DOTS'
make[2]: *** No rule to make target `install'.  Stop.
make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
make: *** [testcases-install] Error 2

The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error
reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we
add a checking, it looks unnecessary.

------
Dots need be skip always.

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 testcases/Makefile |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/testcases/Makefile b/testcases/Makefile
index b30d6d4..4792811 100644
--- a/testcases/Makefile
+++ b/testcases/Makefile
@@ -31,7 +31,7 @@ include $(top_srcdir)/include/mk/env_pre.mk
 #    run).
 # 3. mce-test doesn't fit cleanly in the build, yet.
 # 4. pounder21 is just broken.
-FILTER_OUT_DIRS		:= ballista kdump mce-test open% pounder21
+FILTER_OUT_DIRS		:= DOTS ballista kdump mce-test open% pounder21
 
 # XXX (garrcoop): Not sure why realtime is still in this list; this was the
 # original list of disabled items...
@@ -41,11 +41,6 @@ ifeq ($(UCLINUX),1)
 FILTER_OUT_DIRS		+= realtime
 endif
 
-# DOTS requires javac
-ifeq ($(strip $(JAVAC)),)
-FILTER_OUT_DIRS		+= DOTS
-endif
-
 #
 # XXX (garrcoop): disabling the open_posix_testsuite by request from Subrata
 # due to build times (open_posix_testsuite runs serially by design to
-- 
1.7.0.4




-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC][PATCH]Skip DOTS category always

[Gui Jianfeng]

Bian Naimeng wrote:
> After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught
> when install test suite.
> 
> make[2]: Entering directory `/home/biannm/ltp-882ad81/testcases/DOTS'
> make[2]: *** No rule to make target `install'.  Stop.
> make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS'
> make[1]: *** [install] Error 2
> make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
> make: *** [testcases-install] Error 2
> 
> The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error
> reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we
> add a checking, it looks unnecessary.
> 
> ------
> Dots need be skip always.
> 
> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

Hi Garrettt,

This installation failure is really noisy. Would you Apply this patch?

Gui

> 
> ---
>  testcases/Makefile |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/testcases/Makefile b/testcases/Makefile
> index b30d6d4..4792811 100644
> --- a/testcases/Makefile
> +++ b/testcases/Makefile
> @@ -31,7 +31,7 @@ include $(top_srcdir)/include/mk/env_pre.mk
>  #    run).
>  # 3. mce-test doesn't fit cleanly in the build, yet.
>  # 4. pounder21 is just broken.
> -FILTER_OUT_DIRS		:= ballista kdump mce-test open% pounder21
> +FILTER_OUT_DIRS		:= DOTS ballista kdump mce-test open% pounder21
>  
>  # XXX (garrcoop): Not sure why realtime is still in this list; this was the
>  # original list of disabled items...
> @@ -41,11 +41,6 @@ ifeq ($(UCLINUX),1)
>  FILTER_OUT_DIRS		+= realtime
>  endif
>  
> -# DOTS requires javac
> -ifeq ($(strip $(JAVAC)),)
> -FILTER_OUT_DIRS		+= DOTS
> -endif
> -
>  #
>  # XXX (garrcoop): disabling the open_posix_testsuite by request from Subrata
>  # due to build times (open_posix_testsuite runs serially by design to

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC][PATCH]Skip DOTS category always

[Garrett Cooper]

On Tue, Nov 9, 2010 at 11:37 PM, Gui Jianfeng
<guijianfeng@cn.fujitsu.com> wrote:
> Bian Naimeng wrote:
>> After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught
>> when install test suite.
>>
>> make[2]: Entering directory `/home/biannm/ltp-882ad81/testcases/DOTS'
>> make[2]: *** No rule to make target `install'.  Stop.
>> make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS'
>> make[1]: *** [install] Error 2
>> make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
>> make: *** [testcases-install] Error 2
>>
>> The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error
>> reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we
>> add a checking, it looks unnecessary.
>>
>> ------
>> Dots need be skip always.
>>
>> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>
> Hi Garrettt,
>
> This installation failure is really noisy. Would you Apply this patch?

    DOTS is no longer built as part of the standard build as of last
night and unless someone speaks up opposing it, it's going away
tomorrow evening.
Thanks,
-Garrett

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC][PATCH]Skip DOTS category always

[Subrata Modak]

On Wed, 2010-11-10 at 00:26 -0800, Garrett Cooper wrote: 
> On Tue, Nov 9, 2010 at 11:37 PM, Gui Jianfeng
> <guijianfeng@cn.fujitsu.com> wrote:
> > Bian Naimeng wrote:
> >> After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught
> >> when install test suite.
> >>
> >> make[2]: Entering directory `/home/biannm/ltp-882ad81/testcases/DOTS'
> >> make[2]: *** No rule to make target `install'.  Stop.
> >> make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS'
> >> make[1]: *** [install] Error 2
> >> make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
> >> make: *** [testcases-install] Error 2
> >>
> >> The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error
> >> reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we
> >> add a checking, it looks unnecessary.
> >>
> >> ------
> >> Dots need be skip always.
> >>
> >> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> >
> > Hi Garrettt,
> >
> > This installation failure is really noisy. Would you Apply this patch?
> 
>     DOTS is no longer built as part of the standard build as of last
> night and unless someone speaks up opposing it, it's going away
> tomorrow evening.

Yah, it is not used by anybody anymore i believe.

Regards--
Subrata

> Thanks,
> -Garrett
> 
> ------------------------------------------------------------------------------
> The Next 800 Companies to Lead America's Growth: New Video Whitepaper
> David G. Thomson, author of the best-selling book "Blueprint to a 
> Billion" shares his insights and actions to help propel your 
> business during the next growth cycle. Listen Now!
> http://p.sf.net/sfu/SAP-dev2dev
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list