Re: [LTP] ltp_clone alignment issues.

Garrett Cooper
2010-10-04T20:57:37Z

On Mon, Oct 4, 2010 at 1:00 PM, Hannu Heikkinen <hannuxx@iki.fi> wrote:
> On 04/10/10 06:28 -0700, Garrett Cooper wrote:
>>
>>     I believe this is already handled to some degree with the clone
>> testcases. If not that should be added and I'll review patches which
>> add this testing to LTP.
>>     On a semi-unrelated note could you guys please test out the
>> attached patch to make sure that there isn't a functional difference
>> if you have access to ia64, s390, etc?
>> Thanks,
>> -Garrett
>
> Hi,
>
> after that CHILD_STACK_SIZE (def for as it has been 16384) tests passed in
> AMD64 - Debian 64-bit and BeagleBoard 32-bit ARM (std linux-2.6 with
> omap3_defconfig).
>
> Test files are attached. I ran clones in /opt/ltp/testcases/bin straight.

Good catch :). It's always fun making changes when your primary
box isn't linux anymore, dealing with VMs in a minor pain, and you
miss an important minor detail :/.
The point of the proposed change was to remove all duplicate
macros from the LTP clone header because I noticed some were defined
twice, and over time bitrotted code tends to negatively affect tests
in the source base (in particular because someone changes one bit of
code and completely ignores/overlooks N-1 other copies of that exact
piece of duplicated code -- I've been known to do this by accident as
well)...
Thanks for testing!
-Garrett

------------------------------------------------------------------------------
Virtualization is moving to the mainstream and overtaking non-virtualized
environment for deploying applications. Does it make network security
easier or more difficult to achieve? Read this whitepaper to separate the
two and get a better understanding.