Re: [LTP] ltp_clone alignment issues.

Carmelo AMOROSO
2010-11-09T11:25:42Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/4/2010 9:05 PM, Hannu Heikkinen wrote:
> On 04/10/10 15:04 +0200, Carmelo AMOROSO wrote:
> -clip-
> >
> > Hannu,
> > I don't think that it is a good to force the alignment; we could need to
> > write a test case that calls LTP_clone with an unaligned stack just to
> > test the behavior of the clone implementation.
> >
> > Likely, it should be useful to add a check inside the C lib clone
> > implementation (arch specific) to protect against unaligned stack, but
> > this is a different matter.
> >
> > I would just leave the LTP_clone passing the argument to the clone as
> > they came from the caller.
> >
> > Regards,
> > Carmelo
> >
>
> Hi Carmelo,
>
> you've got point, yes. I was just so worried about the fact that in ARM
> architectures that previous eg clone02 failed due to alignment errors.
> But your fix of course fixed that issue, and it gives as a possiblity
> to make test case against alignment issues, quite right.
>
> br,
> Hannu
>

Folks,
any change to get this included for the next release ?

Carmelo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzZL2sACgkQoRq/3BrK1s/jqwCfakEHVCtM3Rpfx6rKU1MlXz5H
g4oAmwQ/VMZPc3IxkhKa0Tmgni7K1+zS
=MrS2
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!