[LTP] [POSIX[PATCH]Fix the bug of generate-makefiles.sh

[LTP] [POSIX[PATCH]Fix the bug of generate-makefiles.sh

[Bian Naimeng]

Script generate-makefiles.sh has a bug, it can cause run.sh miss some tests.
For exemple, this is the makefile of conformance/interfaces/sched_getparam:

INSTALL_TARGETS+=       4-1.run-test 5-1.sh
MAKE_TARGETS+=          4-1.run-test

INSTALL_TARGETS+=       2-1.run-test 1-1.run-test 3-1.run-test 6-1.run-test
MAKE_TARGETS+=          2-1.run-test 1-1.run-test 3-1.run-test 6-1.run-test

... snip ...

run.sh:
        @echo '#/bin/sh' > $@
        @echo "$(top_srcdir)/bin/run-tests.sh $(subdir) 4-1.run-test 5-1.sh" >> $@
        @chmod +x run.sh

So what about the following patch?

----------------------------------------------------------------------------------

If there are some source files at the child directory, generate_makefile will
be invoked twice, then run.sh will miss some tests.

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 .../scripts/generate-makefiles.sh                  |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
index 536d407..ed6406f 100755
--- a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
+++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
@@ -152,11 +152,11 @@ EOF
 
 	fi
 
-	if [ "$tests" != "" ] && ! grep -q '^run.sh' "$makefile.3"; then
+	if ! grep -q '^run.sh' "$makefile.3"; then
 		cat >> "$makefile.3" <<EOF
 run.sh:
 	@echo '#/bin/sh' > \$@
-	@echo "\$(top_srcdir)/bin/run-tests.sh \$(subdir) $tests" >> \$@
+	@echo "\$(top_srcdir)/bin/run-tests.sh \$(subdir) \$(INSTALL_TARGETS)" >> \$@
 	@chmod +x run.sh
 
 EOF
-- 
1.7.0.4



-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [POSIX][PATCH]Fix the bug of generate-makefiles.sh

[Bian Naimeng]

At the latest open_posix_testsuites, buildonly targets will be tested
when run "make test", so it will report many failure.

---------------
We just need install these targets which is a test.

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 .../scripts/generate-makefiles.sh                  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
index ed6406f..8bf70c1 100755
--- a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
+++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
@@ -121,7 +121,7 @@ EOF
 	fi
 
 	cat >> "$makefile.2" <<EOF
-INSTALL_TARGETS+=	${prereq_cache}
+INSTALL_TARGETS+=	${tests}
 MAKE_TARGETS+=		${make_target_prereq_cache}
 
 EOF
-- 
1.7.0.4




-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [POSIX][PATCH]Fix the bug of generate-makefiles.sh

[Garrett Cooper]

On Dec 20, 2010, at 11:47 PM, Bian Naimeng wrote:

> At the latest open_posix_testsuites, buildonly targets will be tested
> when run "make test", so it will report many failure.
> 
> ---------------
> We just need install these targets which is a test.
> 
> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> 
> ---
> .../scripts/generate-makefiles.sh                  |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> index ed6406f..8bf70c1 100755
> --- a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> +++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> @@ -121,7 +121,7 @@ EOF
> 	fi
> 
> 	cat >> "$makefile.2" <<EOF
> -INSTALL_TARGETS+=	${prereq_cache}
> +INSTALL_TARGETS+=	${tests}
> MAKE_TARGETS+=		${make_target_prereq_cache}

Committed.
Thanks!
-Garrett
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list