[LTP] [PATCH 00/13]Fix a few syntax error

[LTP] [PATCH 00/13]Fix a few syntax error

[tangchen]

There are several small bugs making LTP unable to be built, most of 
which are syntax errors.

1. Add missing parameters for tst_brkm() in 
testcases/kernel/syscalls/fchmod/fchmod03.c
2. Add missing parameters for tst_brkm() in 
testcases/kernel/syscalls/flock/flock04.c
3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
4. Correct the parameters' names for parse_opts() in 
testcases/kernel/syscalls/lchown/lchown02.c
5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c 
bacause KSM is not supported on RHEL5
6. Add missing operators for parse_opts() in 
testcases/kernel/syscalls/msync/msync04.c
7. Fix an wrong using of macro WTERMSIG in 
testcases/kernel/syscalls/pipe/pipe04.c
8. Fix the wrong variable name of wtstatus in 
testcases/kernel/syscalls/pipe/pipe09.c
9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
10. Remove a redundant "{" in 
testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
11. Fix the wrong using of perror() in 
testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
12. Add a missing variable TST_TOTAL in 
testcases/kernel/syscalls/socketpair/socketpair02.c
13. Add missing parameters for tst_brkm() in 
testcases/kernel/syscalls/statfs/statfs03.c

-- 
Best Regards,
Tang chen
--------------------------------------------------
Tang Chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 01/13]Add missing parameters for tst_brkm()

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/fchmod/fchmod03.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/fchmod/fchmod03.c 
b/testcases/kernel/syscalls/fchmod/fchmod03.c
index 9c4ab34..d0c1255 100644
--- a/testcases/kernel/syscalls/fchmod/fchmod03.c
+++ b/testcases/kernel/syscalls/fchmod/fchmod03.c
@@ -178,7 +178,7 @@ void cleanup()
      TEST_CLEANUP;

      if (close(fd) == -1)
-        tst_brkm(TWARN|TERRNO, "close failed");
+        tst_brkm(TWARN|TERRNO, NULL, "close failed");

      tst_rmdir();

-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 01/13]Add missing parameters for tst_brkm()

[Mike Frysinger]

On Thu, Jan 6, 2011 at 5:54 AM, tangchen wrote:
> --- a/testcases/kernel/syscalls/fchmod/fchmod03.c
> +++ b/testcases/kernel/syscalls/fchmod/fchmod03.c
> @@ -178,7 +178,7 @@ void cleanup()
>      TEST_CLEANUP;
>
>      if (close(fd) == -1)
> -        tst_brkm(TWARN|TERRNO, "close failed");
> +        tst_brkm(TWARN|TERRNO, NULL, "close failed");

i guess we should add a non-null gcc attribute to the tst_brkm
function ... and perhaps a printf attribute if it doesnt have one
already
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 02/13]Add missing parameters for tst_brkm()

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/flock/flock04.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/flock/flock04.c 
b/testcases/kernel/syscalls/flock/flock04.c
index cd6b230..a3bc855 100644
--- a/testcases/kernel/syscalls/flock/flock04.c
+++ b/testcases/kernel/syscalls/flock/flock04.c
@@ -123,7 +123,7 @@ int main(int argc, char **argv)
                  exit(0);
              } else
                  if (wait(&status) == -1)
-                    tst_brkm(TBROK|TERRNO, "wait failed");
+                    tst_brkm(TBROK|TERRNO, cleanup, "wait failed");

              pid = FORK_OR_VFORK();
              if (pid == -1)
@@ -144,7 +144,7 @@ int main(int argc, char **argv)
                  exit(0);
              } else
                  if (wait(&status) == -1)
-                    tst_brkm(TBROK|TERRNO, "wait failed");
+                    tst_brkm(TBROK|TERRNO, cleanup, "wait failed");
              TEST(flock(fd, LOCK_UN));
          } else
              tst_resm(TFAIL|TERRNO, "flock failed");
-- 
1.7.0.4


-- 
Best Regards,
Tang chen
--------------------------------------------------
Tang Chen
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
No.6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8513
FUJITSU INTERNAL: 7998-8513
FAX: +86+25-83317685
EMail: tangchen@cn.fujitsu.com
--------------------------------------------------
This communication is for use by the intended recipient(s) only and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not an intended recipient of this communication, you are hereby notified that any dissemination, distribution or copying hereof is strictly prohibited.  If you have received this communication in error, please notify me by reply e-mail, permanently delete this communication from your system, and destroy any hard copies you may have printed



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 03/13]Add a missing ";"

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  .../kernel/syscalls/getpagesize/getpagesize01.c    |    8 +++++---
  1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/getpagesize/getpagesize01.c 
b/testcases/kernel/syscalls/getpagesize/getpagesize01.c
index 09c229e..9b6e27e 100644
--- a/testcases/kernel/syscalls/getpagesize/getpagesize01.c
+++ b/testcases/kernel/syscalls/getpagesize/getpagesize01.c
@@ -77,8 +77,9 @@ int main(int ac, char **av)

          /* check return code */
          if (TEST_RETURN == -1) {
-            tst_resm(TFAIL|TTERRNO, "getpagesize failed"),
-            continue;    /* next loop for MTKERNEL */
+            tst_resm(TFAIL|TTERRNO, "getpagesize failed");
+            /* next loop for MTKERNEL */
+            continue;
          }

          if (STD_FUNCTIONAL_TEST) {
@@ -126,4 +127,5 @@ void cleanup()
       * print errno log if that option was specified.
       */
      TEST_CLEANUP;
-}
\ No newline at end of file
+}
+
-- 
1.7.0.4


-- 
Best Regards,
Tang chen
--------------------------------------------------
Tang Chen
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
No.6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8513
FUJITSU INTERNAL: 7998-8513
FAX: +86+25-83317685
EMail: tangchen@cn.fujitsu.com
--------------------------------------------------
This communication is for use by the intended recipient(s) only and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not an intended recipient of this communication, you are hereby notified that any dissemination, distribution or copying hereof is strictly prohibited.  If you have received this communication in error, please notify me by reply e-mail, permanently delete this communication from your system, and destroy any hard copies you may have printed



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 04/13]Correct the wrong parameters names

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/lchown/lchown02.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/lchown/lchown02.c 
b/testcases/kernel/syscalls/lchown/lchown02.c
index 9a213a2..04cb943 100644
--- a/testcases/kernel/syscalls/lchown/lchown02.c
+++ b/testcases/kernel/syscalls/lchown/lchown02.c
@@ -151,7 +151,7 @@ int main(int argc, char *argv[])
      gid_t group_id;
      int i;

-    if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
+    if ((msg = parse_opts(argc, argv, NULL, NULL)) != NULL)
          tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);

      setup();
-- 
1.7.0.4

-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 05/13]Add some preprocessor variables

[tangchen]

KSM is not supported on RHEL5.

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/mem/ksm/ksm01.c        |   18 +++++++++++++++---
  testcases/kernel/syscalls/mmap/mmap10.c |    6 +++++-
  2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/mem/ksm/ksm01.c 
b/testcases/kernel/mem/ksm/ksm01.c
index 09f71d7..2b10fef 100644
--- a/testcases/kernel/mem/ksm/ksm01.c
+++ b/testcases/kernel/mem/ksm/ksm01.c
@@ -70,11 +70,15 @@
  #include "test.h"
  #include "usctest.h"

-#define _PATH_KSM    "/sys/kernel/mm/ksm/"
-#define MB        (1024 * 1024)

  char *TCID = "ksm01";
  int TST_TOTAL = 1;
+
+#ifdef    MADV_MERGEABLE
+
+#define _PATH_KSM    "/sys/kernel/mm/ksm/"
+#define MB        (1024 * 1024)
+
  static int opt_num, opt_size;
  static char *opt_numstr, *opt_sizestr;
  /* memory pointer to identify per process, MB, and byte like
@@ -536,4 +540,12 @@ void group_check(int run, int pages_shared, int 
pages_sharing,
      check("pages_unshared", NULL, pages_unshared);
      check("sleep_millisecs", NULL, sleep_millisecs);
      check("pages_to_scan", NULL, pages_to_scan);
-}
\ No newline at end of file
+}
+
+#else
+int main(int argc, char *argv[])
+{
+    tst_brkm(TRETR, tst_exit, "KSM is unsupported");
+}
+#endif
+
diff --git a/testcases/kernel/syscalls/mmap/mmap10.c 
b/testcases/kernel/syscalls/mmap/mmap10.c
index b31975e..e3a158e 100644
--- a/testcases/kernel/syscalls/mmap/mmap10.c
+++ b/testcases/kernel/syscalls/mmap/mmap10.c
@@ -115,9 +115,13 @@ void mmapzero(void)
      if (x == MAP_FAILED)
          tst_brkm(TBROK|TERRNO, cleanup, "mmap");
      if (opt_ksm) {
+#ifdef    MADV_MERGEABLE
          tst_resm(TINFO, "add to KSM regions.");
          if (madvise(x, SIZE+SIZE-4096, MADV_MERGEABLE) == -1)
              tst_brkm(TBROK|TERRNO, cleanup, "madvise");
+#else
+        tst_brkm(TRETR, cleanup, "KSM is unsupported.");
+#endif
      }
      x[SIZE] = 0;

@@ -175,4 +179,4 @@ void help(void)
  {
      printf("  -a      Test anonymous pages\n");
      printf("  -s      Add to KSM regions\n");
-}
\ No newline at end of file
+}
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 05/13]Add some preprocessor variables

[Mike Frysinger]

On Thu, Jan 6, 2011 at 6:02 AM, tangchen wrote:
> +#else
> +int main(int argc, char *argv[])
> +{
> +    tst_brkm(TRETR, tst_exit, "KSM is unsupported");
> +}
> +#endif

i forget ... what did we decide for situations like this ?  tst_bkrm(TCONF) ?
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 05/13]Add some preprocessor variables

[Garrett Cooper]

On Jan 6, 2011, at 10:23 AM, Mike Frysinger wrote:

> On Thu, Jan 6, 2011 at 6:02 AM, tangchen wrote:
>> +#else
>> +int main(int argc, char *argv[])
>> +{
>> +    tst_brkm(TRETR, tst_exit, "KSM is unsupported");
>> +}
>> +#endif
> 
> i forget ... what did we decide for situations like this ?  tst_bkrm(TCONF) ?

TCONF makes more sense.
Thanks,
-Garrett


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 06/13]Add missing operators

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/msync/msync04.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/msync/msync04.c 
b/testcases/kernel/syscalls/msync/msync04.c
index 3e4b9a4..4e5dccb 100644
--- a/testcases/kernel/syscalls/msync/msync04.c
+++ b/testcases/kernel/syscalls/msync/msync04.c
@@ -93,7 +93,7 @@ int main(int ac, char **av)
      char *msg;        /* message returned from parse_opts */

      /* Parse standard options given to run the test. */
-    if ((msg = parse_opts(ac, av, NULL, NULL)) NULL)
+    if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
          tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);

      TEST_EXP_ENOS(exp_enos);
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 06/13]Add missing operators

[Garrett Cooper]

On Jan 6, 2011, at 3:03 AM, tangchen wrote:

> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
>  testcases/kernel/syscalls/msync/msync04.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/msync/msync04.c 
> b/testcases/kernel/syscalls/msync/msync04.c
> index 3e4b9a4..4e5dccb 100644
> --- a/testcases/kernel/syscalls/msync/msync04.c
> +++ b/testcases/kernel/syscalls/msync/msync04.c
> @@ -93,7 +93,7 @@ int main(int ac, char **av)
>      char *msg;        /* message returned from parse_opts */
> 
>      /* Parse standard options given to run the test. */
> -    if ((msg = parse_opts(ac, av, NULL, NULL)) NULL)
> +    if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
>          tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);

	Patch is good despite the fact that the description is misleading.
	I checked in a different fix though.
Thanks,
-Garrett


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 07/13]Fix an wrong using of macro WTERMSIG

[tangchen]

WRETMSIG need a argument.

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/pipe/pipe04.c |    8 +++++---
  1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/pipe/pipe04.c 
b/testcases/kernel/syscalls/pipe/pipe04.c
index 20d87d4..f153f4a 100644
--- a/testcases/kernel/syscalls/pipe/pipe04.c
+++ b/testcases/kernel/syscalls/pipe/pipe04.c
@@ -80,7 +80,7 @@ int main(int ac, char **av)
      int lc;            /* loop counter */
      char *msg;        /* message returned from parse_opts */
      pid_t c1pid, c2pid;
-    int wtchild, wtstatus;
+    int wtstatus;
      int bytesread;
      int acnt = 0, bcnt = 0;

@@ -187,7 +187,8 @@ int main(int ac, char **av)
                       "writing to a pipe");
          }
          if (waitpid(c2pid, &wtstatus, 0) != -1) {
-            if (!WIFSIGNALED(wtstatus) || WTERMSIG != SIGKILL)
+            if (!WIFSIGNALED(wtstatus) ||
+                WTERMSIG(wtstatus) != SIGKILL)
                  tst_resm(TFAIL|TERRNO, "unexpected wait status "
                      "%d", wtstatus);
              else
@@ -249,4 +250,5 @@ void alarmfunc(int sig)
      /* for some reason tst_brkm doesn't seem to work in a signal 
handler */
      tst_brkm(TFAIL, cleanup, "one or more children did't die in 60 
second "
          "time limit");
-}
\ No newline at end of file
+}
+
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 08/13]Fix the wrong variable name of wtstatus

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/pipe/pipe09.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/pipe/pipe09.c 
b/testcases/kernel/syscalls/pipe/pipe09.c
index 7990fb6..ac9796e 100644
--- a/testcases/kernel/syscalls/pipe/pipe09.c
+++ b/testcases/kernel/syscalls/pipe/pipe09.c
@@ -131,7 +131,7 @@ int main(int ac, char **av)

          if (waitpid(fork_1, &wtstatus, 0) == -1)
              tst_brkm(TBROK, cleanup, "waitpid failed");
-        if (WIFEXITED(wstatus) && WEXITSTATUS(wtstatus) != 0) {
+        if (WIFEXITED(wtstatus) && WEXITSTATUS(wtstatus) != 0) {
              tst_brkm(TBROK, cleanup, "child exited abnormally");
          }

@@ -226,4 +226,5 @@ void cleanup()
       * print errno log if that option was specified.
       */
      TEST_CLEANUP;
-}
\ No newline at end of file
+}
+
-- 
1.7.0.4

-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 09/13]Add a missing ")"

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/pread/pread03.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/pread/pread03.c 
b/testcases/kernel/syscalls/pread/pread03.c
index 3a33ced..3bfad80 100644
--- a/testcases/kernel/syscalls/pread/pread03.c
+++ b/testcases/kernel/syscalls/pread/pread03.c
@@ -106,7 +106,7 @@ int main(int ac, char **av)
      char *test_desc;    /* test specific error message */

      /* Parse standard options given to run the test. */
-    if ((msg = parse_opts(ac, av, NULL, NULL) != NULL)
+    if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
          tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);

      setup();
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/13]Add a missing ")"

[Mike Frysinger]

On Thu, Jan 6, 2011 at 6:07 AM, tangchen wrote:
>  testcases/kernel/syscalls/pread/pread03.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

please use more useful summaries.  in this case, your summary should
be prefixed with "pread03: ".
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 10/13]Remove a redundant "{"

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  .../syscalls/sched_getparam/sched_getparam02.c     |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/sched_getparam/sched_getparam02.c 
b/testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
index 72d7d20..4a15acc 100644
--- a/testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
+++ b/testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
@@ -94,7 +94,7 @@ int main(int ac, char **av)
      pid_t child_pid;

      /* parse standard options */
-    if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL) {
+    if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
          tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);

      setup();
@@ -180,4 +180,5 @@ void cleanup()
       * print errno log if that option was specified.
       */
      TEST_CLEANUP;
-}
\ No newline at end of file
+}
+
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 10/13]Remove a redundant "{"

[Mike Frysinger]

On Thu, Jan 6, 2011 at 6:08 AM, tangchen <tangchen@cn.fujitsu.com> wrote:
> @@ -180,4 +180,5 @@ void cleanup()
>       * print errno log if that option was specified.
>       */
>      TEST_CLEANUP;
> -}
> \ No newline at end of file
> +}
> +

please dont add trailing newlines
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 11/13]Fix the wrong using of perror()

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  .../syscalls/sched_setparam/sched_setparam03.c     |    6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/sched_setparam/sched_setparam03.c 
b/testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
index eb70588..16f3d3a 100644
--- a/testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
+++ b/testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
@@ -121,7 +121,8 @@ int main(int ac, char **av)
              TEST(sched_setparam(getppid(), &param));

              if (TEST_RETURN == -1) {
-                perror("sched_setparam returned %ld", TEST_RETURN);
+                fprintf(stderr, "sched_setparam returned %ld: "
+                    "%s\n", TEST_RETURN, strerror(errno));
                  exit(0);
              }
              exit(1);
@@ -201,4 +202,5 @@ int verify_priority()

      tst_resm(TWARN, "sched_getparam() failed");
      return 0;
-}
\ No newline at end of file
+}
+
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 11/13]Fix the wrong using of perror()

[Mike Frysinger]

On Thu, Jan 6, 2011 at 6:10 AM, tangchen wrote:
> --- a/testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
> +++ b/testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
> @@ -121,7 +121,8 @@ int main(int ac, char **av)
>              TEST(sched_setparam(getppid(), &param));
>
>              if (TEST_RETURN == -1) {
> -                perror("sched_setparam returned %ld", TEST_RETURN);
> +                fprintf(stderr, "sched_setparam returned %ld: "
> +                    "%s\n", TEST_RETURN, strerror(errno));
>                  exit(0);
>              }
>              exit(1);

odd, this should have caused a compile error ...

also, i wonder why this test isnt using tst_* helpers for its output ...
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 12/13]Add a missing variable TST_TOTAL

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  .../kernel/syscalls/socketpair/socketpair02.c      |    6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/socketpair/socketpair02.c 
b/testcases/kernel/syscalls/socketpair/socketpair02.c
index e898066..7ac74f3 100644
--- a/testcases/kernel/syscalls/socketpair/socketpair02.c
+++ b/testcases/kernel/syscalls/socketpair/socketpair02.c
@@ -65,7 +65,8 @@
  extern char *TESTDIR;        /* temporary dir created by tst_tmpdir() */

  /* Global Variables */
-char *TCID = "socketpair02";    /* test program identifier.              */
+char *TCID = "socketpair02";    /* test program identifier.*/
+int TST_TOTAL = 1;

  /* Extern Global Functions */
  /******************************************************************************/
@@ -162,4 +163,5 @@ int main(int argc, char *argv[])
      tst_resm(TPASS, "socketpair(SOCK_NONBLOCK) PASSED");
      cleanup();
      tst_exit();
-}
\ No newline at end of file
+}
+
-- 
1.7.0.4


-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 12/13]Add a missing variable TST_TOTAL

[Mike Frysinger]

On Thu, Jan 6, 2011 at 6:11 AM, tangchen wrote:
> --- a/testcases/kernel/syscalls/socketpair/socketpair02.c
> +++ b/testcases/kernel/syscalls/socketpair/socketpair02.c
> @@ -162,4 +163,5 @@ int main(int argc, char *argv[])
>      tst_resm(TPASS, "socketpair(SOCK_NONBLOCK) PASSED");
>      cleanup();
>      tst_exit();
> -}
> \ No newline at end of file
> +}
> +

please, no trailing new lines
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 13/13]Add missing parameters for tst_brkm()

[tangchen]

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
  testcases/kernel/syscalls/statfs/statfs03.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/statfs/statfs03.c 
b/testcases/kernel/syscalls/statfs/statfs03.c
index d60316b..226557e 100644
--- a/testcases/kernel/syscalls/statfs/statfs03.c
+++ b/testcases/kernel/syscalls/statfs/statfs03.c
@@ -140,7 +140,8 @@ void setup()
      } else {
          sprintf(path, "%s/%s", fname, fname);
          if ((fileHandle = creat(path, 0444)) == -1) {
-            tst_brkm(TFAIL|TERRNO, "creat (2) FAILED to creat temp file");
+            tst_brkm(TFAIL|TERRNO, cleanup,
+                 "creat (2) FAILED to creat temp file");
          }
      }

@@ -176,4 +177,4 @@ void cleanup()
      /* delete the test directory created in setup() */
      tst_rmdir();

-}
\ No newline at end of file
+}
-- 
1.7.0.4

-- 
Best Regards,
Tang chen



------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Mike Frysinger]

On Thu, Jan 6, 2011 at 5:49 AM, tangchen wrote:
> There are several small bugs making LTP unable to be built, most of
> which are syntax errors.
>
> 1. Add missing parameters for tst_brkm() in
> testcases/kernel/syscalls/fchmod/fchmod03.c
> 2. Add missing parameters for tst_brkm() in
> testcases/kernel/syscalls/flock/flock04.c
> 3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
> 4. Correct the parameters' names for parse_opts() in
> testcases/kernel/syscalls/lchown/lchown02.c
> 5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c
> bacause KSM is not supported on RHEL5
> 6. Add missing operators for parse_opts() in
> testcases/kernel/syscalls/msync/msync04.c
> 7. Fix an wrong using of macro WTERMSIG in
> testcases/kernel/syscalls/pipe/pipe04.c
> 8. Fix the wrong variable name of wtstatus in
> testcases/kernel/syscalls/pipe/pipe09.c
> 9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
> 10. Remove a redundant "{" in
> testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
> 11. Fix the wrong using of perror() in
> testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
> 12. Add a missing variable TST_TOTAL in
> testcases/kernel/syscalls/socketpair/socketpair02.c
> 13. Add missing parameters for tst_brkm() in
> testcases/kernel/syscalls/statfs/statfs03.c

this is weird ... how did all these *compile errors* manage to get
*committed* ??
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Garrett Cooper]

On Jan 6, 2011, at 10:26 AM, Mike Frysinger wrote:

> On Thu, Jan 6, 2011 at 5:49 AM, tangchen wrote:
>> There are several small bugs making LTP unable to be built, most of
>> which are syntax errors.
>> 
>> 1. Add missing parameters for tst_brkm() in
>> testcases/kernel/syscalls/fchmod/fchmod03.c
>> 2. Add missing parameters for tst_brkm() in
>> testcases/kernel/syscalls/flock/flock04.c
>> 3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
>> 4. Correct the parameters' names for parse_opts() in
>> testcases/kernel/syscalls/lchown/lchown02.c
>> 5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c
>> bacause KSM is not supported on RHEL5
>> 6. Add missing operators for parse_opts() in
>> testcases/kernel/syscalls/msync/msync04.c
>> 7. Fix an wrong using of macro WTERMSIG in
>> testcases/kernel/syscalls/pipe/pipe04.c
>> 8. Fix the wrong variable name of wtstatus in
>> testcases/kernel/syscalls/pipe/pipe09.c
>> 9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
>> 10. Remove a redundant "{" in
>> testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
>> 11. Fix the wrong using of perror() in
>> testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
>> 12. Add a missing variable TST_TOTAL in
>> testcases/kernel/syscalls/socketpair/socketpair02.c
>> 13. Add missing parameters for tst_brkm() in
>> testcases/kernel/syscalls/statfs/statfs03.c
> 
> this is weird ... how did all these *compile errors* manage to get
> *committed* ??

A really bad merge (I posted a reply to it a while ago in the archives).
-Garrett


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Garrett Cooper]

On Jan 6, 2011, at 11:35 AM, Garrett Cooper wrote:

> On Jan 6, 2011, at 10:26 AM, Mike Frysinger wrote:
> 
>> On Thu, Jan 6, 2011 at 5:49 AM, tangchen wrote:
>>> There are several small bugs making LTP unable to be built, most of
>>> which are syntax errors.
>>> 
>>> 1. Add missing parameters for tst_brkm() in
>>> testcases/kernel/syscalls/fchmod/fchmod03.c
>>> 2. Add missing parameters for tst_brkm() in
>>> testcases/kernel/syscalls/flock/flock04.c
>>> 3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
>>> 4. Correct the parameters' names for parse_opts() in
>>> testcases/kernel/syscalls/lchown/lchown02.c
>>> 5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c
>>> bacause KSM is not supported on RHEL5
>>> 6. Add missing operators for parse_opts() in
>>> testcases/kernel/syscalls/msync/msync04.c
>>> 7. Fix an wrong using of macro WTERMSIG in
>>> testcases/kernel/syscalls/pipe/pipe04.c
>>> 8. Fix the wrong variable name of wtstatus in
>>> testcases/kernel/syscalls/pipe/pipe09.c
>>> 9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
>>> 10. Remove a redundant "{" in
>>> testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
>>> 11. Fix the wrong using of perror() in
>>> testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
>>> 12. Add a missing variable TST_TOTAL in
>>> testcases/kernel/syscalls/socketpair/socketpair02.c
>>> 13. Add missing parameters for tst_brkm() in
>>> testcases/kernel/syscalls/statfs/statfs03.c
>> 
>> this is weird ... how did all these *compile errors* manage to get
>> *committed* ??
> 
> A really bad merge (I posted a reply to it a while ago in the archives).

Well, that and I also turned on -Werror to catch warnings-related errors.
-Garrett


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Mike Frysinger]

On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
> On Jan 6, 2011, at 10:26 AM, Mike Frysinger wrote:
>> On Thu, Jan 6, 2011 at 5:49 AM, tangchen wrote:
>>> There are several small bugs making LTP unable to be built, most of
>>> which are syntax errors.
>>>
>>> 1. Add missing parameters for tst_brkm() in
>>> testcases/kernel/syscalls/fchmod/fchmod03.c
>>> 2. Add missing parameters for tst_brkm() in
>>> testcases/kernel/syscalls/flock/flock04.c
>>> 3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
>>> 4. Correct the parameters' names for parse_opts() in
>>> testcases/kernel/syscalls/lchown/lchown02.c
>>> 5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c
>>> bacause KSM is not supported on RHEL5
>>> 6. Add missing operators for parse_opts() in
>>> testcases/kernel/syscalls/msync/msync04.c
>>> 7. Fix an wrong using of macro WTERMSIG in
>>> testcases/kernel/syscalls/pipe/pipe04.c
>>> 8. Fix the wrong variable name of wtstatus in
>>> testcases/kernel/syscalls/pipe/pipe09.c
>>> 9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
>>> 10. Remove a redundant "{" in
>>> testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
>>> 11. Fix the wrong using of perror() in
>>> testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
>>> 12. Add a missing variable TST_TOTAL in
>>> testcases/kernel/syscalls/socketpair/socketpair02.c
>>> 13. Add missing parameters for tst_brkm() in
>>> testcases/kernel/syscalls/statfs/statfs03.c
>>
>> this is weird ... how did all these *compile errors* manage to get
>> *committed* ??
>
> A really bad merge (I posted a reply to it a while ago in the archives).

i guess i read that as "things are fixed now" rather than "there are
still some latent issues laying about"
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Garrett Cooper]

On Thu, Jan 6, 2011 at 12:24 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
>> On Jan 6, 2011, at 10:26 AM, Mike Frysinger wrote:
>>> On Thu, Jan 6, 2011 at 5:49 AM, tangchen wrote:
>>>> There are several small bugs making LTP unable to be built, most of
>>>> which are syntax errors.
>>>>
>>>> 1. Add missing parameters for tst_brkm() in
>>>> testcases/kernel/syscalls/fchmod/fchmod03.c
>>>> 2. Add missing parameters for tst_brkm() in
>>>> testcases/kernel/syscalls/flock/flock04.c
>>>> 3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
>>>> 4. Correct the parameters' names for parse_opts() in
>>>> testcases/kernel/syscalls/lchown/lchown02.c
>>>> 5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c
>>>> bacause KSM is not supported on RHEL5
>>>> 6. Add missing operators for parse_opts() in
>>>> testcases/kernel/syscalls/msync/msync04.c
>>>> 7. Fix an wrong using of macro WTERMSIG in
>>>> testcases/kernel/syscalls/pipe/pipe04.c
>>>> 8. Fix the wrong variable name of wtstatus in
>>>> testcases/kernel/syscalls/pipe/pipe09.c
>>>> 9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
>>>> 10. Remove a redundant "{" in
>>>> testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
>>>> 11. Fix the wrong using of perror() in
>>>> testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
>>>> 12. Add a missing variable TST_TOTAL in
>>>> testcases/kernel/syscalls/socketpair/socketpair02.c
>>>> 13. Add missing parameters for tst_brkm() in
>>>> testcases/kernel/syscalls/statfs/statfs03.c
>>>
>>> this is weird ... how did all these *compile errors* manage to get
>>> *committed* ??
>>
>> A really bad merge (I posted a reply to it a while ago in the archives).
>
> i guess i read that as "things are fixed now" rather than "there are
> still some latent issues laying about"

    306 to be exact still need to be resolved; my previous number was
much lower because I forgot the power of make -k.
    I'll post the problem files soon (as a list) and a way for
reproducing the problems so that others can provide patches (maybe),
but [un]fortunately many times I have to go in and fix other items
anyhow, as the process that it goes and executes things sometimes
leaves test directories hanging around. On the bright side I've fixed
about 20-30 or so legitimate test bugs so far.
Thanks,
-Garrett "still making progress, but steady as she goes"

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Mike Frysinger]

On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
> A really bad merge (I posted a reply to it a while ago in the archives).

is there a way for us to manage the git hooks ?  we could have them
reject trivial merge commits (ones that should be fast forwards), and
commits with merge cruft in it ...
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Garrett Cooper]

On Thu, Jan 6, 2011 at 1:30 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
>> A really bad merge (I posted a reply to it a while ago in the archives).
>
> is there a way for us to manage the git hooks ?  we could have them
> reject trivial merge commits (ones that should be fast forwards), and
> commits with merge cruft in it ...

   This was nastier. A lot of the problems I caused was ignorance and
human error based -- in particular I thought that git reset --hard
would actually reset merges (but it didn't!) and I didn't bother to
fake the push before I did it and the rest is history. So I don't know
if adding hooks would fix that, but I think that the tool should reset
merges if I do reset --hard.
    I need to note some of the fun points I've had with git so far
because there are a handful of items with the tool that have really
made my life painful in the past couple of weeks that should be fixed.
Thanks,
-Garrett

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Mike Frysinger]

On Thu, Jan 6, 2011 at 4:38 PM, Garrett Cooper wrote:
> On Thu, Jan 6, 2011 at 1:30 PM, Mike Frysinger wrote:
>> On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
>>> A really bad merge (I posted a reply to it a while ago in the archives).
>>
>> is there a way for us to manage the git hooks ?  we could have them
>> reject trivial merge commits (ones that should be fast forwards), and
>> commits with merge cruft in it ...
>
>   This was nastier. A lot of the problems I caused was ignorance and
> human error based -- in particular I thought that git reset --hard
> would actually reset merges (but it didn't!)

sure it will ... you just have to reset to before the merge

> I didn't bother to fake the push before I did it and the rest is history.

if you caught it soon, you could have pushed up an old one and forced
it back to the sane state ...
git push --force origin <older commit>:refs/head/master

> So I don't know if adding hooks would fix that

i saw that you had actual conflicts in there, and the hook would have
caught that (">>>>>>>>>" and "=========" and such)

but i'm not sure if your non-trivial merge would have been detected as
a trivial merge since we dont want that (it'd prevent people from
being able to pull a branch from someone else)
-mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Garrett Cooper]

On Jan 6, 2011, at 1:46 PM, Mike Frysinger wrote:

> On Thu, Jan 6, 2011 at 4:38 PM, Garrett Cooper wrote:
>> On Thu, Jan 6, 2011 at 1:30 PM, Mike Frysinger wrote:
>>> On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
>>>> A really bad merge (I posted a reply to it a while ago in the archives).
>>> 
>>> is there a way for us to manage the git hooks ?  we could have them
>>> reject trivial merge commits (ones that should be fast forwards), and
>>> commits with merge cruft in it ...
>> 
>>   This was nastier. A lot of the problems I caused was ignorance and
>> human error based -- in particular I thought that git reset --hard
>> would actually reset merges (but it didn't!)
> 
> sure it will ... you just have to reset to before the merge
> 
>> I didn't bother to fake the push before I did it and the rest is history.
> 
> if you caught it soon, you could have pushed up an old one and forced
> it back to the sane state ...
> git push --force origin <older commit>:refs/head/master
> 
>> So I don't know if adding hooks would fix that
> 
> i saw that you had actual conflicts in there, and the hook would have
> caught that (">>>>>>>>>" and "=========" and such)
> 
> but i'm not sure if your non-trivial merge would have been detected as
> a trivial merge since we dont want that (it'd prevent people from
> being able to pull a branch from someone else)

	Ok -- good to note for next time I guess. I fixed all of the compilation errors so now people can report runtime issues. There are a handful of them.
Thanks,
-Garrett


------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Cyril Hrubis]

Hi!
> 
> 	Ok -- good to note for next time I guess. I fixed all of the compilation errors so now people can report runtime issues. There are a handful of them.
>

I still could not compile the latest git. I've got a bunch of:

pipe declared with warn_unused_result
write declared with warn_unused_result
read declared with warn_unused_result

little less of:

getcwd declared with warn_unused_result
chdir declared with warn_unused_result
ftruncate declared with warn_unused_result
system declared with warn_unused_result

plus some printf() formatting issues

And after disabling -Werror it stops on getdelays.c with

getdelays.c: In function 'main':
getdelays.c:525: warning: implicit declaration of function 'tst_exit'
getdelays.c:526: warning: control reaches end of non-void function
getdelays.c:266: warning: 'cmd_type' may be used uninitialized in this
function
../../../../lib/libltp.a(tst_res.o): In function `cat_file':
/home/metan/Work/git/ltp-dev/lib/tst_res.c:710: undefined reference to `TCID'
/home/metan/Work/git/ltp-dev/lib/tst_res.c:728: undefined reference to `TCID'
/home/metan/Work/git/ltp-dev/lib/tst_res.c:720: undefined reference to `TCID'
../../../../lib/libltp.a(tst_res.o): In function `tst_res':
/home/metan/Work/git/ltp-dev/lib/tst_res.c:321: undefined reference to `TCID'
../../../../lib/libltp.a(tst_res.o): In function `tst_condense':
/home/metan/Work/git/ltp-dev/lib/tst_res.c:377: undefined reference to `TCID'
../../../../lib/libltp.a(tst_res.o):/home/metan/Work/git/ltp-dev/lib/tst_res.c:3
05: more undefined references to `TCID' follow
../../../../lib/libltp.a(tst_res.o): In function `tst_brk':
/home/metan/Work/git/ltp-dev/lib/tst_res.c:613: undefined reference to `TST_TOTAL'

The same goes for testcases/kernel/io/ltp-aiodio/dirty.c and
testcases/kernel/security/cap_bound/dummy.c

Then it hangs on securebits but is suppose that this is bug somewhere in
configure not detecting securebits headers right. I'll look into this
later.


The realtime tests hangs on:

async_handler_jk.c: In function 'main':
async_handler_jk.c:162: warning: implicit declaration of function
'tst_exit'
async_handler_jk.c:163: warning: control reaches end of non-void
function
/tmp/ccGU6ubN.o: In function `main':
/home/metan/Work/git/ltp-dev/testcases/realtime/func/async_handler/async_handler_jk.c:162:
undefined reference to `tst_exit'
collect2: ld returned 1 exit status
make[2]: *** [async_handler_jk] Error 1
make[2]: Leaving directory
`/home/metan/Work/git/ltp-dev/testcases/realtime/func/async_handler'
make[1]: *** [all] Error 2
make[1]: Leaving directory
`/home/metan/Work/git/ltp-dev/testcases/realtime/func'
make: *** [all] Error 2


The rest seems to compile fine.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Cyril Hrubis]

Hi!
> > I still could not compile the latest git. I've got a bunch of:
> > 
> > pipe declared with warn_unused_result
> > write declared with warn_unused_result
> > read declared with warn_unused_result
> 
> Now you know why I used void casts in a few spots :). Some are of value, some are fud.

The problem seems to be that in different versions of libc different
calls are marked with warn_unused_result. I'm still thinking if -Werror
is right default for git tree. And I'm almost sure that it's wrong for
releases.

> Ok. It would be nice to have a summary email (off-list) with all of
> these warnings, as they can lead to really bad problems. I may do like
> I've done in some directories as well and add -Wno-error with a
> comment stating why things were done that way.


Will send.

BTW: just now, you are missing SAFE_SETEGID and SAFE_SETEUID implementation
     so compilation stops at fchown04.c

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Cyril Hrubis]

Hi!
> >> > I still could not compile the latest git. I've got a bunch of:
> >> >
> >> > pipe declared with warn_unused_result
> >> > write declared with warn_unused_result
> >> > read declared with warn_unused_result
> >>
> >> Now you know why I used void casts in a few spots :). Some are of value, some are fud.
> >
> > The problem seems to be that in different versions of libc different
> > calls are marked with warn_unused_result. I'm still thinking if -Werror
> > is right default for git tree. And I'm almost sure that it's wrong for
> > releases.
> 
> Agreed, but people need to turn it on before committing test code, so
> that their code doesn't introduce any new warnings.

Well that doesn't catch up warnings if they are compiling, let's say on
ancient rhel distros. Unless somebody checks the code on recent enough
glibc... As far as I remember warn_unused_result is quite recent
feature.

> >> Ok. It would be nice to have a summary email (off-list) with all of
> >> these warnings, as they can lead to really bad problems. I may do like
> >> I've done in some directories as well and add -Wno-error with a
> >> comment stating why things were done that way.
> >
> > Will send.
> 
> Thanks. Subrata sent me a bunch of warnings-related errors so I'll
> need to follow up on them.  Now that tst_brk is reentrant (for better
> or for worse -- I needed to do this so people could use SAFE_CLOSE,
> etc in cleanup functions otherwise the compiler would whine that code
> doesn't return), the compiler isn't smart enough to realize that the
> following will always result in an immediate exit:
>
> int
> main(void)
> {
>     tst_brkm(TCONF, NULL, "gcc is dumb");
> }

Well, that's the whole reason for attribute __noreturn__. The compiler
is not smart enough and it's not easy to make it smarter, without a buch
of matematicians and a lot of work. And as such code leads, usually, to
bug, the gcc folks rather prints the warning. There are even parts of
gcc compiler, that are compiled with warnings disabled...

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 00/13]Fix a few syntax error

[Cyril Hrubis]

Hi!
> > int
> > main(void)
> > {
> >     tst_brkm(TCONF, NULL, "gcc is dumb");
> > }
> 
> Well, that's the whole reason for attribute __noreturn__. The compiler
> is not smart enough and it's not easy to make it smarter, without a buch
> of matematicians and a lot of work. And as such code leads, usually, to
> bug, the gcc folks rather prints the warning. There are even parts of
> gcc compiler, that are compiled with warnings disabled...

Thinking of this again, even a bunch of matematicians wouldn't help
here. As the compiler doesn't have any means to find out, when main is
compiled, how tst_brkm() is actually implemented. That is not possible
before the linker comes into play and in case of dynamic linker, this
warning could be generated only at runtime. That's IMHO the whole reason
for attribute __noreturn__.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list