Re: [LTP] [PATCH 00/13]Fix a few syntax error

Cyril Hrubis
2011-01-10T18:26:54Z

Hi!
> > I still could not compile the latest git. I've got a bunch of:
> >
> > pipe declared with warn_unused_result
> > write declared with warn_unused_result
> > read declared with warn_unused_result
>
> Now you know why I used void casts in a few spots :). Some are of value, some are fud.

The problem seems to be that in different versions of libc different
calls are marked with warn_unused_result. I'm still thinking if -Werror
is right default for git tree. And I'm almost sure that it's wrong for
releases.

> Ok. It would be nice to have a summary email (off-list) with all of
> these warnings, as they can lead to really bad problems. I may do like
> I've done in some directories as well and add -Wno-error with a
> comment stating why things were done that way.

Will send.

BTW: just now, you are missing SAFE_SETEGID and SAFE_SETEUID implementation
so compilation stops at fchown04.c

--
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web. Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.