Re: [LTP] [PATCH 00/13]Fix a few syntax error

Garrett Cooper
2011-01-06T21:05:08Z

On Thu, Jan 6, 2011 at 12:24 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thu, Jan 6, 2011 at 2:35 PM, Garrett Cooper wrote:
>> On Jan 6, 2011, at 10:26 AM, Mike Frysinger wrote:
>>> On Thu, Jan 6, 2011 at 5:49 AM, tangchen wrote:
>>>> There are several small bugs making LTP unable to be built, most of
>>>> which are syntax errors.
>>>>
>>>> 1. Add missing parameters for tst_brkm() in
>>>> testcases/kernel/syscalls/fchmod/fchmod03.c
>>>> 2. Add missing parameters for tst_brkm() in
>>>> testcases/kernel/syscalls/flock/flock04.c
>>>> 3. Add missing ";" in testcases/kernel/syscalls/getpagesize/getpagesize01.c
>>>> 4. Correct the parameters' names for parse_opts() in
>>>> testcases/kernel/syscalls/lchown/lchown02.c
>>>> 5. Add some preprocessor variables in /testcases/kernel/mem/ksm/ksm01.c
>>>> bacause KSM is not supported on RHEL5
>>>> 6. Add missing operators for parse_opts() in
>>>> testcases/kernel/syscalls/msync/msync04.c
>>>> 7. Fix an wrong using of macro WTERMSIG in
>>>> testcases/kernel/syscalls/pipe/pipe04.c
>>>> 8. Fix the wrong variable name of wtstatus in
>>>> testcases/kernel/syscalls/pipe/pipe09.c
>>>> 9. Add a missing ")" in testcases/kernel/syscalls/pread/pread03.c
>>>> 10. Remove a redundant "{" in
>>>> testcases/kernel/syscalls/sched_getparam/sched_getparam02.c
>>>> 11. Fix the wrong using of perror() in
>>>> testcases/kernel/syscalls/sched_setparam/sched_setparam03.c
>>>> 12. Add a missing variable TST_TOTAL in
>>>> testcases/kernel/syscalls/socketpair/socketpair02.c
>>>> 13. Add missing parameters for tst_brkm() in
>>>> testcases/kernel/syscalls/statfs/statfs03.c
>>>
>>> this is weird ... how did all these *compile errors* manage to get
>>> *committed* ??
>>
>> A really bad merge (I posted a reply to it a while ago in the archives).
>
> i guess i read that as "things are fixed now" rather than "there are
> still some latent issues laying about"

306 to be exact still need to be resolved; my previous number was
much lower because I forgot the power of make -k.
I'll post the problem files soon (as a list) and a way for
reproducing the problems so that others can provide patches (maybe),
but [un]fortunately many times I have to go in and fix other items
anyhow, as the process that it goes and executes things sometimes
leaves test directories hanging around. On the bright side I've fixed
about 20-30 or so legitimate test bugs so far.
Thanks,
-Garrett "still making progress, but steady as she goes"