[LTP] [PATCH] Fix a building error.

[LTP] [PATCH] Fix a building error.

[Peng Haitao]

Hi Garrett,

A build error is caught after applied commit bacc849720ec4efda5a0a8a9ea6a0e93a1415541.

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>

---
 testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/testcases/kernel/syscalls/mallopt/mallopt01.c b/testcases/kernel/syscalls/mallopt/mallopt01.c
index d356cb2..26307a6 100644
--- a/testcases/kernel/syscalls/mallopt/mallopt01.c
+++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
@@ -37,6 +37,7 @@
 #ifdef CONFIG_COLDFIRE
 #define __MALLOC_STANDARD__
 #endif
+#include <malloc.h>
 #include <stdlib.h>
 #include <errno.h>
 
-- 
1.7.0.4

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Cyril Hrubis]

Hi!
> A build error is caught after applied commit bacc849720ec4efda5a0a8a9ea6a0e93a1415541.
> 
> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>

You were faster than me ;).

Acked-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 564 bytes --]

On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
>  testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +

please use descriptive subjects in your patches.  this really should be 
something like:
	mallopt01: fix build error due to xxxx

> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
> @@ -37,6 +37,7 @@
>  #ifdef CONFIG_COLDFIRE
>  #define __MALLOC_STANDARD__
>  #endif
> +#include <malloc.h>

umm, no.  malloc.h is a dead header file and nothing should be including it.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 372 bytes --]

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Garrett Cooper]

On Fri, Jan 14, 2011 at 1:24 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
>>  testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +
>
> please use descriptive subjects in your patches.  this really should be
> something like:
>        mallopt01: fix build error due to xxxx
>
>> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
>> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
>> @@ -37,6 +37,7 @@
>>  #ifdef CONFIG_COLDFIRE
>>  #define __MALLOC_STANDARD__
>>  #endif
>> +#include <malloc.h>
>
> umm, no.  malloc.h is a dead header file and nothing should be including it.

    It is exposing extra junk in this case that isn't available from
stdlib.h, which unfortunately the test uses. I fixed the build error
for now, but maybe someone upstream should be informed that this
header needs to die a painful death, because all contemporary
documentation says that you need to include stdlib.h, not malloc.h
when working with malloc(3). I was reminded of this recently because I
built some stuff on FreeBSD and FreeBSD has a nice #warning about this
deprecation.
Thanks,
-Garrett

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 1504 bytes --]

On Friday, January 14, 2011 16:33:38 Garrett Cooper wrote:
> On Fri, Jan 14, 2011 at 1:24 PM, Mike Frysinger wrote:
> > On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
> >>  testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +
> > 
> > please use descriptive subjects in your patches.  this really should be
> > something like:
> >        mallopt01: fix build error due to xxxx
> > 
> >> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
> >> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
> >> @@ -37,6 +37,7 @@
> >>  #ifdef CONFIG_COLDFIRE
> >>  #define __MALLOC_STANDARD__
> >>  #endif
> >> +#include <malloc.h>
> > 
> > umm, no.  malloc.h is a dead header file and nothing should be including
> > it.
> 
>     It is exposing extra junk in this case that isn't available from
> stdlib.h, which unfortunately the test uses. I fixed the build error
> for now, but maybe someone upstream should be informed that this
> header needs to die a painful death, because all contemporary
> documentation says that you need to include stdlib.h, not malloc.h
> when working with malloc(3). I was reminded of this recently because I
> built some stuff on FreeBSD and FreeBSD has a nice #warning about this
> deprecation.

err, right.  we're using mallopt() here and not malloc().  the former is not 
part of POSIX which means it should not be in stdlib.h.  i dont believe it is 
being deprecated on the GNU side, so we dont want to go killing off the tests.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 372 bytes --]

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Garrett Cooper]

On Fri, Jan 14, 2011 at 1:46 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday, January 14, 2011 16:33:38 Garrett Cooper wrote:
>> On Fri, Jan 14, 2011 at 1:24 PM, Mike Frysinger wrote:
>> > On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
>> >>  testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +
>> >
>> > please use descriptive subjects in your patches.  this really should be
>> > something like:
>> >        mallopt01: fix build error due to xxxx
>> >
>> >> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
>> >> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
>> >> @@ -37,6 +37,7 @@
>> >>  #ifdef CONFIG_COLDFIRE
>> >>  #define __MALLOC_STANDARD__
>> >>  #endif
>> >> +#include <malloc.h>
>> >
>> > umm, no.  malloc.h is a dead header file and nothing should be including
>> > it.
>>
>>     It is exposing extra junk in this case that isn't available from
>> stdlib.h, which unfortunately the test uses. I fixed the build error
>> for now, but maybe someone upstream should be informed that this
>> header needs to die a painful death, because all contemporary
>> documentation says that you need to include stdlib.h, not malloc.h
>> when working with malloc(3). I was reminded of this recently because I
>> built some stuff on FreeBSD and FreeBSD has a nice #warning about this
>> deprecation.
>
> err, right.  we're using mallopt() here and not malloc().  the former is not
> part of POSIX which means it should not be in stdlib.h.  i dont believe it is
> being deprecated on the GNU side, so we dont want to go killing off the tests.

Should these tests live with glibc then and not ltp?
Thanks,
-Garrett

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 2124 bytes --]

On Friday, January 14, 2011 16:52:15 Garrett Cooper wrote:
> On Fri, Jan 14, 2011 at 1:46 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Friday, January 14, 2011 16:33:38 Garrett Cooper wrote:
> >> On Fri, Jan 14, 2011 at 1:24 PM, Mike Frysinger wrote:
> >> > On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
> >> >>  testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +
> >> > 
> >> > please use descriptive subjects in your patches.  this really should
> >> > be something like:
> >> >        mallopt01: fix build error due to xxxx
> >> > 
> >> >> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
> >> >> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
> >> >> @@ -37,6 +37,7 @@
> >> >>  #ifdef CONFIG_COLDFIRE
> >> >>  #define __MALLOC_STANDARD__
> >> >>  #endif
> >> >> +#include <malloc.h>
> >> > 
> >> > umm, no.  malloc.h is a dead header file and nothing should be
> >> > including it.
> >> 
> >>     It is exposing extra junk in this case that isn't available from
> >> stdlib.h, which unfortunately the test uses. I fixed the build error
> >> for now, but maybe someone upstream should be informed that this
> >> header needs to die a painful death, because all contemporary
> >> documentation says that you need to include stdlib.h, not malloc.h
> >> when working with malloc(3). I was reminded of this recently because I
> >> built some stuff on FreeBSD and FreeBSD has a nice #warning about this
> >> deprecation.
> > 
> > err, right.  we're using mallopt() here and not malloc().  the former is
> > not part of POSIX which means it should not be in stdlib.h.  i dont
> > believe it is being deprecated on the GNU side, so we dont want to go
> > killing off the tests.
> 
> Should these tests live with glibc then and not ltp?

not really.  you might be able to get glibc to accept these, but you'll most 
likely need to rewrite them considerably.  plus, other C library 
implementations also support mallopt, not just glibc.  while it isnt part of 
POSIX, i do believe it is part of older standards.  glibc seems to quote 
SVID/XPG/ANSI.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 372 bytes --]

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH] Fix a building error.

[Peng Haitao]

Hi Garrett,

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
 pan/scan.l |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/pan/scan.l b/pan/scan.l
index 9696531..cc47bdf 100644
--- a/pan/scan.l
+++ b/pan/scan.l
@@ -91,6 +91,7 @@ static int check_mode(int, int, ...);
 %option noinput
 %option nolex-compat
 %option nounput
+%option yylineno
 
 UI      [0-9]+
 A       [a-zA-Z]+
-- 
1.7.0.4

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Peng Haitao]

Hi Garrett,

  Would you like to apply this patch? 

  "%option nolex-compat" make the global variable "yylineno" undeclared, 
this will result in build error in RHEL4.8 and RHEL5.5.

  The environments are as follows:
  - RHEL4.8 --- x86_64
  - flex    --- version 2.5.4

  - RHEL5.5 --- (x86, x86_64, ia64)
  - flex    --- version 2.5.4


Peng Haitao said the following on 2011-1-14 17:31:
> Hi Garrett,
> 
> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
> ---
>  pan/scan.l |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/pan/scan.l b/pan/scan.l
> index 9696531..cc47bdf 100644
> --- a/pan/scan.l
> +++ b/pan/scan.l
> @@ -91,6 +91,7 @@ static int check_mode(int, int, ...);
>  %option noinput
>  %option nolex-compat
>  %option nounput
> +%option yylineno
>  
>  UI      [0-9]+
>  A       [a-zA-Z]+

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a building error.

[Peng Haitao]

Hi Garrett,

Any response？

The INSTALL file say flex can be obtained here:
- http://downloads.sourceforge.net/project/flex/flex/flex-2.5.33/flex-2.5.33.tar.bz2

Are you mean the flex version is sure flex-2.5.33+？

>   Would you like to apply this patch? 
> 
>   "%option nolex-compat" make the global variable "yylineno" undeclared, 
> this will result in build error in RHEL4.8 and RHEL5.5.
> 
>   The environments are as follows:
>   - RHEL4.8 --- x86_64
>   - flex    --- version 2.5.4
> 
>   - RHEL5.5 --- (x86, x86_64, ia64)
>   - flex    --- version 2.5.4
> 
> 
> Peng Haitao said the following on 2011-1-14 17:31:
>> Hi Garrett,
>>
>> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
>> ---
>>  pan/scan.l |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/pan/scan.l b/pan/scan.l
>> index 9696531..cc47bdf 100644
>> --- a/pan/scan.l
>> +++ b/pan/scan.l
>> @@ -91,6 +91,7 @@ static int check_mode(int, int, ...);
>>  %option noinput
>>  %option nolex-compat
>>  %option nounput
>> +%option yylineno
>>  
>>  UI      [0-9]+
>>  A       [a-zA-Z]+
> 

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list