[LTP] Review Required: [Re: [PATCH] fix mail02, 03 fail due to different sender names]

[Caspar Zhang <czhang@redhat.com>]

Sorry for bothering, any comments on this patch?

On 01/29/2011 01:41 AM, Caspar Zhang wrote:
> Hi all, mail02 and mail03 tests non-existed host and non-existed
> username in the test. However in some systems (at least in RHEL6),
> they both fails because of the sender name of the returned letter is
> "Mail Delivery System" instead of "Mail Delivery Subsys", which makes RC1
> to be zero and fail the test. The patch fixes this issue.
> 
> Signed-off-by: Caspar Zhang <czhang@redhat.com>
> ---
>  testcases/commands/mail/mail_tests.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/commands/mail/mail_tests.sh
> b/testcases/commands/mail/mail_tests.sh
> index 53a5d90..c30e2c3 100755
> --- a/testcases/commands/mail/mail_tests.sh
> +++ b/testcases/commands/mail/mail_tests.sh
> @@ -169,7 +169,7 @@ else
>  		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3, "Mailer-Daemon")}' \
>  		    $LTPTMP/tst_mail.res)
>  	else
> -		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
> "MailDeliverySubsys")}' \
> +		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
> "MailDelivery(Subsys|System)")}' \
>  		    $LTPTMP/tst_mail.res)
>  	fi
> 
> @@ -250,7 +250,7 @@ else
>  		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3, "Mailer-Daemon")}' \
>  		    $LTPTMP/tst_mail.res)
>  	else
> -		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
> "MailDeliverySubsys")}' \
> +		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
> "MailDelivery(Subsys|System)")}' \
>  		    $LTPTMP/tst_mail.res)
>  	fi
>  	##################################################################


-- 
Quality Assurance Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch

TEL: +86-10-62608150
WEB: http://www.redhat.com/
--
C-A-S-P-A-R, Caspar /kæspɑ:/ ;-)

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list