Re: [LTP] Review Required: [Re: [PATCH] fix mail02, 03 fail due to different sender names]

[Shubham Goyal <shubham@linux.vnet.ibm.com>]

Hi Caspar,

I reviewed/verified your patch and it seems to be working fine. I verified it on RHEL6 and both mail02 and mail03 tests are passing now. I believe it can be merged upstream.
Garrett, Any comments?

Thanks,
Shubham


On Monday 14 February 2011 01:13 PM, Caspar Zhang wrote:

> Sorry for bothering, any comments on this patch?
>
> On 01/29/2011 01:41 AM, Caspar Zhang wrote:
>> Hi all, mail02 and mail03 tests non-existed host and non-existed
>> username in the test. However in some systems (at least in RHEL6),
>> they both fails because of the sender name of the returned letter is
>> "Mail Delivery System" instead of "Mail Delivery Subsys", which makes RC1
>> to be zero and fail the test. The patch fixes this issue.
>>
>> Signed-off-by: Caspar Zhang<czhang@redhat.com>
>> ---
>>   testcases/commands/mail/mail_tests.sh |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/commands/mail/mail_tests.sh
>> b/testcases/commands/mail/mail_tests.sh
>> index 53a5d90..c30e2c3 100755
>> --- a/testcases/commands/mail/mail_tests.sh
>> +++ b/testcases/commands/mail/mail_tests.sh
>> @@ -169,7 +169,7 @@ else
>>   		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3, "Mailer-Daemon")}' \
>>   		    $LTPTMP/tst_mail.res)
>>   	else
>> -		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
>> "MailDeliverySubsys")}' \
>> +		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
>> "MailDelivery(Subsys|System)")}' \
>>   		    $LTPTMP/tst_mail.res)
>>   	fi
>>
>> @@ -250,7 +250,7 @@ else
>>   		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3, "Mailer-Daemon")}' \
>>   		    $LTPTMP/tst_mail.res)
>>   	else
>> -		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
>> "MailDeliverySubsys")}' \
>> +		RC1=$(awk '/^>N/ {IGNORECASE=1; print match($3 $4 $5,
>> "MailDelivery(Subsys|System)")}' \
>>   		    $LTPTMP/tst_mail.res)
>>   	fi
>>   	##################################################################
>


------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list