From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.74) (envelope-from ) id 1PsUWN-0004MN-6r for ltp-list@lists.sourceforge.net; Thu, 24 Feb 2011 06:17:51 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.74) id 1PsUWL-0006XO-Oq for ltp-list@lists.sourceforge.net; Thu, 24 Feb 2011 06:17:51 +0000 Message-ID: <4D65F817.2020904@cn.fujitsu.com> Date: Thu, 24 Feb 2011 14:17:59 +0800 From: Peng Haitao MIME-Version: 1.0 Subject: [LTP] [PATCH] syslogtst.c: fix a bug of assert() is used wrong List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: ltp-list@lists.sourceforge.net Hi Garrett, When executing "./syslogtst 1", the error message is follows: syslogtst: syslogtst.c:93: main: Assertion `ch1 != -1' failed. Signed-off-by: Peng Haitao --- testcases/kernel/syscalls/syslog/syslogtst.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/testcases/kernel/syscalls/syslog/syslogtst.c b/testcases/kernel/syscalls/syslog/syslogtst.c index a229688..11a97fd 100644 --- a/testcases/kernel/syscalls/syslog/syslogtst.c +++ b/testcases/kernel/syscalls/syslog/syslogtst.c @@ -90,8 +90,6 @@ int main(int argc, char *argv[]) ch1 = atoi(argv[2]); } - assert (ch1 != -1); - /* * Send syslog messages according to the case number, which * we will know from command line. @@ -101,6 +99,8 @@ int main(int argc, char *argv[]) syslog(LOG_MAIL | LOG_INFO, "syslogtst: mail info test."); break; case 2: + assert (ch1 != -1); + switch (ch1) { case 0: syslog(LOG_MAIL | LOG_EMERG, @@ -254,6 +254,8 @@ int main(int argc, char *argv[]) syslog(LOG_USER | LOG_DEBUG, "syslogtst: debug log"); break; case 8: + assert (ch1 != -1); + switch (ch1) { /* * Kernel messages cannot be send by user, so skipping the @@ -343,4 +345,4 @@ void sig_handler(int signal) } exit(signal); -} \ No newline at end of file +} -- 1.7.1 -- Best Regards, Peng Haitao ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list