* [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
@ 2011-02-24 10:08 Peng Haitao
2011-02-24 16:46 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Peng Haitao @ 2011-02-24 10:08 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
Hi Garrett,
There are two processes in cases, and the test need run from child process,
so parent process should exit after invoking cleanup().
Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
testcases/kernel/syscalls/waitpid/waitpid11.c | 1 +
testcases/kernel/syscalls/waitpid/waitpid12.c | 1 +
testcases/kernel/syscalls/waitpid/waitpid13.c | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/testcases/kernel/syscalls/waitpid/waitpid11.c b/testcases/kernel/syscalls/waitpid/waitpid11.c
index 1e631da..d61b624 100644
--- a/testcases/kernel/syscalls/waitpid/waitpid11.c
+++ b/testcases/kernel/syscalls/waitpid/waitpid11.c
@@ -112,6 +112,7 @@ int main(int ac, char **av)
tst_resm(TPASS, "%s PASSED", TCID);
}
cleanup();
+ tst_exit();
} else if (pid < 0) {
tst_brkm(TBROK, cleanup, "fork failed");
}
diff --git a/testcases/kernel/syscalls/waitpid/waitpid12.c b/testcases/kernel/syscalls/waitpid/waitpid12.c
index 5c0ebe6..ac99c9a 100644
--- a/testcases/kernel/syscalls/waitpid/waitpid12.c
+++ b/testcases/kernel/syscalls/waitpid/waitpid12.c
@@ -113,6 +113,7 @@ int main(int argc, char **argv)
tst_resm(TPASS, "%s PASSED", TCID);
}
cleanup();
+ tst_exit();
} else if (pid < 0) {
tst_brkm(TBROK, cleanup, "fork failed");
}
diff --git a/testcases/kernel/syscalls/waitpid/waitpid13.c b/testcases/kernel/syscalls/waitpid/waitpid13.c
index 8b908a9..7f7393e 100644
--- a/testcases/kernel/syscalls/waitpid/waitpid13.c
+++ b/testcases/kernel/syscalls/waitpid/waitpid13.c
@@ -110,6 +110,7 @@ int main(int ac, char **av)
tst_resm(TPASS, "%s PASSED", TCID);
}
cleanup();
+ tst_exit();
} else if (pid < 0) {
tst_brkm(TBROK, cleanup, "fork failed");
}
--
1.7.1
--
Best Regards,
Peng Haitao
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
2011-02-24 10:08 [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c Peng Haitao
@ 2011-02-24 16:46 ` Garrett Cooper
2011-02-28 1:06 ` Peng Haitao
0 siblings, 1 reply; 7+ messages in thread
From: Garrett Cooper @ 2011-02-24 16:46 UTC (permalink / raw)
To: Peng Haitao; +Cc: ltp-list
On Thu, Feb 24, 2011 at 2:08 AM, Peng Haitao <penght@cn.fujitsu.com> wrote:
> Hi Garrett,
>
> There are two processes in cases, and the test need run from child process,
> so parent process should exit after invoking cleanup().
Looks fine. I'll commit it tonight if no one else beats me to it.
Thanks,
-Garrett
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
2011-02-24 16:46 ` Garrett Cooper
@ 2011-02-28 1:06 ` Peng Haitao
2011-03-04 10:13 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Peng Haitao @ 2011-02-28 1:06 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
Garrett Cooper said the following on 2011-2-25 0:46:
>> There are two processes in cases, and the test need run from child process,
>> so parent process should exit after invoking cleanup().
>
> Looks fine. I'll commit it tonight if no one else beats me to it.
> Thanks,
Garrett,
Would you commit the patch?
Thanks,
--
Best Regards,
Peng Haitao
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
2011-02-28 1:06 ` Peng Haitao
@ 2011-03-04 10:13 ` Garrett Cooper
2011-03-04 15:59 ` Caspar Zhang
2011-03-09 5:22 ` Peng Haitao
0 siblings, 2 replies; 7+ messages in thread
From: Garrett Cooper @ 2011-03-04 10:13 UTC (permalink / raw)
To: Peng Haitao; +Cc: ltp-list
On Sun, Feb 27, 2011 at 5:06 PM, Peng Haitao <penght@cn.fujitsu.com> wrote:
> Garrett Cooper said the following on 2011-2-25 0:46:
>>> There are two processes in cases, and the test need run from child process,
>>> so parent process should exit after invoking cleanup().
>>
>> Looks fine. I'll commit it tonight if no one else beats me to it.
>> Thanks,
>
> Garrett,
>
> Would you commit the patch?
I've committed a more extensive patch. Please test it out and let me
know how it goes -- thanks!
-Garrett
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
2011-03-04 10:13 ` Garrett Cooper
@ 2011-03-04 15:59 ` Caspar Zhang
2011-03-04 16:17 ` Garrett Cooper
2011-03-09 5:22 ` Peng Haitao
1 sibling, 1 reply; 7+ messages in thread
From: Caspar Zhang @ 2011-03-04 15:59 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
On 03/04/2011 06:13 PM, Garrett Cooper wrote:
> I've committed a more extensive patch. Please test it out and let me
> know how it goes -- thanks!
> -Garrett
Hi Garrett, compile error occurs in this patch, here is a fix.
--
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150
[-- Attachment #2: 0001-syscalls-waitpid11-fix-compile-err.patch --]
[-- Type: text/plain, Size: 867 bytes --]
From c52a6798caa5dd673eea50b9a41686713e6c1303 Mon Sep 17 00:00:00 2001
From: Caspar Zhang <czhang@redhat.com>
Date: Fri, 4 Mar 2011 23:57:39 +0800
Subject: [PATCH] syscalls: waitpid11: fix compile err
Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
testcases/kernel/syscalls/waitpid/waitpid11.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/testcases/kernel/syscalls/waitpid/waitpid11.c b/testcases/kernel/syscalls/waitpid/waitpid11.c
index 45d828c..368e984 100644
--- a/testcases/kernel/syscalls/waitpid/waitpid11.c
+++ b/testcases/kernel/syscalls/waitpid/waitpid11.c
@@ -283,7 +283,7 @@ int main(int ac, char **av)
void setup_sigint(void)
{
if (signal(SIGINT, inthandlr) == SIG_ERR)
- tst_brkm(TFAIL|TERRNO, "signal SIGINT failed");
+ tst_brkm(TFAIL|TERRNO, NULL, "signal SIGINT failed");
}
void setup(void)
--
1.7.4.1
[-- Attachment #3: Type: text/plain, Size: 309 bytes --]
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
2011-03-04 15:59 ` Caspar Zhang
@ 2011-03-04 16:17 ` Garrett Cooper
0 siblings, 0 replies; 7+ messages in thread
From: Garrett Cooper @ 2011-03-04 16:17 UTC (permalink / raw)
To: Caspar Zhang; +Cc: ltp-list
On Fri, Mar 4, 2011 at 7:59 AM, Caspar Zhang <czhang@redhat.com> wrote:
> On 03/04/2011 06:13 PM, Garrett Cooper wrote:
>> I've committed a more extensive patch. Please test it out and let me
>> know how it goes -- thanks!
>> -Garrett
>
> Hi Garrett, compile error occurs in this patch, here is a fix.
Sorry for the error -- thanks.
-Garrett
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c
2011-03-04 10:13 ` Garrett Cooper
2011-03-04 15:59 ` Caspar Zhang
@ 2011-03-09 5:22 ` Peng Haitao
1 sibling, 0 replies; 7+ messages in thread
From: Peng Haitao @ 2011-03-09 5:22 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
Hi Garrett,
Garrett Cooper said the following on 2011-3-4 18:13:
>> Would you commit the patch?
>
> I've committed a more extensive patch. Please test it out and let me
> know how it goes -- thanks!
The patch is OK, thanks for you work.
Best Regards,
Peng
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-03-09 5:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-24 10:08 [LTP] [PATCH] The parent process need exit of waitpid11.c, waitpid12.c, waitpid13.c Peng Haitao
2011-02-24 16:46 ` Garrett Cooper
2011-02-28 1:06 ` Peng Haitao
2011-03-04 10:13 ` Garrett Cooper
2011-03-04 15:59 ` Caspar Zhang
2011-03-04 16:17 ` Garrett Cooper
2011-03-09 5:22 ` Peng Haitao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox