public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Caspar Zhang <czhang@redhat.com>
To: LTP list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()
Date: Fri, 04 Mar 2011 01:51:20 +0800	[thread overview]
Message-ID: <4D6FD518.1040503@redhat.com> (raw)
In-Reply-To: <4D6FD1D5.30209@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

Similar to getdents0[34] and getdents0[234]_64, so I updated the patch
to v2.

These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents03.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents04.c |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..2503712 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -74,7 +74,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -208,4 +208,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c
b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..1fd9dc0 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -77,7 +77,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -217,4 +217,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c
b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..c858cf2 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -78,7 +78,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -244,4 +244,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


[-- Attachment #2: syscalls-getdents0-234-add-tst_exit.patch --]
[-- Type: text/plain, Size: 2070 bytes --]

These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents03.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents04.c |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..2503712 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -74,7 +74,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -208,4 +208,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..1fd9dc0 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -77,7 +77,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -217,4 +217,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..c858cf2 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -78,7 +78,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -244,4 +244,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 429 bytes --]

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2011-03-03 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 17:37 [LTP] [PATCH] syscalls: getdents02: add tst_exit() Caspar Zhang
2011-03-03 17:51 ` Caspar Zhang [this message]
2011-03-04  8:37   ` [LTP] [PATCH v2] syscalls: getdents0[234]: " Cristian Greco
2011-03-04  8:52     ` Caspar Zhang
2011-03-04  9:27       ` Garrett Cooper
2011-03-04  9:31         ` Caspar Zhang
2011-03-04 10:14           ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6FD518.1040503@redhat.com \
    --to=czhang@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox