From: Caspar Zhang <czhang@redhat.com>
To: Cristian Greco <cristian@regolo.cc>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()
Date: Fri, 04 Mar 2011 16:52:59 +0800 [thread overview]
Message-ID: <4D70A86B.3000800@redhat.com> (raw)
In-Reply-To: <20110304093711.7c022f74@regolo>
[-- Attachment #1: Type: text/plain, Size: 2881 bytes --]
On 03/04/2011 04:37 PM, Cristian Greco wrote:
> wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
> for the sake of consistency?
Agree. Updated to v3:
These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.
v3: modify TINFO to TCONF
Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
testcases/kernel/syscalls/getdents/getdents02.c | 6 +++---
testcases/kernel/syscalls/getdents/getdents03.c | 6 +++---
testcases/kernel/syscalls/getdents/getdents04.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..ed73b42 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -72,9 +72,9 @@ int exp_enos[] = { EBADF, 0 }; /* 0 terminated list of
expected errnos */
#ifndef __i386__
int main()
{
- tst_resm(TINFO, "This test includes x86 asm and will not work on "
+ tst_resm(TCONF, "This test includes x86 asm and will not work on "
"this machine");
-
+ tst_exit();
}
#else
@@ -208,4 +208,4 @@ void cleanup(void)
}
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c
b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..d4b3b66 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -75,9 +75,9 @@ int exp_enos[] = { EINVAL, 0 }; /* 0 terminated list
of expected errnos */
#ifndef __i386__
int main()
{
- tst_resm(TINFO, "This test includes x86 asm and will not work on "
+ tst_resm(TCONF, "This test includes x86 asm and will not work on "
"this machine");
-
+ tst_exit();
}
#else
@@ -217,4 +217,4 @@ void cleanup(void)
}
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c
b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..6c6faff 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -76,9 +76,9 @@ int exp_enos[] = { ENOTDIR, 0 }; /* 0 terminated list
of expected errnos */
#ifndef __i386__
int main()
{
- tst_resm(TINFO, "This test includes x86 asm and will not work on "
+ tst_resm(TCONF, "This test includes x86 asm and will not work on "
"this machine");
-
+ tst_exit();
}
#else
@@ -244,4 +244,4 @@ void cleanup(void)
}
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
--
1.7.4.1
--
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150
[-- Attachment #2: 0001-syscalls-getdents0-234-add-tst_exit.patch --]
[-- Type: text/plain, Size: 2798 bytes --]
From 1899484a13d6a40eb5f8e845bf94cd4d2bb7b712 Mon Sep 17 00:00:00 2001
From: Caspar Zhang <czhang@redhat.com>
Date: Fri, 4 Mar 2011 16:49:01 +0800
Subject: [PATCH] syscalls: getdents0[234]: add tst_exit()
These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.
v3: modify TINFO to TCONF
Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
testcases/kernel/syscalls/getdents/getdents02.c | 6 +++---
testcases/kernel/syscalls/getdents/getdents03.c | 6 +++---
testcases/kernel/syscalls/getdents/getdents04.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..ed73b42 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -72,9 +72,9 @@ int exp_enos[] = { EBADF, 0 }; /* 0 terminated list of expected errnos */
#ifndef __i386__
int main()
{
- tst_resm(TINFO, "This test includes x86 asm and will not work on "
+ tst_resm(TCONF, "This test includes x86 asm and will not work on "
"this machine");
-
+ tst_exit();
}
#else
@@ -208,4 +208,4 @@ void cleanup(void)
}
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..d4b3b66 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -75,9 +75,9 @@ int exp_enos[] = { EINVAL, 0 }; /* 0 terminated list of expected errnos */
#ifndef __i386__
int main()
{
- tst_resm(TINFO, "This test includes x86 asm and will not work on "
+ tst_resm(TCONF, "This test includes x86 asm and will not work on "
"this machine");
-
+ tst_exit();
}
#else
@@ -217,4 +217,4 @@ void cleanup(void)
}
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..6c6faff 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -76,9 +76,9 @@ int exp_enos[] = { ENOTDIR, 0 }; /* 0 terminated list of expected errnos */
#ifndef __i386__
int main()
{
- tst_resm(TINFO, "This test includes x86 asm and will not work on "
+ tst_resm(TCONF, "This test includes x86 asm and will not work on "
"this machine");
-
+ tst_exit();
}
#else
@@ -244,4 +244,4 @@ void cleanup(void)
}
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
--
1.7.4.1
[-- Attachment #3: Type: text/plain, Size: 309 bytes --]
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-03-04 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 17:37 [LTP] [PATCH] syscalls: getdents02: add tst_exit() Caspar Zhang
2011-03-03 17:51 ` [LTP] [PATCH v2] syscalls: getdents0[234]: " Caspar Zhang
2011-03-04 8:37 ` Cristian Greco
2011-03-04 8:52 ` Caspar Zhang [this message]
2011-03-04 9:27 ` Garrett Cooper
2011-03-04 9:31 ` Caspar Zhang
2011-03-04 10:14 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D70A86B.3000800@redhat.com \
--to=czhang@redhat.com \
--cc=cristian@regolo.cc \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox