On 03/04/2011 04:37 PM, Cristian Greco wrote: > wouldn't it be better to call tst_resm() with TCONF instead of TINFO, > for the sake of consistency? Agree. Updated to v3: These tests contain x86 asm so that they wouldn't be run on x86_64 machine, but run into a simple main() functions instead. However all of them are missing tst_exit() which could result in a exit_code=10 failure. v3: modify TINFO to TCONF Signed-off-by: Caspar Zhang --- testcases/kernel/syscalls/getdents/getdents02.c | 6 +++--- testcases/kernel/syscalls/getdents/getdents03.c | 6 +++--- testcases/kernel/syscalls/getdents/getdents04.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c index 4daae05..ed73b42 100644 --- a/testcases/kernel/syscalls/getdents/getdents02.c +++ b/testcases/kernel/syscalls/getdents/getdents02.c @@ -72,9 +72,9 @@ int exp_enos[] = { EBADF, 0 }; /* 0 terminated list of expected errnos */ #ifndef __i386__ int main() { - tst_resm(TINFO, "This test includes x86 asm and will not work on " + tst_resm(TCONF, "This test includes x86 asm and will not work on " "this machine"); - + tst_exit(); } #else @@ -208,4 +208,4 @@ void cleanup(void) } -#endif /* __i386__ */ \ No newline at end of file +#endif /* __i386__ */ diff --git a/testcases/kernel/syscalls/getdents/getdents03.c b/testcases/kernel/syscalls/getdents/getdents03.c index 95ec278..d4b3b66 100644 --- a/testcases/kernel/syscalls/getdents/getdents03.c +++ b/testcases/kernel/syscalls/getdents/getdents03.c @@ -75,9 +75,9 @@ int exp_enos[] = { EINVAL, 0 }; /* 0 terminated list of expected errnos */ #ifndef __i386__ int main() { - tst_resm(TINFO, "This test includes x86 asm and will not work on " + tst_resm(TCONF, "This test includes x86 asm and will not work on " "this machine"); - + tst_exit(); } #else @@ -217,4 +217,4 @@ void cleanup(void) } -#endif /* __i386__ */ \ No newline at end of file +#endif /* __i386__ */ diff --git a/testcases/kernel/syscalls/getdents/getdents04.c b/testcases/kernel/syscalls/getdents/getdents04.c index 88c8e04..6c6faff 100644 --- a/testcases/kernel/syscalls/getdents/getdents04.c +++ b/testcases/kernel/syscalls/getdents/getdents04.c @@ -76,9 +76,9 @@ int exp_enos[] = { ENOTDIR, 0 }; /* 0 terminated list of expected errnos */ #ifndef __i386__ int main() { - tst_resm(TINFO, "This test includes x86 asm and will not work on " + tst_resm(TCONF, "This test includes x86 asm and will not work on " "this machine"); - + tst_exit(); } #else @@ -244,4 +244,4 @@ void cleanup(void) } -#endif /* __i386__ */ \ No newline at end of file +#endif /* __i386__ */ -- 1.7.4.1 -- Quality Engineer (Kernel) in Red Hat Software (Beijing) Co., R&D Branch http://www.cn.redhat.com/ TEL: +86-10-62608150