[LTP] [PATCH] syscalls: getdents02: add tst_exit()

[LTP] [PATCH] syscalls: getdents02: add tst_exit()

[Caspar Zhang]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

This test contains x86 asm so that it wouldn't be run on x86_64 machine,
but run into a simple main() functions instead. However it forgets to
give a return value, so that the program will exit with exit_code=10.
added tst_exit() to solve this issue.

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..2503712 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -74,7 +74,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -208,4 +208,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


-- 
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150

[-- Attachment #2: 0003-syscalls-getdents02-add-tst_exit.patch --]
[-- Type: text/plain, Size: 950 bytes --]

This test contains x86 asm so that it wouldn't be run on x86_64 machine,
but run into a simple main() functions instead. However it forgets to 
give a return value, so that the program will exit with exit_code=10. 
added tst_exit() to solve this issue.

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..2503712 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -74,7 +74,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -208,4 +208,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 429 bytes --]

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Caspar Zhang]

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

Similar to getdents0[34] and getdents0[234]_64, so I updated the patch
to v2.

These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents03.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents04.c |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..2503712 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -74,7 +74,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -208,4 +208,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c
b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..1fd9dc0 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -77,7 +77,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -217,4 +217,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c
b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..c858cf2 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -78,7 +78,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -244,4 +244,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


[-- Attachment #2: syscalls-getdents0-234-add-tst_exit.patch --]
[-- Type: text/plain, Size: 2070 bytes --]

These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents03.c |    4 ++--
 testcases/kernel/syscalls/getdents/getdents04.c |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..2503712 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -74,7 +74,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -208,4 +208,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..1fd9dc0 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -77,7 +77,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -217,4 +217,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..c858cf2 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -78,7 +78,7 @@ int main()
 {
 	tst_resm(TINFO, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -244,4 +244,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 429 bytes --]

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Cristian Greco]

[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]

On Fri, 04 Mar 2011 01:51:20 +0800
Caspar Zhang <czhang@redhat.com> wrote:

> Similar to getdents0[34] and getdents0[234]_64, so I updated the patch
> to v2.
> 
> These tests contain x86 asm so that they wouldn't be run on x86_64
> machine, but run into a simple main() functions instead. However all of
> them are missing tst_exit() which could result in a exit_code=10
> failure.
> 
> Signed-off-by: Caspar Zhang <czhang@redhat.com>
> ---
>  testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
>  testcases/kernel/syscalls/getdents/getdents03.c |    4 ++--
>  testcases/kernel/syscalls/getdents/getdents04.c |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
> b/testcases/kernel/syscalls/getdents/getdents02.c
> index 4daae05..2503712 100644
> --- a/testcases/kernel/syscalls/getdents/getdents02.c
> +++ b/testcases/kernel/syscalls/getdents/getdents02.c
> @@ -74,7 +74,7 @@ int main()
>  {
>  	tst_resm(TINFO, "This test includes x86 asm and will not work on "
>  		 "this machine");

Hi Caspar,

wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
for the sake of consistency?

Thanks,
--
Cristian Greco
GPG key ID: 0xCF4D32E4

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 309 bytes --]

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Caspar Zhang]

[-- Attachment #1: Type: text/plain, Size: 2881 bytes --]

On 03/04/2011 04:37 PM, Cristian Greco wrote:
> wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
> for the sake of consistency?

Agree. Updated to v3:

These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.

v3: modify TINFO to TCONF

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    6 +++---
 testcases/kernel/syscalls/getdents/getdents03.c |    6 +++---
 testcases/kernel/syscalls/getdents/getdents04.c |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..ed73b42 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -72,9 +72,9 @@ int exp_enos[] = { EBADF, 0 };	/* 0 terminated list of
expected errnos */
 #ifndef __i386__
 int main()
 {
-	tst_resm(TINFO, "This test includes x86 asm and will not work on "
+	tst_resm(TCONF, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -208,4 +208,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c
b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..d4b3b66 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -75,9 +75,9 @@ int exp_enos[] = { EINVAL, 0 };	/* 0 terminated list
of expected errnos */
 #ifndef __i386__
 int main()
 {
-	tst_resm(TINFO, "This test includes x86 asm and will not work on "
+	tst_resm(TCONF, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -217,4 +217,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c
b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..6c6faff 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -76,9 +76,9 @@ int exp_enos[] = { ENOTDIR, 0 };	/* 0 terminated list
of expected errnos */
 #ifndef __i386__
 int main()
 {
-	tst_resm(TINFO, "This test includes x86 asm and will not work on "
+	tst_resm(TCONF, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else

@@ -244,4 +244,4 @@ void cleanup(void)

 }

-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1



-- 
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150

[-- Attachment #2: 0001-syscalls-getdents0-234-add-tst_exit.patch --]
[-- Type: text/plain, Size: 2798 bytes --]

From 1899484a13d6a40eb5f8e845bf94cd4d2bb7b712 Mon Sep 17 00:00:00 2001
From: Caspar Zhang <czhang@redhat.com>
Date: Fri, 4 Mar 2011 16:49:01 +0800
Subject: [PATCH] syscalls: getdents0[234]: add tst_exit()

These tests contain x86 asm so that they wouldn't be run on x86_64
machine, but run into a simple main() functions instead. However all of
them are missing tst_exit() which could result in a exit_code=10
failure.

v3: modify TINFO to TCONF

Signed-off-by: Caspar Zhang <czhang@redhat.com>
---
 testcases/kernel/syscalls/getdents/getdents02.c |    6 +++---
 testcases/kernel/syscalls/getdents/getdents03.c |    6 +++---
 testcases/kernel/syscalls/getdents/getdents04.c |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c
index 4daae05..ed73b42 100644
--- a/testcases/kernel/syscalls/getdents/getdents02.c
+++ b/testcases/kernel/syscalls/getdents/getdents02.c
@@ -72,9 +72,9 @@ int exp_enos[] = { EBADF, 0 };	/* 0 terminated list of expected errnos */
 #ifndef __i386__
 int main()
 {
-	tst_resm(TINFO, "This test includes x86 asm and will not work on "
+	tst_resm(TCONF, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -208,4 +208,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents03.c b/testcases/kernel/syscalls/getdents/getdents03.c
index 95ec278..d4b3b66 100644
--- a/testcases/kernel/syscalls/getdents/getdents03.c
+++ b/testcases/kernel/syscalls/getdents/getdents03.c
@@ -75,9 +75,9 @@ int exp_enos[] = { EINVAL, 0 };	/* 0 terminated list of expected errnos */
 #ifndef __i386__
 int main()
 {
-	tst_resm(TINFO, "This test includes x86 asm and will not work on "
+	tst_resm(TCONF, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -217,4 +217,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
diff --git a/testcases/kernel/syscalls/getdents/getdents04.c b/testcases/kernel/syscalls/getdents/getdents04.c
index 88c8e04..6c6faff 100644
--- a/testcases/kernel/syscalls/getdents/getdents04.c
+++ b/testcases/kernel/syscalls/getdents/getdents04.c
@@ -76,9 +76,9 @@ int exp_enos[] = { ENOTDIR, 0 };	/* 0 terminated list of expected errnos */
 #ifndef __i386__
 int main()
 {
-	tst_resm(TINFO, "This test includes x86 asm and will not work on "
+	tst_resm(TCONF, "This test includes x86 asm and will not work on "
 		 "this machine");
-
+	tst_exit();
 }
 #else
 
@@ -244,4 +244,4 @@ void cleanup(void)
 
 }
 
-#endif /* __i386__ */
\ No newline at end of file
+#endif /* __i386__ */
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 309 bytes --]

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Garrett Cooper]

On Fri, Mar 4, 2011 at 12:52 AM, Caspar Zhang <czhang@redhat.com> wrote:
> On 03/04/2011 04:37 PM, Cristian Greco wrote:
>> wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
>> for the sake of consistency?
>
> Agree. Updated to v3:
>
> These tests contain x86 asm so that they wouldn't be run on x86_64
> machine, but run into a simple main() functions instead. However all of
> them are missing tst_exit() which could result in a exit_code=10
> failure.

Fixing it with equivalent:

tst_brkm(TBROK, NULL, ...);

Thanks,
-Garrett

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Caspar Zhang]

On 03/04/2011 05:27 PM, Garrett Cooper wrote:
> On Fri, Mar 4, 2011 at 12:52 AM, Caspar Zhang <czhang@redhat.com> wrote:
>> On 03/04/2011 04:37 PM, Cristian Greco wrote:
>>> wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
>>> for the sake of consistency?
>>
>> Agree. Updated to v3:
>>
>> These tests contain x86 asm so that they wouldn't be run on x86_64
>> machine, but run into a simple main() functions instead. However all of
>> them are missing tst_exit() which could result in a exit_code=10
>> failure.
> 
> Fixing it with equivalent:
> 
> tst_brkm(TBROK, NULL, ...);

TBROK returns a non-zero value, which may result in a FAIL in log...

Caspar
> 
> Thanks,
> -Garrett


-- 
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Garrett Cooper]

On Fri, Mar 4, 2011 at 1:31 AM, Caspar Zhang <czhang@redhat.com> wrote:
> On 03/04/2011 05:27 PM, Garrett Cooper wrote:
>> On Fri, Mar 4, 2011 at 12:52 AM, Caspar Zhang <czhang@redhat.com> wrote:
>>> On 03/04/2011 04:37 PM, Cristian Greco wrote:
>>>> wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
>>>> for the sake of consistency?
>>>
>>> Agree. Updated to v3:
>>>
>>> These tests contain x86 asm so that they wouldn't be run on x86_64
>>> machine, but run into a simple main() functions instead. However all of
>>> them are missing tst_exit() which could result in a exit_code=10
>>> failure.
>>
>> Fixing it with equivalent:
>>
>> tst_brkm(TBROK, NULL, ...);
>
> TBROK returns a non-zero value, which may result in a FAIL in log...

Sorry... meant TCONF.
Thanks,
-Garrett

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list