From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.74) (envelope-from ) id 1PvRMc-00005P-Hf for ltp-list@lists.sourceforge.net; Fri, 04 Mar 2011 09:31:58 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.74) id 1PvRMb-0008Kn-Gj for ltp-list@lists.sourceforge.net; Fri, 04 Mar 2011 09:31:58 +0000 Message-ID: <4D70B17C.6010202@redhat.com> Date: Fri, 04 Mar 2011 17:31:40 +0800 From: Caspar Zhang MIME-Version: 1.0 References: <4D6FD1D5.30209@redhat.com> <4D6FD518.1040503@redhat.com> <20110304093711.7c022f74@regolo> <4D70A86B.3000800@redhat.com> In-Reply-To: Subject: Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit() List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: ltp-list@lists.sourceforge.net On 03/04/2011 05:27 PM, Garrett Cooper wrote: > On Fri, Mar 4, 2011 at 12:52 AM, Caspar Zhang wrote: >> On 03/04/2011 04:37 PM, Cristian Greco wrote: >>> wouldn't it be better to call tst_resm() with TCONF instead of TINFO, >>> for the sake of consistency? >> >> Agree. Updated to v3: >> >> These tests contain x86 asm so that they wouldn't be run on x86_64 >> machine, but run into a simple main() functions instead. However all of >> them are missing tst_exit() which could result in a exit_code=10 >> failure. > > Fixing it with equivalent: > > tst_brkm(TBROK, NULL, ...); TBROK returns a non-zero value, which may result in a FAIL in log... Caspar > > Thanks, > -Garrett -- Quality Engineer (Kernel) in Red Hat Software (Beijing) Co., R&D Branch http://www.cn.redhat.com/ TEL: +86-10-62608150 ------------------------------------------------------------------------------ What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list