From: Peng Haitao <penght@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: [LTP] [ltp] [PATCH] shmctl01.c: fix error of the case need sighandler()
Date: Sat, 12 Mar 2011 17:00:00 +0800 [thread overview]
Message-ID: <4D7B3610.2000905@cn.fujitsu.com> (raw)
The case expect the signal "SIGUSR1" to wake up child process, so should add
sighandler().
Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
testcases/kernel/syscalls/ipc/shmctl/shmctl01.c | 18 +++++++++++++-----
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/testcases/kernel/syscalls/ipc/shmctl/shmctl01.c b/testcases/kernel/syscalls/ipc/shmctl/shmctl01.c
index 693bf97..f72487b 100644
--- a/testcases/kernel/syscalls/ipc/shmctl/shmctl01.c
+++ b/testcases/kernel/syscalls/ipc/shmctl/shmctl01.c
@@ -138,9 +138,9 @@ int main(int ac, char **av)
void check_functionality(void);
/* parse standard options */
- if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL) {
+ if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
- }
+
#ifdef UCLINUX
argv0 = av[0];
maybe_run_child(do_child, "ddd", &stat_i, &stat_time, &shm_id_1);
@@ -231,8 +231,7 @@ void *set_shmat()
* print a message to that effect.
*/
if (rval == (void *)-1) {
- tst_resm(TBROK, "shmat() failed - %s", strerror(errno));
- cleanup();
+ tst_brkm(TBROK, cleanup, "shmat() failed - %s", strerror(errno));
}
return rval;
@@ -485,10 +484,19 @@ void func_rmid()
shm_id_1 = -1;
}
+/*
+ * sighandler() - handle signals, in this case SIGUSR1 is the only one expected
+ */
+void sighandler(sig)
+{
+ if (sig != SIGUSR1)
+ tst_resm(TINFO, "received unexpected signal %d", sig);
+}
+
void setup(void)
{
- tst_sig(FORK, DEF_HANDLER, cleanup);
+ tst_sig(FORK, sighandler, cleanup);
TEST_PAUSE;
--
1.7.1
--
Best Regards,
Peng Haitao
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2011-03-12 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 9:00 Peng Haitao [this message]
2011-03-13 12:26 ` [LTP] [ltp] [PATCH] shmctl01.c: fix error of the case need sighandler() Caspar Zhang
2011-03-15 12:21 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7B3610.2000905@cn.fujitsu.com \
--to=penght@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox