public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Bian Naimeng <biannm@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [POSIX][PATCH]fix functional/threads/pi_test/pitest-4 test
Date: Sun, 13 Mar 2011 10:10:13 +0800	[thread overview]
Message-ID: <4D7C2785.3020607@cn.fujitsu.com> (raw)
In-Reply-To: <4D40CC9B.5080204@cn.fujitsu.com>



Bian Naimeng wrote:
> Hi Garrett,
> 
>   Would you like to apply this patch? 
> 
>   The priority of TB1 is lower than TFs, if TB1 was assigned to the CPU
> which scheduling TF, TB1 will not have chance to run.
>   I raise the priority of TB1, the new priority of TB1 is higher than TF
> and TL, and still lower than TP.
>   After applying the following patch, test will work correctly.
> 

ping.  Would you have time to pick up it.

Regards
 Bian

> Regards
>   Bian
> 
> Bian Naimeng wrote:
>> TB1 has a lower priority than TFs, it has not chance to run.
>>
>> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>>
>> ---
>>  .../functional/threads/pi_test/pitest-4.c          |   18 +++++++++---------
>>  1 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-4.c b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-4.c
>> index ad940dc..93e44b6 100644
>> --- a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-4.c
>> +++ b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-4.c
>> @@ -69,13 +69,13 @@ struct thread_param
>>  	volatile unsigned progress;
>>  } tp[] = {
>>  	{ 0,   0,   0, 1, SCHED_FIFO, "TL",  0, 0, 0, 0 },
>> -	{ 1,   0, 100, 3, SCHED_FIFO, "TP",  0, 0, 0, 0 },
>> -	{ 2,   0,   0, 4, SCHED_FIFO, "TF",  1, 0, 0, 0 },
>> -	{ 3,   0,   0, 4, SCHED_FIFO, "TF",  2, 0, 0, 0 },
>> -	{ 4,   0,   0, 4, SCHED_FIFO, "TF",  3, 0, 0, 0 },
>> -	{ 5,   0,   0, 4, SCHED_FIFO, "TF",  4, 0, 0, 0 },
>> -	{ 6,   0,   0, 4, SCHED_FIFO, "TF",  5, 0, 0, 0 },
>> -	{ 7,   0,   0, 4, SCHED_FIFO, "TF",  6, 0, 0, 0 }
>> +	{ 1,   0, 100, 4, SCHED_FIFO, "TP",  0, 0, 0, 0 },
>> +	{ 2,   0,   0, 2, SCHED_FIFO, "TF",  1, 0, 0, 0 },
>> +	{ 3,   0,   0, 2, SCHED_FIFO, "TF",  2, 0, 0, 0 },
>> +	{ 4,   0,   0, 2, SCHED_FIFO, "TF",  3, 0, 0, 0 },
>> +	{ 5,   0,   0, 2, SCHED_FIFO, "TF",  4, 0, 0, 0 },
>> +	{ 6,   0,   0, 2, SCHED_FIFO, "TF",  5, 0, 0, 0 },
>> +	{ 7,   0,   0, 2, SCHED_FIFO, "TF",  6, 0, 0, 0 }
>>  };
>>  
>>  volatile unsigned do_work_dummy;
>> @@ -180,7 +180,7 @@ void *thread_tb1(void *arg)
>>  	double t0, t1;
>>  	int rc;
>>  
>> -	test_set_priority(pthread_self(),SCHED_FIFO, 2);
>> +	test_set_priority(pthread_self(), SCHED_FIFO, 3);
>>  	DPRINTF(stderr,"Thread TB1: started\n");
>>  	DPRINTF(stdout, "#EVENT %f Thread TB1 Started\n",
>>  		seconds_read() - base_time);
>> @@ -212,7 +212,7 @@ void *thread_tb2(void *arg)
>>  	double t0, t1;
>>  	int rc;
>>  
>> -	test_set_priority(pthread_self(),SCHED_FIFO, 5);
>> +	test_set_priority(pthread_self(), SCHED_FIFO, 5);
>>  	DPRINTF(stderr,"Thread TB2: started\n");
>>  	DPRINTF(stdout, "#EVENT %f Thread TB2 Started\n",
>>  		seconds_read() - base_time);
> 


------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2011-03-13  2:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  3:01 [LTP] [POSIX][PATCH]fix functional/threads/pi_test/pitest-4 test Bian Naimeng
2011-01-27  1:38 ` Bian Naimeng
2011-03-13  2:10   ` Bian Naimeng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7C2785.3020607@cn.fujitsu.com \
    --to=biannm@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox