From: Caspar Zhang <czhang@redhat.com>
To: Peng Haitao <penght@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ftest06.c: fix error of the child process need exit
Date: Sun, 13 Mar 2011 20:29:47 +0800 [thread overview]
Message-ID: <4D7CB8BB.6080608@redhat.com> (raw)
In-Reply-To: <4D7B4202.1020302@cn.fujitsu.com>
On 03/12/2011 05:50 PM, Peng Haitao wrote:
>
> The child process should exit after invoking dotest().
>
> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
Confirmed this patch and the other ftest06 patch both work on RHEL6.
Tested-by: Caspar Zhang <czhang@redhat.com>
> ---
> testcases/kernel/fs/ftest/ftest06.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/testcases/kernel/fs/ftest/ftest06.c b/testcases/kernel/fs/ftest/ftest06.c
> index d8ff8b6..18eae5d 100644
> --- a/testcases/kernel/fs/ftest/ftest06.c
> +++ b/testcases/kernel/fs/ftest/ftest06.c
> @@ -110,9 +110,8 @@ int main(int ac, char *av[])
> /*
> * parse standard options
> */
> - if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL) {
> + if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> - }
>
> /*
> * Default values for run conditions.
> @@ -162,7 +161,7 @@ int main(int ac, char *av[])
> for (k = 0; k < nchild; k++) {
> if ((child = fork()) == 0) {
> dotest(k, iterations);
> -
> + tst_exit();
> }
> if (child < 0) {
> tst_brkm(TBROK|TERRNO, cleanup, "fork failed");
> @@ -239,8 +238,6 @@ int main(int ac, char *av[])
> }
>
> sync();
> - cleanup();
> -
> }
>
> if (local_flag == FAILED)
--
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-03-13 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 9:50 [LTP] [PATCH] ftest06.c: fix error of the child process need exit Peng Haitao
2011-03-13 12:29 ` Caspar Zhang [this message]
2011-03-15 12:16 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7CB8BB.6080608@redhat.com \
--to=czhang@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=penght@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox