Re: [LTP] [PATCH v2 1/2] [mm] mbind01: not working on 32bit systems

Garrett Cooper
2011-04-10T09:44:02Z

On Sun, Apr 10, 2011 at 2:27 AM, Caspar Zhang <czhang@redhat.com> wrote:
> On 04/10/2011 05:19 PM, Garrett Cooper wrote:
>>     I wouldn't worry too much about it. If it fails with ENOSYS, I
>> would just fail with tst_brkm(TCONF, ...).
>
> Would something like this be good:
>
> err = mbind(addr+pagesize, pagesize, MPOL_BIND, nmask->maskp,
> nmask->size, MPOL_MF_MOVE_ALL);
> if (err != 0)
>  if (errno == ENOSYS)
>    tst_brkm(TCONF,...)
>  else
>    tst_brkm(TBROK|TERRNO, NULL, "mbind1");
>
> If yes, I'll work out an updated patch soon.

Yes, that's fine. Ideally it should follow what's being done in
testcases/kernel/includes/linux_syscall_numbers.h to achieve feature
parity.
Thanks,
-Garrett