Re: [LTP] [PATCH v2 2/2] [mm] mbind01: move to syscalls directory

Garrett Cooper
2011-04-09T06:18:36Z

On Fri, Apr 8, 2011 at 8:24 PM, Caspar Zhang <czhang@redhat.com> wrote:
>
> there are 2 mbind01 tests in different place: syscalls/ and mem/, after
> installation, the latter one would cover the former one, and it's not
> convenient for maintenance. So I move it to syscalls/ and changed its
> name to mbind02.

This is getting bikeshed-y -- but does it really matter where this
stuff is located? I mean.. it's not like one is actually testing the
syscall in this application; he/she is testing a corner case of the
syscall to ensure that it doesn't blow out in a way that creates the
issue that prompted the mainline kernel.org fix.
I really didn't care that much when I committed it as either
location is not ideal. Given the number of CVE reproducers in the tree
now, there should be a separate section like regression, or security
to go over these regression tests in more detail, or at least in a way
that's easy to comprehend and deal with.
Thanks,
-Garrett