Re: [LTP] [PATCH v2 2/2] [mm] mbind01: move to syscalls directory

Caspar Zhang
2011-04-10T05:19:36Z

On 04/09/2011 02:18 PM, Garrett Cooper wrote:
> This is getting bikeshed-y -- but does it really matter where this
> stuff is located? I mean.. it's not like one is actually testing the
> syscall in this application; he/she is testing a corner case of the
> syscall to ensure that it doesn't blow out in a way that creates the
> issue that prompted the mainline kernel.org fix.
> I really didn't care that much when I committed it as either
> location is not ideal. Given the number of CVE reproducers in the tree
> now, there should be a separate section like regression, or security
> to go over these regression tests in more detail, or at least in a way
> that's easy to comprehend and deal with.

I agree with that either location is not ideal, but looked at existed
testcases, some similar regression testcases are put together under
syscalls/: mmap10, mmap11, mlock04, etc. At least doing so makes the
maintenance easier and produces less confusions (in mbind case, there
were two mbind01 tests, obviously when you install whole LTP testcases,
there will be only one exist, the other one is covered).

Creating a 'regression' dir under mem/ and moving mmap10, mmap11,
mlock04, mbind01 tests there may be a good choice. But how to name these
testcases? I don't want to see it happens again like two "XXX01" tests
exist in LTP, to avoid so, the new testcase writer should look into all
testcases and then give a different number suffix...

Thanks,
Caspar