[LTP] [PATCH v2] cgroups/cpuacct_setup: fix task_kill() search for process

[LTP] [PATCH v2] cgroups/cpuacct_setup: fix task_kill() search for process

[Jan Stancek]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]


1. "i* in "grep cpuacct_taski*" seems pointless as
its target is cpuacct_task01

2. using cut fails when ps indents the output as following:
   99 cpuacct_task01
  112 cpuacct_task01
1111 cpuacct_task01

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
  .../kernel/controllers/cpuacct/cpuacct_setup.sh    |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)



[-- Attachment #2: 0001-cgroups-cpuacct_setup-fix-task_kill-search-for-proce.patch --]
[-- Type: text/x-patch, Size: 470 bytes --]

diff --git a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
index 47cd1da..2443a28 100755
--- a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
+++ b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
@@ -58,7 +58,7 @@ cleanup ()
 }
 task_kill ()
 {
-	for i in `ps -e | grep cpuacct_taski* | cut -d" " -f1`
+	for i in `ps -e | grep cpuacct_task | awk '{print $1}'`
 	do
 		kill -SIGUSR1 $i
 	done


[-- Attachment #3: Type: text/plain, Size: 438 bytes --]

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH v2] cgroups/cpuacct_setup: fix task_kill() search for process

[Jan Stancek]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]


1. "i* in "grep cpuacct_taski*" seems pointless as
its target is cpuacct_task01

2. using cut fails when ps indents the output as following:
   99 cpuacct_task01
  112 cpuacct_task01
1111 cpuacct_task01

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
  .../kernel/controllers/cpuacct/cpuacct_setup.sh    |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)



[-- Attachment #2: 0001-cgroups-cpuacct_setup-fix-task_kill-search-for-proce.patch --]
[-- Type: text/x-patch, Size: 470 bytes --]

diff --git a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
index 47cd1da..2443a28 100755
--- a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
+++ b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
@@ -58,7 +58,7 @@ cleanup ()
 }
 task_kill ()
 {
-	for i in `ps -e | grep cpuacct_taski* | cut -d" " -f1`
+	for i in `ps -e | grep cpuacct_task | awk '{print $1}'`
 	do
 		kill -SIGUSR1 $i
 	done


[-- Attachment #3: Type: text/plain, Size: 318 bytes --]

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] cgroups/cpuacct_setup: fix task_kill() search for process

[Cyril Hrubis]

Hi!
> 
> 1. "i* in "grep cpuacct_taski*" seems pointless as
> its target is cpuacct_task01
> 
> 2. using cut fails when ps indents the output as following:
>   99 cpuacct_task01
>  112 cpuacct_task01
> 1111 cpuacct_task01
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>

Commited, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list