From: Jan Stancek <jstancek@redhat.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH 6/6 v3] cgroups/cgroup_regression_test: fix test_*.sh trap in loop
Date: Fri, 22 Jul 2011 10:11:11 +0200 [thread overview]
Message-ID: <4E29309F.2050307@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
test_*.sh scripts use trap in tight loop, which may cause bash
to miss signal, see:
https://bugzilla.redhat.com/show_bug.cgi?id=695656
Move trap outside loop to avoid it.
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
testcases/kernel/controllers/cgroup/test_10_1.sh | 3 +--
testcases/kernel/controllers/cgroup/test_10_2.sh | 3 +--
testcases/kernel/controllers/cgroup/test_3_1.sh | 3 +--
testcases/kernel/controllers/cgroup/test_3_2.sh | 3 +--
testcases/kernel/controllers/cgroup/test_6_1.sh | 3 +--
testcases/kernel/controllers/cgroup/test_9_1.sh | 3 +--
testcases/kernel/controllers/cgroup/test_9_2.sh | 3 +--
7 files changed, 7 insertions(+), 14 deletions(-)
[-- Attachment #2: 0006-cgroups-cgroup_regression_test-fix-test_-.sh-trap-in.patch --]
[-- Type: text/x-patch, Size: 4234 bytes --]
diff --git a/testcases/kernel/controllers/cgroup/test_10_1.sh b/testcases/kernel/controllers/cgroup/test_10_1.sh
index 6284722..ffa0d5f 100755
--- a/testcases/kernel/controllers/cgroup/test_10_1.sh
+++ b/testcases/kernel/controllers/cgroup/test_10_1.sh
@@ -22,13 +22,12 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
mount -t cgroup xxx cgroup/ > /dev/null 2>&1
mkdir cgroup/0 > /dev/null 2>&1
rmdir cgroup/0 > /dev/null 2>&1
umount cgroup/ > /dev/null 2>&1
-
- trap exit SIGUSR1
}
diff --git a/testcases/kernel/controllers/cgroup/test_10_2.sh b/testcases/kernel/controllers/cgroup/test_10_2.sh
index 82b91e3..f811bbd 100755
--- a/testcases/kernel/controllers/cgroup/test_10_2.sh
+++ b/testcases/kernel/controllers/cgroup/test_10_2.sh
@@ -22,11 +22,10 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
mount -t cgroup xxx cgroup/ > /dev/null 2>&1
umount cgroup/ > /dev/null 2>&1
-
- trap exit SIGUSR1
}
diff --git a/testcases/kernel/controllers/cgroup/test_3_1.sh b/testcases/kernel/controllers/cgroup/test_3_1.sh
index 86627d4..507a2c4 100755
--- a/testcases/kernel/controllers/cgroup/test_3_1.sh
+++ b/testcases/kernel/controllers/cgroup/test_3_1.sh
@@ -22,11 +22,10 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
mkdir cgroup/0
rmdir cgroup/0
-
- trap exit SIGUSR1
}
diff --git a/testcases/kernel/controllers/cgroup/test_3_2.sh b/testcases/kernel/controllers/cgroup/test_3_2.sh
index c942969..9f83d9d 100755
--- a/testcases/kernel/controllers/cgroup/test_3_2.sh
+++ b/testcases/kernel/controllers/cgroup/test_3_2.sh
@@ -22,10 +22,9 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
cat /proc/sched_debug > /dev/null
-
- trap exit SIGUSR1
}
diff --git a/testcases/kernel/controllers/cgroup/test_6_1.sh b/testcases/kernel/controllers/cgroup/test_6_1.sh
index ff70677..e91e794 100755
--- a/testcases/kernel/controllers/cgroup/test_6_1.sh
+++ b/testcases/kernel/controllers/cgroup/test_6_1.sh
@@ -22,12 +22,11 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
mount -t cgroup -o ns xxx cgroup/ > /dev/null 2>&1
rmdir cgroup/[1-9]* > /dev/null 2>&1
umount cgroup/ > /dev/null 2>&1
-
- trap exit SIGUSR1
}
diff --git a/testcases/kernel/controllers/cgroup/test_9_1.sh b/testcases/kernel/controllers/cgroup/test_9_1.sh
index 24a1524..c6e8f6f 100755
--- a/testcases/kernel/controllers/cgroup/test_9_1.sh
+++ b/testcases/kernel/controllers/cgroup/test_9_1.sh
@@ -22,13 +22,12 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
# mount -t cgroup -o debug xxx cgroup/ > /dev/null 2>&1
mount -t cgroup xxx cgroup/ > /dev/null 2>&1
cat cgroup/release_agent > /dev/null 2>&1
umount cgroup/ > /dev/null 2>&1
-
- trap exit SIGUSR1
}
diff --git a/testcases/kernel/controllers/cgroup/test_9_2.sh b/testcases/kernel/controllers/cgroup/test_9_2.sh
index 654df4d..f8e1c61 100755
--- a/testcases/kernel/controllers/cgroup/test_9_2.sh
+++ b/testcases/kernel/controllers/cgroup/test_9_2.sh
@@ -22,12 +22,11 @@
## ##
################################################################################
+trap exit SIGUSR1
for ((; ;))
{
# mount -t cgroup -o debug xxx cgroup/ > /dev/null 2>&1
mount -t cgroup xxx cgroup/ > /dev/null 2>&1
umount cgroup/ > /dev/null 2>&1
-
- trap exit SIGUSR1
}
[-- Attachment #3: Type: text/plain, Size: 380 bytes --]
------------------------------------------------------------------------------
10 Tips for Better Web Security
Learn 10 ways to better secure your business today. Topics covered include:
Web security, SSL, hacker attacks & Denial of Service (DoS), private keys,
security Microsoft Exchange, secure Instant Messaging, and much more.
http://www.accelacomm.com/jaw/sfnl/114/51426210/
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
reply other threads:[~2011-07-22 8:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E29309F.2050307@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox