[LTP] [Patch v2 1/4] KSM test case fixes - ksm01

[LTP] [Patch v2 1/4] KSM test case fixes - ksm01

[Nageswara R Sastry]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Thanks Casper. Used macro 'PATH_KSM' and removed braces. And tested the 
same.

ksm01, ksm01_1:
Before patch:
...
ksm01       0  TINFO  :  KSM merging...
ksm01       1  TBROK  :  open: errno=ENOENT(2): No such file or directory
ksm01       2  TBROK  :  Remaining cases broken
...

After patch:
...
ksm01       1  TCONF  :  KSM configuration is not enabled
ksm01       2  TCONF  :  Remaining cases not appropriate for configuration
...

Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>

-- 
Regards
R.Nageswara Sastry


[-- Attachment #2: ksm01.patch --]
[-- Type: text/plain, Size: 395 bytes --]

--- ltp.orig/testcases/kernel/mem/ksm/ksm01.c	2011-09-05 08:42:12.000000000 +0200
+++ ltp/testcases/kernel/mem/ksm/ksm01.c	2011-09-06 13:48:56.000000000 +0200
@@ -109,6 +109,8 @@ void setup(void)
 
 	tst_sig(FORK, DEF_HANDLER, NULL);
 	TEST_PAUSE;
+        if( access( PATH_KSM, F_OK ) == -1 )
+                tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
 }
 
 void cleanup(void)

[-- Attachment #3: Type: text/plain, Size: 357 bytes --]

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [Patch v2 1/4] KSM test case fixes - ksm01

[Cyril Hrubis]

Hi!
> >--- ltp.orig/testcases/kernel/mem/ksm/ksm01.c	2011-09-05 08:42:12.000000000 +0200
> >+++ ltp/testcases/kernel/mem/ksm/ksm01.c	2011-09-06 13:48:56.000000000 +0200
> >@@ -109,6 +109,8 @@ void setup(void)
> >
> >  	tst_sig(FORK, DEF_HANDLER, NULL);
> >  	TEST_PAUSE;
> >+        if( access( PATH_KSM, F_OK ) == -1 )
> >+                tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
> 
> Hi, sorry I still have some comments to the new version of 1/4 and 2/4.
> 
> format corrections:
> 
> 1. use tab instead of 8 spaces
> 2. space after "if" and no space inside round backets
> 
> (you may want to check the style-guide in LTPROOT/doc/style-guide.txt)
> 
> And I suggest put this if-condtion before tst_sig(). Cyril, any comments?

LTP uses LKML coding style and you can use the checkpatch.pl script
packed with kernel sources (reasonably new sources are needed) to check
that your patch is clean.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list