[LTP] [Patch v2 3/4] KSM test case fixes - mmap10

[LTP] [Patch v2 3/4] KSM test case fixes - mmap10

[Nageswara R Sastry]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Thanks Casper. Used macro 'PATH_KSM' and removed braces. And tested the 
same.

mmap10_2:
Before patch:
...
mmap10      0  TINFO  :  add to KSM regions.
mmap10      0  TINFO  :  use /dev/zero.
mmap10      0  TINFO  :  start tests.
mmap10      1  TBROK  :  madvise: errno=EINVAL(22): Invalid argument
mmap10      2  TBROK  :  Remaining cases broken
...

After patch:
...
mmap10      1  TCONF  :  KSM configuration is not enabled
mmap10      2  TCONF  :  Remaining cases not appropriate for configuration
...


mmap10_3, mmap10_4, mmap10_5:
Before patch:
...
mmap10      0  TINFO  :  add to KSM regions.
mmap10      0  TINFO  :  use anonymous pages.
mmap10      0  TINFO  :  start tests.
mmap10      1  TBROK  :  madvise: errno=EINVAL(22): Invalid argument
mmap10      2  TBROK  :  Remaining cases broken
...

After patch:
...
mmap10      1  TCONF  :  KSM configuration is not enabled
mmap10      2  TCONF  :  Remaining cases not appropriate for configuration
...

Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>

-- 
Regards
R.Nageswara Sastry


[-- Attachment #2: mmap10.patch --]
[-- Type: text/plain, Size: 574 bytes --]

--- ltp.orig/testcases/kernel/syscalls/mmap/mmap10.c	2011-09-05 08:42:12.000000000 +0200
+++ ltp/testcases/kernel/syscalls/mmap/mmap10.c	2011-09-06 14:10:23.000000000 +0200
@@ -62,6 +62,7 @@
 #include "test.h"
 #include "usctest.h"
 #include "config.h"
+#include "../../mem/include/mem.h"
 
 #define SIZE (5*1024*1024)
 
@@ -94,6 +95,8 @@ int main(int argc, char *argv[])
 
 	if (opt_ksm)
 	{
+		if( access( PATH_KSM, F_OK ) == -1 )
+			tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
 #ifdef HAVE_MADV_MERGEABLE
 		tst_resm(TINFO, "add to KSM regions.");
 #else

[-- Attachment #3: Type: text/plain, Size: 357 bytes --]

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [Patch v2 3/4] KSM test case fixes - mmap10

[Cyril Hrubis]

Hi!
> >--- ltp.orig/testcases/kernel/syscalls/mmap/mmap10.c	2011-09-05 08:42:12.000000000 +0200
> >+++ ltp/testcases/kernel/syscalls/mmap/mmap10.c	2011-09-06 14:10:23.000000000 +0200
> >@@ -62,6 +62,7 @@
> >  #include "test.h"
> >  #include "usctest.h"
> >  #include "config.h"
> >+#include "../../mem/include/mem.h"
> >
> >  #define SIZE (5*1024*1024)
> >
> >@@ -94,6 +95,8 @@ int main(int argc, char *argv[])
> >
> >  	if (opt_ksm)
> >  	{
> >+		if( access( PATH_KSM, F_OK ) == -1 )
> >+			tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
> >  #ifdef HAVE_MADV_MERGEABLE
> >  		tst_resm(TINFO, "add to KSM regions.");
> >  #else
> 
> Hmmm... seems HAVE_MADV_MERGEABLE is not enough? from man page:
> 
> The MADV_MERGEABLE and MADV_UNMERGEABLE operations are only
> available if the kernel was configured with CONFIG_KSM.
> 
> Doesn't that means, if CONFIG_KSM is not set, MAD_MERGEABLE won't be
> defined?

I don't think so, the problem here is that you can't say that KSM is in
the kernel at test compile time, just because you can reboot into
another kernel after the test is compiled, even more when the LTP is
packaged you don't really know what kernel it will run on. The
HAVE_MADV_MERGEABLE is enough to get the test compiled with
MADV_MERGEABLE support, however you still may get ENOSYS from the
syscall when the test is executed.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list