[LTP] [Patch v3 1/4] KSM test case fixes - ksm01

[LTP] [Patch v3 1/4] KSM test case fixes - ksm01

[Nageswara R Sastry]

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

Fixed format issues.

Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>

-- 
Regards
R.Nageswara Sastry


[-- Attachment #2: ksm01.patch --]
[-- Type: text/plain, Size: 445 bytes --]

--- ltp.orig/testcases/kernel/mem/ksm/ksm01.c	2011-09-05 08:42:12.000000000 +0200
+++ ltp/testcases/kernel/mem/ksm/ksm01.c	2011-09-06 14:49:27.000000000 +0200
@@ -106,6 +106,8 @@ void setup(void)
 
 	if (tst_kvercmp(2, 6, 32) < 0)
 		tst_brkm(TCONF, NULL, "2.6.32 or greater kernel required");
+	if(access( PATH_KSM, F_OK ) == -1)
+		tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
 
 	tst_sig(FORK, DEF_HANDLER, NULL);
 	TEST_PAUSE;

[-- Attachment #3: Type: text/plain, Size: 357 bytes --]

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [Patch v3 1/4] KSM test case fixes - ksm01

[Cyril Hrubis]

Hi!
> Fixed format issues.

^ please write here short description of the problme that the patch is
  fixing. Somethink like "Disable ksm01 test if KSM is not supported"
  should do.

> Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
> 
> -- 
> Regards
> R.Nageswara Sastry
> 

> --- ltp.orig/testcases/kernel/mem/ksm/ksm01.c	2011-09-05 08:42:12.000000000 +0200
> +++ ltp/testcases/kernel/mem/ksm/ksm01.c	2011-09-06 14:49:27.000000000 +0200
> @@ -106,6 +106,8 @@ void setup(void)
>  
>  	if (tst_kvercmp(2, 6, 32) < 0)
>  		tst_brkm(TCONF, NULL, "2.6.32 or greater kernel required");
> +	if(access( PATH_KSM, F_OK ) == -1)
> +		tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
>  
>  	tst_sig(FORK, DEF_HANDLER, NULL);
>  	TEST_PAUSE;

Still there should be whitespace after the if and there shouldn't be
whitespaces on the inner side of the braces.

Could you pretty please use the checkpatch.pl script, that should save
both your and mine time ;).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list