* Re: [LTP] [Patch] sockioctl01 test case fix
@ 2011-09-09 6:02 Nageswara R Sastry
0 siblings, 0 replies; 3+ messages in thread
From: Nageswara R Sastry @ 2011-09-09 6:02 UTC (permalink / raw)
To: ltp-list
Hello,
Any comments on this patch. Thanks!!
> In sockioctl01 testcase,
> Current 'inappropriate ioctl operation returning EINVAL'
>
> With the git commit '41c31f318a5209922d051e293c61e4724daad11c' more
> details athttp://permalink.gmane.org/gmane.linux.kernel.commits.head/296060
>
> 'inappropriate ioctl operation returning ENOTTY'
>
> The following patch will fix this.
>
>
> sockioctl01:
> Before patch:
> ...
> sockioctl01 4 TFAIL : ATMARK on UDP ; returned -1 (expected -1),
> errno 25 (expected 22)
> ...
>
> After patch:
> ...
> sockioctl01 4 TPASS : ATMARK on UDP successful
> ...
>
>
> Signed-off-by: Nageswara R Sastry<rnsastry@...>
--
Regards
R.Nageswara Sastry
------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT
space for its ease of implementation, lower cost, and increased
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [Patch] sockioctl01 test case fix
@ 2011-09-05 10:18 Nageswara R Sastry
2011-09-09 11:03 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Nageswara R Sastry @ 2011-09-05 10:18 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
In sockioctl01 testcase,
Current 'inappropriate ioctl operation returning EINVAL'
With the git commit '41c31f318a5209922d051e293c61e4724daad11c' more
details at http://permalink.gmane.org/gmane.linux.kernel.commits.head/296060
'inappropriate ioctl operation returning ENOTTY'
The following patch will fix this.
sockioctl01:
Before patch:
...
sockioctl01 4 TFAIL : ATMARK on UDP ; returned -1 (expected -1),
errno 25 (expected 22)
...
After patch:
...
sockioctl01 4 TPASS : ATMARK on UDP successful
...
Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
--
Regards
R.Nageswara Sastry
[-- Attachment #2: sockioctl01.patch --]
[-- Type: text/plain, Size: 643 bytes --]
--- ltp.orig/testcases/kernel/syscalls/sockioctl/sockioctl01.c 2011-09-05 08:42:12.000000000 +0200
+++ ltp/testcases/kernel/syscalls/sockioctl/sockioctl01.c 2011-09-05 08:47:52.000000000 +0200
@@ -227,6 +227,12 @@ void setup1(void)
strerror(errno));
}
sinlen = sizeof(fsin1);
+
+ if (strncmp(tdat[testno].desc, "ATMARK on UDP", 14) == 0) {
+ if ( tst_kvercmp(2,6,39) >= 0 || tst_kvercmp(3,0,0) >= 0 ) {
+ tdat[testno].experrno = ENOTTY;
+ }
+ }
}
void setup2(void)
@@ -254,4 +260,4 @@ void cleanup1(void)
{
(void)close(s);
s = -1;
-}
\ No newline at end of file
+}
[-- Attachment #3: Type: text/plain, Size: 357 bytes --]
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [LTP] [Patch] sockioctl01 test case fix
2011-09-05 10:18 Nageswara R Sastry
@ 2011-09-09 11:03 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2011-09-09 11:03 UTC (permalink / raw)
To: Nageswara R Sastry; +Cc: ltp-list
Hi!
> sockioctl01:
> Before patch:
> ...
> sockioctl01 4 TFAIL : ATMARK on UDP ; returned -1 (expected
> -1), errno 25 (expected 22)
> ...
>
> After patch:
> ...
> sockioctl01 4 TPASS : ATMARK on UDP successful
> ...
>
>
> Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
>
> --
> Regards
> R.Nageswara Sastry
>
> --- ltp.orig/testcases/kernel/syscalls/sockioctl/sockioctl01.c 2011-09-05 08:42:12.000000000 +0200
> +++ ltp/testcases/kernel/syscalls/sockioctl/sockioctl01.c 2011-09-05 08:47:52.000000000 +0200
> @@ -227,6 +227,12 @@ void setup1(void)
> strerror(errno));
> }
> sinlen = sizeof(fsin1);
> +
> + if (strncmp(tdat[testno].desc, "ATMARK on UDP", 14) == 0) {
> + if ( tst_kvercmp(2,6,39) >= 0 || tst_kvercmp(3,0,0) >= 0 ) {
> + tdat[testno].experrno = ENOTTY;
> + }
> + }
> }
>
> void setup2(void)
> @@ -254,4 +260,4 @@ void cleanup1(void)
> {
> (void)close(s);
> s = -1;
> -}
> \ No newline at end of file
> +}
Same as the previous one.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT
space for its ease of implementation, lower cost, and increased
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-09 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 6:02 [LTP] [Patch] sockioctl01 test case fix Nageswara R Sastry
-- strict thread matches above, loose matches on Subject: below --
2011-09-05 10:18 Nageswara R Sastry
2011-09-09 11:03 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox