* Re: [LTP] [Patch] readlink03 test case fix
@ 2011-09-09 6:04 Nageswara R Sastry
0 siblings, 0 replies; 3+ messages in thread
From: Nageswara R Sastry @ 2011-09-09 6:04 UTC (permalink / raw)
To: ltp-list
Hello,
Any comments on this patch. Thanks!!
> In readlink03 testcase,
> When 'Symlink Pathname is empty' the return value was 'ENOENT' but with
> newer kernels the return value is 'EINVAL'. The following patch will fix
> this.
>
> readlink03:
> Before patch:
> ...
> readlink03 9 TFAIL : readlink() failed, Symlink Pathname is empty,
> errno=22, expected errno=2
> ...
>
> After patch:
> ...
> readlink03 9 TPASS : readlink(), Symlink Pathname is empty,
> returned errno 22
> readlink03 10 TPASS : readlink(), Symlink Pathname is empty,
> returned errno 22
> ...
>
> Signed-off-by: Nageswara R Sastry<rnsastry@...>
--
Regards
R.Nageswara Sastry
------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT
space for its ease of implementation, lower cost, and increased
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [Patch] readlink03 test case fix
@ 2011-09-05 10:17 Nageswara R Sastry
2011-09-09 11:02 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Nageswara R Sastry @ 2011-09-05 10:17 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
In readlink03 testcase,
When 'Symlink Pathname is empty' the return value was 'ENOENT' but with
newer kernels the return value is 'EINVAL'. The following patch will fix
this.
readlink03:
Before patch:
...
readlink03 9 TFAIL : readlink() failed, Symlink Pathname is empty,
errno=22, expected errno=2
...
After patch:
...
readlink03 9 TPASS : readlink(), Symlink Pathname is empty,
returned errno 22
readlink03 10 TPASS : readlink(), Symlink Pathname is empty,
returned errno 22
...
Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
--
Regards
R.Nageswara Sastry
[-- Attachment #2: readlink03.patch --]
[-- Type: text/plain, Size: 835 bytes --]
--- ltp.orig/testcases/kernel/syscalls/readlink/readlink03.c 2011-09-05 08:42:12.000000000 +0200
+++ ltp/testcases/kernel/syscalls/readlink/readlink03.c 2011-09-05 08:49:28.000000000 +0200
@@ -172,7 +172,11 @@ int main(int ac, char **av)
if (buf_size == 1) {
buf_size = sizeof(buffer);
}
-
+ if (strncmp(test_desc, "Symlink Pathname is empty", 25) == 0) {
+ if ( tst_kvercmp(2,6,39) >= 0 || tst_kvercmp(3,0,0) >= 0 ) {
+ Test_cases[i].exp_errno = EINVAL;
+ }
+ }
/*
* Call readlink(2) to test different test conditions.
* verify that it fails with -1 return value and sets
@@ -358,4 +362,4 @@ void cleanup()
tst_rmdir();
-}
\ No newline at end of file
+}
[-- Attachment #3: Type: text/plain, Size: 357 bytes --]
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [LTP] [Patch] readlink03 test case fix
2011-09-05 10:17 Nageswara R Sastry
@ 2011-09-09 11:02 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2011-09-09 11:02 UTC (permalink / raw)
To: Nageswara R Sastry; +Cc: ltp-list
Hi!
> --- ltp.orig/testcases/kernel/syscalls/readlink/readlink03.c 2011-09-05 08:42:12.000000000 +0200
> +++ ltp/testcases/kernel/syscalls/readlink/readlink03.c 2011-09-05 08:49:28.000000000 +0200
> @@ -172,7 +172,11 @@ int main(int ac, char **av)
> if (buf_size == 1) {
> buf_size = sizeof(buffer);
> }
> -
> + if (strncmp(test_desc, "Symlink Pathname is empty", 25) == 0) {
> + if ( tst_kvercmp(2,6,39) >= 0 || tst_kvercmp(3,0,0) >= 0 ) {
There shouldn't be anything special about 3.0.0 as 3.0.0 is greater
number than 2.6.39.
> + Test_cases[i].exp_errno = EINVAL;
> + }
> + }
> /*
> * Call readlink(2) to test different test conditions.
> * verify that it fails with -1 return value and sets
> @@ -358,4 +362,4 @@ void cleanup()
>
> tst_rmdir();
>
> -}
> \ No newline at end of file
> +}
And please run through checkpatch.pl before resending.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT
space for its ease of implementation, lower cost, and increased
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-09 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 6:04 [LTP] [Patch] readlink03 test case fix Nageswara R Sastry
-- strict thread matches above, loose matches on Subject: below --
2011-09-05 10:17 Nageswara R Sastry
2011-09-09 11:02 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox