[LTP] [PATCH] recvmsg01: kill child only if one was forked

[Jan Stancek <jstancek@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]


If start_server() fails, then pid will end up with -1 and
cleanup() will do kill(-1, SIGKILL), which kills everything
this process can kill.

Change the test to kill pid (child) only when it successfully
creates one.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
  testcases/kernel/syscalls/recvmsg/recvmsg01.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)



[-- Attachment #2: 0001-recvmsg01-kill-child-only-if-one-was-forked.patch --]
[-- Type: text/x-patch, Size: 632 bytes --]

diff --git a/testcases/kernel/syscalls/recvmsg/recvmsg01.c b/testcases/kernel/syscalls/recvmsg/recvmsg01.c
index ba3b0fd..41d0726 100644
--- a/testcases/kernel/syscalls/recvmsg/recvmsg01.c
+++ b/testcases/kernel/syscalls/recvmsg/recvmsg01.c
@@ -281,7 +281,8 @@ void setup(void)
 
 void cleanup(void)
 {
-	(void)kill(pid, SIGKILL);	/* kill server */
+	if (pid > 0)
+		(void)kill(pid, SIGKILL);	/* kill server */
 	if (tmpsunpath[0] != '\0')
 		(void)unlink(tmpsunpath);
 	TEST_CLEANUP;
@@ -528,4 +529,4 @@ void sender(int fd)
 	(void)sendmsg(fd, &mh, 0);
 	(void)close(tfd);
 	(void)unlink(tmpfn);
-}
\ No newline at end of file
+}


[-- Attachment #3: Type: text/plain, Size: 169 bytes --]

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list