Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 11/08/2011 03:50 PM, Jan Stancek wrote:

> 
> 
> ----- Original Message -----
>> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp-list@lists.sourceforge.net
>> Sent: Tuesday, November 8, 2011 8:21:01 AM
>> Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked
>>
>> On 11/08/2011 03:14 PM, Jan Stancek wrote:
>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>>>> To: "Jan Stancek" <jstancek@redhat.com>
>>>> Cc: ltp-list@lists.sourceforge.net
>>>> Sent: Tuesday, November 8, 2011 4:07:56 AM
>>>> Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was
>>>> forked
>>>>
>>>> On 11/07/2011 08:53 PM, Jan Stancek wrote:
>>>>
>>>>>
>>>>> If start_server() fails, then pid will end up with -1 and
>>>>> cleanup() will do kill(-1, SIGKILL), which kills everything
>>>>> this process can kill.
>>>>>
>>>>> Change the test to kill pid (child) only when it successfully
>>>>> creates one.
>>>>>
>>>>
>>>>
>>>> Yeah, but this can't fix the problem in this case?
>>>>
>>>> recvmsg01    1  TBROK  :  server bind failed: errno=???(98):
>>>> Address
>>>> already in use
>>>> recvmsg01    2  TBROK  :  Remaining cases broken
>>>>
>>>
>>> I'm not sure I follow you here.
>>> In case you described start_server() returns -1,
>>> so pid = -1, and cleanup won't do kill(-1, SIGKILL).
>>>
>>
>>
>> Yeah, I understood you.
>>
>> But we wanna fix the case to TPASS but not TBROK, do we?
> 
> True, but until we have such fix, we should at least make it
> less annoying when it fails.
> 
>> So, I mean that the issues of this case is not only what you said.
> 
> I didn't actually get to see yet what those are, because those
> TBROK messages didn't make it to log:
> 
> <<<test_start>>>
> tag=recvmsg01 stime=1320555319
> cmdline="recvmsg01"
> contacts=""
> analysis=exit
> <<<test_output>>>
> <<<execution_status>>>
> initiation_status="ok"
> duration=0 termination_type=signaled termination_id=9 corefile=no
> cutime=0 cstime=0
> <<<test_end>>>
> 
> Regards,
> Jan
> 


You can do like this:
while [ $? -eq 0 ]; do ./recvmsg01; done

Then you can see the TBROK message.

-Wanlong Gao

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list