Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 12/09/2011 04:28 PM, Kang Kai wrote:

> Local var 'rc' in function main hides the global one. In child thread
> it sets global var 'rc' with funtion return value. But in function main,
> test var 'rc' always succeeds because it tests local var 'rc'.
> 


Good catch.

Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>  .../interfaces/pthread_rwlock_unlock/4-2.c         |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> index 3023886..4928f85 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>  int main()
>  {
>  	int cnt = 0;
> -	int rc = 0;
>  
>  	pthread_t un_thread;
>  
> @@ -125,4 +124,4 @@ int main()
>  
>  	printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>  	return PTS_PASS;
> -}
> \ No newline at end of file
> +}



------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list