* [LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first
2011-12-09 8:28 [LTP] Patches for POSIX test cases Kang Kai
@ 2011-12-09 8:28 ` Kang Kai
2011-12-13 6:04 ` Garrett Cooper
2011-12-09 8:28 ` [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc' Kang Kai
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Kang Kai @ 2011-12-09 8:28 UTC (permalink / raw)
To: ltp-list
Test case failed for linux in some platform. Make parent thread
sleep for a while to make sure that signal handlers are installed
before send signal USR1 and USR2.
Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
.../interfaces/pthread_mutex_lock/3-1.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
index 771851d..a648c96 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
@@ -307,6 +307,8 @@ int main (int argc, char * argv[])
if ((ret = pthread_create(&th_work, NULL, threaded, NULL)))
{ UNRESOLVED(ret, "Worker thread creation failed"); }
+ sleep(1);
+
arg1.thr = &th_work;
arg2.thr = &th_work;
arg1.sig = SIGUSR1;
@@ -359,4 +361,4 @@ int main (int argc, char * argv[])
#endif
#endif
PASSED;
-}
\ No newline at end of file
+}
--
1.7.5.4
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first
2011-12-09 8:28 ` [LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first Kang Kai
@ 2011-12-13 6:04 ` Garrett Cooper
0 siblings, 0 replies; 11+ messages in thread
From: Garrett Cooper @ 2011-12-13 6:04 UTC (permalink / raw)
To: Kang Kai; +Cc: ltp-list
On Fri, Dec 9, 2011 at 12:28 AM, Kang Kai <kai.kang@windriver.com> wrote:
> Test case failed for linux in some platform. Make parent thread
> sleep for a while to make sure that signal handlers are installed
> before send signal USR1 and USR2.
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
> .../interfaces/pthread_mutex_lock/3-1.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
> index 771851d..a648c96 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
> @@ -307,6 +307,8 @@ int main (int argc, char * argv[])
> if ((ret = pthread_create(&th_work, NULL, threaded, NULL)))
> { UNRESOLVED(ret, "Worker thread creation failed"); }
>
> + sleep(1);
> +
> arg1.thr = &th_work;
> arg2.thr = &th_work;
> arg1.sig = SIGUSR1;
> @@ -359,4 +361,4 @@ int main (int argc, char * argv[])
> #endif
> #endif
> PASSED;
> -}
> \ No newline at end of file
> +}
> --
> 1.7.5.4
It's better than status quo, but it's still kind of race prone (highly
unlikely, but you never know). It seems like a pthread_mutex would
make more sense in this case.
Thanks,
-Garrett
------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and
improve service delivery. Take 5 minutes to use this Systems Optimization
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'
2011-12-09 8:28 [LTP] Patches for POSIX test cases Kang Kai
2011-12-09 8:28 ` [LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first Kang Kai
@ 2011-12-09 8:28 ` Kang Kai
2011-12-09 9:18 ` Wanlong Gao
2011-12-09 8:52 ` [LTP] Patches for POSIX test cases Wanlong Gao
2011-12-09 13:04 ` Cyril Hrubis
3 siblings, 1 reply; 11+ messages in thread
From: Kang Kai @ 2011-12-09 8:28 UTC (permalink / raw)
To: ltp-list
Local var 'rc' in function main hides the global one. In child thread
it sets global var 'rc' with funtion return value. But in function main,
test var 'rc' always succeeds because it tests local var 'rc'.
Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
.../interfaces/pthread_rwlock_unlock/4-2.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
index 3023886..4928f85 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
@@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
int main()
{
int cnt = 0;
- int rc = 0;
pthread_t un_thread;
@@ -125,4 +124,4 @@ int main()
printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
return PTS_PASS;
-}
\ No newline at end of file
+}
--
1.7.5.4
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'
2011-12-09 8:28 ` [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc' Kang Kai
@ 2011-12-09 9:18 ` Wanlong Gao
2011-12-13 5:56 ` Garrett Cooper
0 siblings, 1 reply; 11+ messages in thread
From: Wanlong Gao @ 2011-12-09 9:18 UTC (permalink / raw)
To: Kang Kai; +Cc: ltp-list
On 12/09/2011 04:28 PM, Kang Kai wrote:
> Local var 'rc' in function main hides the global one. In child thread
> it sets global var 'rc' with funtion return value. But in function main,
> test var 'rc' always succeeds because it tests local var 'rc'.
>
Good catch.
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
> .../interfaces/pthread_rwlock_unlock/4-2.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> index 3023886..4928f85 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
> int main()
> {
> int cnt = 0;
> - int rc = 0;
>
> pthread_t un_thread;
>
> @@ -125,4 +124,4 @@ int main()
>
> printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
> return PTS_PASS;
> -}
> \ No newline at end of file
> +}
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'
2011-12-09 9:18 ` Wanlong Gao
@ 2011-12-13 5:56 ` Garrett Cooper
2011-12-13 6:08 ` Wanlong Gao
0 siblings, 1 reply; 11+ messages in thread
From: Garrett Cooper @ 2011-12-13 5:56 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On Fri, Dec 9, 2011 at 1:18 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
> On 12/09/2011 04:28 PM, Kang Kai wrote:
>
>> Local var 'rc' in function main hides the global one. In child thread
>> it sets global var 'rc' with funtion return value. But in function main,
>> test var 'rc' always succeeds because it tests local var 'rc'.
>>
>
>
> Good catch.
>
> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>> ---
>> .../interfaces/pthread_rwlock_unlock/4-2.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>> index 3023886..4928f85 100644
>> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>> int main()
>> {
>> int cnt = 0;
>> - int rc = 0;
>>
>> pthread_t un_thread;
>>
>> @@ -125,4 +124,4 @@ int main()
>>
>> printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>> return PTS_PASS;
>> -}
>> \ No newline at end of file
>> +}
Will be committed soon (kind of interesting why -Wshadow didn't
identify this issue...).
-Garrett
------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and
improve service delivery. Take 5 minutes to use this Systems Optimization
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'
2011-12-13 5:56 ` Garrett Cooper
@ 2011-12-13 6:08 ` Wanlong Gao
0 siblings, 0 replies; 11+ messages in thread
From: Wanlong Gao @ 2011-12-13 6:08 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
On 12/13/2011 01:56 PM, Garrett Cooper wrote:
> On Fri, Dec 9, 2011 at 1:18 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>> On 12/09/2011 04:28 PM, Kang Kai wrote:
>>
>>> Local var 'rc' in function main hides the global one. In child thread
>>> it sets global var 'rc' with funtion return value. But in function main,
>>> test var 'rc' always succeeds because it tests local var 'rc'.
>>>
>>
>>
>> Good catch.
>>
>> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>>
>>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>>> ---
>>> .../interfaces/pthread_rwlock_unlock/4-2.c | 3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> index 3023886..4928f85 100644
>>> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>>> int main()
>>> {
>>> int cnt = 0;
>>> - int rc = 0;
>>>
>>> pthread_t un_thread;
>>>
>>> @@ -125,4 +124,4 @@ int main()
>>>
>>> printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>>> return PTS_PASS;
>>> -}
>>> \ No newline at end of file
>>> +}
>
> Will be committed soon (kind of interesting why -Wshadow didn't
> identify this issue...).
Yeah, odd, I didn't see warning by -Wshadow, either.
> -Garrett
>
------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and
improve service delivery. Take 5 minutes to use this Systems Optimization
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] Patches for POSIX test cases
2011-12-09 8:28 [LTP] Patches for POSIX test cases Kang Kai
2011-12-09 8:28 ` [LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first Kang Kai
2011-12-09 8:28 ` [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc' Kang Kai
@ 2011-12-09 8:52 ` Wanlong Gao
2011-12-09 9:19 ` Kang Kai
2011-12-13 5:52 ` Garrett Cooper
2011-12-09 13:04 ` Cyril Hrubis
3 siblings, 2 replies; 11+ messages in thread
From: Wanlong Gao @ 2011-12-09 8:52 UTC (permalink / raw)
To: Kang Kai; +Cc: ltp-list
On 12/09/2011 04:28 PM, Kang Kai wrote:
> Hi All,
>
> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
>
> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.
It seems there isn't a irc. You can just send email to list.
>
> Thanks and Regards,
> Kai
>
>
>
>
> ------------------------------------------------------------------------------
> Cloud Services Checklist: Pricing and Packaging Optimization
> This white paper is intended to serve as a reference, checklist and point of
> discussion for anyone considering optimizing the pricing and packaging model
> of a cloud services business. Read Now!
> http://www.accelacomm.com/jaw/sfnl/114/51491232/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] Patches for POSIX test cases
2011-12-09 8:52 ` [LTP] Patches for POSIX test cases Wanlong Gao
@ 2011-12-09 9:19 ` Kang Kai
2011-12-13 5:52 ` Garrett Cooper
1 sibling, 0 replies; 11+ messages in thread
From: Kang Kai @ 2011-12-09 9:19 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On 2011年12月09日 16:52, Wanlong Gao wrote:
> On 12/09/2011 04:28 PM, Kang Kai wrote:
>
>> Hi All,
>>
>> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
>>
>> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.
>
> It seems there isn't a irc. You can just send email to list.
OK, thanks.
>
>> Thanks and Regards,
>> Kai
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Cloud Services Checklist: Pricing and Packaging Optimization
>> This white paper is intended to serve as a reference, checklist and point of
>> discussion for anyone considering optimizing the pricing and packaging model
>> of a cloud services business. Read Now!
>> http://www.accelacomm.com/jaw/sfnl/114/51491232/
>> _______________________________________________
>> Ltp-list mailing list
>> Ltp-list@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ltp-list
>>
>
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] Patches for POSIX test cases
2011-12-09 8:52 ` [LTP] Patches for POSIX test cases Wanlong Gao
2011-12-09 9:19 ` Kang Kai
@ 2011-12-13 5:52 ` Garrett Cooper
1 sibling, 0 replies; 11+ messages in thread
From: Garrett Cooper @ 2011-12-13 5:52 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On Fri, Dec 9, 2011 at 12:52 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
> On 12/09/2011 04:28 PM, Kang Kai wrote:
>
>> Hi All,
>>
>> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
>>
>> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.
>
>
> It seems there isn't a irc. You can just send email to list.
There was an IRC chan for LTP, but I don't know how much/often people
stick around there. Subrata was there for a while along with Mike F.
and your's truly. I don't hang around IRC all that much -- esp. not
EFNET.
-Garrett
------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and
improve service delivery. Take 5 minutes to use this Systems Optimization
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] Patches for POSIX test cases
2011-12-09 8:28 [LTP] Patches for POSIX test cases Kang Kai
` (2 preceding siblings ...)
2011-12-09 8:52 ` [LTP] Patches for POSIX test cases Wanlong Gao
@ 2011-12-09 13:04 ` Cyril Hrubis
3 siblings, 0 replies; 11+ messages in thread
From: Cyril Hrubis @ 2011-12-09 13:04 UTC (permalink / raw)
To: Kang Kai; +Cc: ltp-list
Hi!
> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
>
> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.
There is an LTP channel on freenode (And I'm usually there under nick
metan at least during my working hours).
And just now I've been overhelmed by other tasks, so stay tuned I'll
look at the patches soon enough.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread