[LTP] Patches for POSIX test cases

[LTP] Patches for POSIX test cases

[Kang Kai]

Hi All,

These two patches are for POSIX test suite, and could anyone give some comments? Thanks.

And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.

Thanks and Regards,
Kai




------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first

[Kang Kai]

Test case failed for linux in some platform. Make parent thread
sleep for a while to make sure that signal handlers are installed
before send signal USR1 and USR2.

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 .../interfaces/pthread_mutex_lock/3-1.c            |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
index 771851d..a648c96 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
@@ -307,6 +307,8 @@ int main (int argc, char * argv[])
 	if ((ret = pthread_create(&th_work, NULL, threaded, NULL)))
 	{ UNRESOLVED(ret, "Worker thread creation failed"); }
 
+	sleep(1);
+
 	arg1.thr = &th_work;
 	arg2.thr = &th_work;
 	arg1.sig = SIGUSR1;
@@ -359,4 +361,4 @@ int main (int argc, char * argv[])
 	#endif
 	#endif
 	PASSED;
-}
\ No newline at end of file
+}
-- 
1.7.5.4


------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

[Kang Kai]

Local var 'rc' in function main hides the global one. In child thread
it sets global var 'rc' with funtion return value. But in function main,
test var 'rc' always succeeds because it tests local var 'rc'.

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 .../interfaces/pthread_rwlock_unlock/4-2.c         |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
index 3023886..4928f85 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
@@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
 int main()
 {
 	int cnt = 0;
-	int rc = 0;
 
 	pthread_t un_thread;
 
@@ -125,4 +124,4 @@ int main()
 
 	printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
 	return PTS_PASS;
-}
\ No newline at end of file
+}
-- 
1.7.5.4


------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Patches for POSIX test cases

[Wanlong Gao]

On 12/09/2011 04:28 PM, Kang Kai wrote:

> Hi All,
> 
> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
> 
> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.


It seems there isn't a irc. You can just send email to list.

> 
> Thanks and Regards,
> Kai
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Cloud Services Checklist: Pricing and Packaging Optimization
> This white paper is intended to serve as a reference, checklist and point of 
> discussion for anyone considering optimizing the pricing and packaging model 
> of a cloud services business. Read Now!
> http://www.accelacomm.com/jaw/sfnl/114/51491232/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 



------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

[Wanlong Gao]

On 12/09/2011 04:28 PM, Kang Kai wrote:

> Local var 'rc' in function main hides the global one. In child thread
> it sets global var 'rc' with funtion return value. But in function main,
> test var 'rc' always succeeds because it tests local var 'rc'.
> 


Good catch.

Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>  .../interfaces/pthread_rwlock_unlock/4-2.c         |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> index 3023886..4928f85 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>  int main()
>  {
>  	int cnt = 0;
> -	int rc = 0;
>  
>  	pthread_t un_thread;
>  
> @@ -125,4 +124,4 @@ int main()
>  
>  	printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>  	return PTS_PASS;
> -}
> \ No newline at end of file
> +}



------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Patches for POSIX test cases

[Kang Kai]

On 2011年12月09日 16:52, Wanlong Gao wrote:
> On 12/09/2011 04:28 PM, Kang Kai wrote:
>
>> Hi All,
>>
>> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
>>
>> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.
>
> It seems there isn't a irc. You can just send email to list.

OK, thanks.

>
>> Thanks and Regards,
>> Kai
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Cloud Services Checklist: Pricing and Packaging Optimization
>> This white paper is intended to serve as a reference, checklist and point of
>> discussion for anyone considering optimizing the pricing and packaging model
>> of a cloud services business. Read Now!
>> http://www.accelacomm.com/jaw/sfnl/114/51491232/
>> _______________________________________________
>> Ltp-list mailing list
>> Ltp-list@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ltp-list
>>
>


------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Patches for POSIX test cases

[Cyril Hrubis]

Hi!
> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
> 
> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.

There is an LTP channel on freenode (And I'm usually there under nick
metan at least during my working hours).

And just now I've been overhelmed by other tasks, so stay tuned I'll
look at the patches soon enough.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Patches for POSIX test cases

[Garrett Cooper]

On Fri, Dec 9, 2011 at 12:52 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
> On 12/09/2011 04:28 PM, Kang Kai wrote:
>
>> Hi All,
>>
>> These two patches are for POSIX test suite, and could anyone give some comments? Thanks.
>>
>> And is there a irc channel for ltp/posix, I need some help about POSIX test on linux.
>
>
> It seems there isn't a irc. You can just send email to list.

There was an IRC chan for LTP, but I don't know how much/often people
stick around there. Subrata was there for a while along with Mike F.
and your's truly.  I don't hang around IRC all that much -- esp. not
EFNET.
-Garrett

------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

[Garrett Cooper]

On Fri, Dec 9, 2011 at 1:18 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
> On 12/09/2011 04:28 PM, Kang Kai wrote:
>
>> Local var 'rc' in function main hides the global one. In child thread
>> it sets global var 'rc' with funtion return value. But in function main,
>> test var 'rc' always succeeds because it tests local var 'rc'.
>>
>
>
> Good catch.
>
> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>> ---
>>  .../interfaces/pthread_rwlock_unlock/4-2.c         |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>> index 3023886..4928f85 100644
>> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>>  int main()
>>  {
>>       int cnt = 0;
>> -     int rc = 0;
>>
>>       pthread_t un_thread;
>>
>> @@ -125,4 +124,4 @@ int main()
>>
>>       printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>>       return PTS_PASS;
>> -}
>> \ No newline at end of file
>> +}

Will be committed soon (kind of interesting why -Wshadow didn't
identify this issue...).
-Garrett

------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/2] pthread_mutex_lock/3-1: make sure install signal hanldler first

[Garrett Cooper]

On Fri, Dec 9, 2011 at 12:28 AM, Kang Kai <kai.kang@windriver.com> wrote:
> Test case failed for linux in some platform. Make parent thread
> sleep for a while to make sure that signal handlers are installed
> before send signal USR1 and USR2.
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>  .../interfaces/pthread_mutex_lock/3-1.c            |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
> index 771851d..a648c96 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/3-1.c
> @@ -307,6 +307,8 @@ int main (int argc, char * argv[])
>        if ((ret = pthread_create(&th_work, NULL, threaded, NULL)))
>        { UNRESOLVED(ret, "Worker thread creation failed"); }
>
> +       sleep(1);
> +
>        arg1.thr = &th_work;
>        arg2.thr = &th_work;
>        arg1.sig = SIGUSR1;
> @@ -359,4 +361,4 @@ int main (int argc, char * argv[])
>        #endif
>        #endif
>        PASSED;
> -}
> \ No newline at end of file
> +}
> --
> 1.7.5.4

It's better than status quo, but it's still kind of race prone (highly
unlikely, but you never know). It seems like a pthread_mutex would
make more sense in this case.
Thanks,
-Garrett

------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

[Wanlong Gao]

On 12/13/2011 01:56 PM, Garrett Cooper wrote:

> On Fri, Dec 9, 2011 at 1:18 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>> On 12/09/2011 04:28 PM, Kang Kai wrote:
>>
>>> Local var 'rc' in function main hides the global one. In child thread
>>> it sets global var 'rc' with funtion return value. But in function main,
>>> test var 'rc' always succeeds because it tests local var 'rc'.
>>>
>>
>>
>> Good catch.
>>
>> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>>
>>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>>> ---
>>>  .../interfaces/pthread_rwlock_unlock/4-2.c         |    3 +--
>>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> index 3023886..4928f85 100644
>>> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>>>  int main()
>>>  {
>>>       int cnt = 0;
>>> -     int rc = 0;
>>>
>>>       pthread_t un_thread;
>>>
>>> @@ -125,4 +124,4 @@ int main()
>>>
>>>       printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>>>       return PTS_PASS;
>>> -}
>>> \ No newline at end of file
>>> +}
> 
> Will be committed soon (kind of interesting why -Wshadow didn't
> identify this issue...).


Yeah, odd, I didn't see warning by -Wshadow, either.

> -Garrett
> 



------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] Patches for posix test cases

[Kang Kai]

Hi all,

The first two patches are resent because no reply for now.
The third patch is for timer_settime/5-3.c. In this case the timer always expires before the caller enters sleep.
So it sleeps too long time to be reported hang. Decrease the sleep value to fix it.

Regards,
Kai


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list