Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 12/13/2011 01:56 PM, Garrett Cooper wrote:

> On Fri, Dec 9, 2011 at 1:18 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>> On 12/09/2011 04:28 PM, Kang Kai wrote:
>>
>>> Local var 'rc' in function main hides the global one. In child thread
>>> it sets global var 'rc' with funtion return value. But in function main,
>>> test var 'rc' always succeeds because it tests local var 'rc'.
>>>
>>
>>
>> Good catch.
>>
>> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>>
>>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>>> ---
>>>  .../interfaces/pthread_rwlock_unlock/4-2.c         |    3 +--
>>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> index 3023886..4928f85 100644
>>> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_unlock/4-2.c
>>> @@ -54,7 +54,6 @@ static void* fn_unlk(void *arg)
>>>  int main()
>>>  {
>>>       int cnt = 0;
>>> -     int rc = 0;
>>>
>>>       pthread_t un_thread;
>>>
>>> @@ -125,4 +124,4 @@ int main()
>>>
>>>       printf("Test PASSED: Note*: Returned 0 instead of EPERM, but standard specified _may_ fail.\n");
>>>       return PTS_PASS;
>>> -}
>>> \ No newline at end of file
>>> +}
> 
> Will be committed soon (kind of interesting why -Wshadow didn't
> identify this issue...).


Yeah, odd, I didn't see warning by -Wshadow, either.

> -Garrett
> 



------------------------------------------------------------------------------
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list