From: Caspar Zhang <caspar@casparzhang.com>
To: Eryu Guan <eguan@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function
Date: Wed, 28 Dec 2011 11:21:37 +0800 [thread overview]
Message-ID: <4EFA8B41.1040802@casparzhang.com> (raw)
In-Reply-To: <1324872283-6292-1-git-send-email-eguan@redhat.com>
On 12/26/2011 12:04 PM, Eryu Guan wrote:
> + tname = tc[i].fname;
> + tkey = tc[i].key;
> + tvalue = tc[i].value;
> + tsize = tc[i].size;
> + tflags = tc[i].flags;
> + texp_err = tc[i].exp_err;
> +
> + TEST(setxattr(tname, tkey, tvalue, tsize, tflags));
I wonder whether it's necessary. all of the variables be used once only.
Others looks good for me.
Caspar
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-12-28 3:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 4:04 [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function Eryu Guan
2011-12-26 4:04 ` [LTP] [PATCH 2/2 V2] syscalls/getxattr01: new testcase to test getxattr(2) " Eryu Guan
2011-12-28 3:21 ` Caspar Zhang [this message]
2011-12-29 19:41 ` [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFA8B41.1040802@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=eguan@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox