* [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function
@ 2011-12-26 4:04 Eryu Guan
2011-12-26 4:04 ` [LTP] [PATCH 2/2 V2] syscalls/getxattr01: new testcase to test getxattr(2) " Eryu Guan
2011-12-28 3:21 ` [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) " Caspar Zhang
0 siblings, 2 replies; 4+ messages in thread
From: Eryu Guan @ 2011-12-26 4:04 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
Basic tests for setxattr(2) and make sure setxattr(2) handles error
conditions correctly.
There are 7 test cases:
1. Any other flags being set except XATTR_CREATE and XATTR_REPLACE,
setxattr(2) should return -1 and set errno to EINVAL
2. With XATTR_REPLACE flag set but the attribute does not exist,
setxattr(2) should return -1 and set errno to ENOATTR
3. Create new attr with name length greater than XATTR_NAME_MAX(255)
setxattr(2) should return -1 and set errno to ERANGE
4. Create new attr whose value length is greater than XATTR_SIZE_MAX(65536)
setxattr(2) should return -1 and set errno to E2BIG
5. Create new attr whose value length is zero,
setxattr(2) should succeed
6. Replace the attr value without XATTR_REPLACE flag being set,
setxattr(2) should return -1 and set errno to EEXIST
7. Replace attr value with XATTR_REPLACE flag being set,
setxattr(2) should succeed
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
V2:
1. Statically initialize test case array
2. Use TTERRNO with TPASS and TFAIL to print TEST_ERRNO message
runtest/syscalls | 2 +
testcases/kernel/syscalls/setxattr/Makefile | 23 +++
testcases/kernel/syscalls/setxattr/setxattr01.c | 236 +++++++++++++++++++++++
3 files changed, 261 insertions(+), 0 deletions(-)
create mode 100644 testcases/kernel/syscalls/setxattr/Makefile
create mode 100644 testcases/kernel/syscalls/setxattr/setxattr01.c
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-syscalls-setxattr01-new-testcase-to-test-setxattr-2-.patch --]
[-- Type: text/x-patch; name="0001-syscalls-setxattr01-new-testcase-to-test-setxattr-2-.patch", Size: 8060 bytes --]
diff --git a/runtest/syscalls b/runtest/syscalls
index 3755789..3056659 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1018,6 +1018,8 @@ setuid03_16 setuid03_16
setuid04 setuid04
setuid04_16 setuid04_16
+setxattr01 setxattr01
+
shmat01 shmat01
shmat02 shmat02
shmat03 shmat03
diff --git a/testcases/kernel/syscalls/setxattr/Makefile b/testcases/kernel/syscalls/setxattr/Makefile
new file mode 100644
index 0000000..72544c1
--- /dev/null
+++ b/testcases/kernel/syscalls/setxattr/Makefile
@@ -0,0 +1,23 @@
+#
+# Copyright (c) Red Hat Inc., 2011
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
+# the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#
+
+top_srcdir ?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/syscalls/setxattr/setxattr01.c b/testcases/kernel/syscalls/setxattr/setxattr01.c
new file mode 100644
index 0000000..0da4ef9
--- /dev/null
+++ b/testcases/kernel/syscalls/setxattr/setxattr01.c
@@ -0,0 +1,236 @@
+/*
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of version 2 of the GNU General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ *
+ * Further, this software is distributed without any warranty that it
+ * is free of the rightful claim of any third person regarding
+ * infringement or the like. Any license provided herein, whether
+ * implied or otherwise, applies only to this software file. Patent
+ * licenses, if any, provided herein do not apply to combinations of
+ * this program with other software, or any other product whatsoever.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ * 02110-1301, USA.
+ */
+
+/*
+ * Basic tests for setxattr(2) and make sure setxattr(2) handles error
+ * conditions correctly.
+ *
+ * There are 7 test cases:
+ * 1. Any other flags being set except XATTR_CREATE and XATTR_REPLACE,
+ * setxattr(2) should return -1 and set errno to EINVAL
+ * 2. With XATTR_REPLACE flag set but the attribute does not exist,
+ * setxattr(2) should return -1 and set errno to ENOATTR
+ * 3. Create new attr with name length greater than XATTR_NAME_MAX(255)
+ * setxattr(2) should return -1 and set errno to ERANGE
+ * 4. Create new attr whose value length is greater than XATTR_SIZE_MAX(65536)
+ * setxattr(2) should return -1 and set errno to E2BIG
+ * 5. Create new attr whose value length is zero,
+ * setxattr(2) should succeed
+ * 6. Replace the attr value without XATTR_REPLACE flag being set,
+ * setxattr(2) should return -1 and set errno to EEXIST
+ * 7. Replace attr value with XATTR_REPLACE flag being set,
+ * setxattr(2) should succeed
+ */
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/wait.h>
+#include <attr/xattr.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <signal.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "test.h"
+#include "usctest.h"
+
+#define XATTR_NAME_MAX 255
+#define XATTR_NAME_LEN (XATTR_NAME_MAX + 2)
+#define XATTR_SIZE_MAX 65536
+#define XATTR_TEST_KEY "user.testkey"
+#define XATTR_TEST_VALUE "this is a test value"
+#define XATTR_TEST_VALUE_SIZE 20
+
+static void setup(void);
+static void cleanup(void);
+
+char *TCID = "setxattr01";
+char filename[BUFSIZ];
+char long_key[XATTR_NAME_LEN];
+char *long_value;
+
+struct test_case {
+ char *fname;
+ char *key;
+ char *value;
+ size_t size;
+ int flags;
+ int exp_err;
+};
+struct test_case tc[] = {
+ { /* case 00, invalid flags */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = XATTR_TEST_VALUE,
+ .size = XATTR_TEST_VALUE_SIZE,
+ .flags = ~0,
+ .exp_err = EINVAL,
+ },
+ { /* case 01, replace non-existing attribute */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = XATTR_TEST_VALUE,
+ .size = XATTR_TEST_VALUE_SIZE,
+ .flags = XATTR_REPLACE,
+ .exp_err = ENOATTR,
+ },
+ { /* case 02, long key name, key will be set in setup() */
+ .fname = filename,
+ .key = NULL,
+ .value = XATTR_TEST_VALUE,
+ .size = XATTR_TEST_VALUE_SIZE,
+ .flags = XATTR_CREATE,
+ .exp_err = ERANGE,
+ },
+ { /* case 03, long value, value will be set in setup() */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = NULL,
+ .size = XATTR_SIZE_MAX + 1,
+ .flags = XATTR_CREATE,
+ .exp_err = E2BIG,
+ },
+ { /* case 04, zero length value */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = XATTR_TEST_VALUE,
+ .size = 0,
+ .flags = XATTR_CREATE,
+ .exp_err = 0,
+ },
+ { /* case 05, create existing attribute */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = XATTR_TEST_VALUE,
+ .size = XATTR_TEST_VALUE_SIZE,
+ .flags = XATTR_CREATE,
+ .exp_err = EEXIST,
+ },
+ { /* case 06, replace existing attribute */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = XATTR_TEST_VALUE,
+ .size = XATTR_TEST_VALUE_SIZE,
+ .flags = XATTR_REPLACE,
+ .exp_err = 0,
+ },
+};
+
+int TST_TOTAL = sizeof(tc) / sizeof(tc[0]);
+
+int main(int argc, char *argv[])
+{
+ int lc;
+ int i;
+ char *msg;
+ char *tname;
+ char *tkey;
+ char *tvalue;
+ size_t tsize;
+ int tflags;
+ int texp_err;
+
+
+ msg = parse_opts(argc, argv, NULL, NULL);
+ if (msg != NULL)
+ tst_brkm(TBROK, tst_exit, "OPTION PARSING ERROR - %s", msg);
+
+ setup();
+
+ for (lc = 0; TEST_LOOPING(lc); lc++) {
+ Tst_count = 0;
+
+ for (i = 0; i < TST_TOTAL; i++) {
+ tname = tc[i].fname;
+ tkey = tc[i].key;
+ tvalue = tc[i].value;
+ tsize = tc[i].size;
+ tflags = tc[i].flags;
+ texp_err = tc[i].exp_err;
+
+ TEST(setxattr(tname, tkey, tvalue, tsize, tflags));
+
+ if (TEST_ERRNO == texp_err) {
+ tst_resm(TPASS | TTERRNO, "expected behavior");
+ } else {
+ tst_resm(TFAIL | TTERRNO, "unexpected behavior"
+ " - expected errno %d - Got", texp_err);
+ }
+ }
+ }
+
+ cleanup();
+ tst_exit();
+}
+
+static void setup(void)
+{
+ int fd;
+
+ tst_require_root(NULL);
+
+ tst_tmpdir();
+
+ /* Test for xattr support */
+ fd = creat("testfile", 0644);
+ if (fd == -1)
+ tst_brkm(TBROK | TERRNO, cleanup, "Create testfile failed");
+ close(fd);
+ if (setxattr("testfile", "user.test", "test", 4, XATTR_CREATE) == -1)
+ if (errno == ENOTSUP)
+ tst_brkm(TCONF, cleanup, "No xattr support in fs or "
+ "mount without user_xattr option");
+
+ /* Create test file */
+ snprintf(filename, BUFSIZ, "setxattr01testfile");
+ fd = creat(filename, 0644);
+ if (fd == -1)
+ tst_brkm(TBROK | TERRNO, cleanup, "Create test file(%s) failed",
+ filename);
+ close(fd);
+
+ /* Prepare test cases */
+ snprintf(long_key, 6, "%s", "user.");
+ memset(long_key + 5, 'k', XATTR_NAME_LEN - 5);
+ long_key[XATTR_NAME_LEN - 1] = '\0';
+ tc[2].key = long_key;
+
+ long_value = malloc(XATTR_SIZE_MAX + 2);
+ if (!long_value)
+ tst_brkm(TBROK | TERRNO, cleanup, "malloc failed");
+ memset(long_value, 'v', XATTR_SIZE_MAX + 2);
+ long_value[XATTR_SIZE_MAX + 1] = '\0';
+ tc[3].value = long_value;
+
+ TEST_PAUSE;
+}
+
+static void cleanup(void)
+{
+ TEST_CLEANUP;
+ tst_rmdir();
+}
[-- Attachment #3: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 4+ messages in thread* [LTP] [PATCH 2/2 V2] syscalls/getxattr01: new testcase to test getxattr(2) basic function
2011-12-26 4:04 [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function Eryu Guan
@ 2011-12-26 4:04 ` Eryu Guan
2011-12-28 3:21 ` [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) " Caspar Zhang
1 sibling, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2011-12-26 4:04 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
Basic tests for getxattr(2) and make sure getxattr(2) handles error
conditions correctly.
There are 4 test cases:
1. Get an non-existing attribute,
getxattr(2) should return -1 and set errno to ENOATTR
2. Buffer size is smaller than attribute value size,
getxattr(2) should return -1 and set errno to ERANGE
3. Get attribute, getxattr(2) should succeed
4. Verify the attribute got by getxattr(2) is same as the value we set
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
V2:
1. Statically initialize test case array
2. Use TTERRNO with TPASS and TFAIL to print TEST_ERRNO message
runtest/syscalls | 2 +
testcases/kernel/syscalls/getxattr/Makefile | 23 +++
testcases/kernel/syscalls/getxattr/getxattr01.c | 184 +++++++++++++++++++++++
3 files changed, 209 insertions(+), 0 deletions(-)
create mode 100644 testcases/kernel/syscalls/getxattr/Makefile
create mode 100644 testcases/kernel/syscalls/getxattr/getxattr01.c
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-syscalls-getxattr01-new-testcase-to-test-getxattr-2-.patch --]
[-- Type: text/x-patch; name="0002-syscalls-getxattr01-new-testcase-to-test-getxattr-2-.patch", Size: 6349 bytes --]
diff --git a/runtest/syscalls b/runtest/syscalls
index 3056659..48caaae 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -420,6 +420,8 @@ getuid02_16 getuid02_16
getuid03 getuid03
getuid03_16 getuid03_16
+getxattr01 getxattr01
+
#Needs tty device.
#ioctl01 ioctl01 -D /dev/tty0
#ioctl02 ioctl02 -D /dev/tty0
diff --git a/testcases/kernel/syscalls/getxattr/Makefile b/testcases/kernel/syscalls/getxattr/Makefile
new file mode 100644
index 0000000..72544c1
--- /dev/null
+++ b/testcases/kernel/syscalls/getxattr/Makefile
@@ -0,0 +1,23 @@
+#
+# Copyright (c) Red Hat Inc., 2011
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
+# the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#
+
+top_srcdir ?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/syscalls/getxattr/getxattr01.c b/testcases/kernel/syscalls/getxattr/getxattr01.c
new file mode 100644
index 0000000..5e6209e
--- /dev/null
+++ b/testcases/kernel/syscalls/getxattr/getxattr01.c
@@ -0,0 +1,184 @@
+/*
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of version 2 of the GNU General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ *
+ * Further, this software is distributed without any warranty that it
+ * is free of the rightful claim of any third person regarding
+ * infringement or the like. Any license provided herein, whether
+ * implied or otherwise, applies only to this software file. Patent
+ * licenses, if any, provided herein do not apply to combinations of
+ * this program with other software, or any other product whatsoever.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ * 02110-1301, USA.
+ */
+
+/*
+ * Basic tests for getxattr(2) and make sure getxattr(2) handles error
+ * conditions correctly.
+ *
+ * There are 4 test cases:
+ * 1. Get an non-existing attribute,
+ * getxattr(2) should return -1 and set errno to ENOATTR
+ * 2. Buffer size is smaller than attribute value size,
+ * getxattr(2) should return -1 and set errno to ERANGE
+ * 3. Get attribute, getxattr(2) should succeed
+ * 4. Verify the attribute got by getxattr(2) is same as the value we set
+ */
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <attr/xattr.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "test.h"
+#include "usctest.h"
+
+#define XATTR_TEST_KEY "user.testkey"
+#define XATTR_TEST_VALUE "this is a test value"
+#define XATTR_TEST_VALUE_SIZE 20
+#define BUFFSIZE 64
+
+static void setup(void);
+static void cleanup(void);
+
+char *TCID = "getxattr01";
+char filename[BUFSIZ];
+
+struct test_case {
+ char *fname;
+ char *key;
+ char *value;
+ size_t size;
+ int exp_err;
+};
+struct test_case tc[] = {
+ { /* case 00, get non-existing attribute */
+ .fname = filename,
+ .key = "user.nosuchkey",
+ .value = NULL,
+ .size = BUFFSIZE - 1,
+ .exp_err = ENOATTR,
+ },
+ { /* case 01, small value buffer */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = NULL,
+ .size = 1,
+ .exp_err = ERANGE,
+ },
+ { /* case 02, get existing attribute */
+ .fname = filename,
+ .key = XATTR_TEST_KEY,
+ .value = NULL,
+ .size = BUFFSIZE - 1,
+ .exp_err = 0,
+ },
+};
+
+int TST_TOTAL = sizeof(tc) / sizeof(tc[0]) + 1;
+
+int main(int argc, char *argv[])
+{
+ int lc;
+ int i;
+ char *msg;
+ char *tname;
+ char *tkey;
+ char *tvalue;
+ size_t tsize;
+ int texp_err;
+
+
+ msg = parse_opts(argc, argv, NULL, NULL);
+ if (msg != NULL)
+ tst_brkm(TBROK, tst_exit, "OPTION PARSING ERROR - %s", msg);
+
+ setup();
+
+ for (lc = 0; TEST_LOOPING(lc); lc++) {
+ Tst_count = 0;
+
+ for (i = 0; i < (sizeof(tc) / sizeof(tc[0])); i++) {
+ tname = tc[i].fname;
+ tkey = tc[i].key;
+ tvalue = tc[i].value;
+ tsize = tc[i].size;
+ texp_err = tc[i].exp_err;
+
+ TEST(getxattr(tname, tkey, tvalue, tsize));
+
+ if (TEST_ERRNO == texp_err) {
+ tst_resm(TPASS | TTERRNO, "expected behavior");
+ } else {
+ tst_resm(TFAIL | TTERRNO, "unexpected behavior"
+ "- expected errno %d - Got", texp_err);
+ }
+ }
+
+ if (strcmp(tvalue, XATTR_TEST_VALUE))
+ tst_resm(TFAIL, "Wrong value, expect \"%s\" got \"%s\"",
+ XATTR_TEST_VALUE, tvalue);
+ else
+ tst_resm(TPASS, "Got the right value");
+ }
+
+ cleanup();
+ tst_exit();
+}
+
+static void setup(void)
+{
+ int fd;
+ int i;
+
+ tst_require_root(NULL);
+
+ tst_tmpdir();
+
+ /* Create test file and setup initial xattr */
+ snprintf(filename, BUFSIZ, "getxattr01testfile");
+ fd = creat(filename, 0644);
+ if (fd == -1)
+ tst_brkm(TBROK | TERRNO, cleanup, "Create test file(%s) failed",
+ filename);
+ close(fd);
+ if (setxattr(filename, XATTR_TEST_KEY, XATTR_TEST_VALUE,
+ strlen(XATTR_TEST_VALUE), XATTR_CREATE) == -1) {
+ if (errno == ENOTSUP) {
+ tst_brkm(TCONF, cleanup, "No xattr support in fs or "
+ "mount without user_xattr option");
+ }
+ }
+
+ /* Prepare test cases */
+ for (i = 0; i < (sizeof(tc) / sizeof(tc[0])); i++) {
+ tc[i].value = malloc(BUFFSIZE);
+ if (tc[i].value == NULL) {
+ tst_brkm(TBROK | TERRNO, cleanup,
+ "Cannot allocate memory");
+ }
+ }
+
+ TEST_PAUSE;
+}
+
+static void cleanup(void)
+{
+ TEST_CLEANUP;
+ tst_rmdir();
+}
[-- Attachment #3: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function
2011-12-26 4:04 [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function Eryu Guan
2011-12-26 4:04 ` [LTP] [PATCH 2/2 V2] syscalls/getxattr01: new testcase to test getxattr(2) " Eryu Guan
@ 2011-12-28 3:21 ` Caspar Zhang
2011-12-29 19:41 ` Cyril Hrubis
1 sibling, 1 reply; 4+ messages in thread
From: Caspar Zhang @ 2011-12-28 3:21 UTC (permalink / raw)
To: Eryu Guan; +Cc: ltp-list
On 12/26/2011 12:04 PM, Eryu Guan wrote:
> + tname = tc[i].fname;
> + tkey = tc[i].key;
> + tvalue = tc[i].value;
> + tsize = tc[i].size;
> + tflags = tc[i].flags;
> + texp_err = tc[i].exp_err;
> +
> + TEST(setxattr(tname, tkey, tvalue, tsize, tflags));
I wonder whether it's necessary. all of the variables be used once only.
Others looks good for me.
Caspar
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function
2011-12-28 3:21 ` [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) " Caspar Zhang
@ 2011-12-29 19:41 ` Cyril Hrubis
0 siblings, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2011-12-29 19:41 UTC (permalink / raw)
To: Caspar Zhang; +Cc: ltp-list
Hi!
> > + tname = tc[i].fname;
> > + tkey = tc[i].key;
> > + tvalue = tc[i].value;
> > + tsize = tc[i].size;
> > + tflags = tc[i].flags;
> > + texp_err = tc[i].exp_err;
> > +
> > + TEST(setxattr(tname, tkey, tvalue, tsize, tflags));
>
> I wonder whether it's necessary. all of the variables be used once only.
I slightly for removing that too.
So if you wan't to change that, resend new patch, otherwise let me know,
I'll commit this as it is.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-29 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-26 4:04 [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function Eryu Guan
2011-12-26 4:04 ` [LTP] [PATCH 2/2 V2] syscalls/getxattr01: new testcase to test getxattr(2) " Eryu Guan
2011-12-28 3:21 ` [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) " Caspar Zhang
2011-12-29 19:41 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox