Re: [LTP] [PATCH 2/5] hugemmap01.c : automatically mount hugetlbfs.

[Caspar Zhang <caspar@casparzhang.com>]

On 12/28/2011 02:23 PM, Wanlong Gao wrote:
>>> >> +	tst_tmpdir();
>>> >> +	mount_point = get_tst_tmpdir();
>>> >> +	mount_hugetlbfs(mount_point);
>>> >> +	hugepage_alloc(1024);
> 
> sure, will change to a macro.

I don't think a macro can improve much. You patch reduces the testcase
scalability. A better way is passing hugepage size you want to set via
option:

./hugemmap01 -s 1024

The default value 1024 is not good enough, for x86 systems, it will
require at least 2GB free memory, for other systems, like powerpc, it
will require 16GB free memory. It would be better if you calculate how
much memory the system can be used for hugepages.

One more thing (on libmnt.c side), is there any action if hugepage_alloc
set 0, and is there any action if you want to set 1024 hpages, but only
allocated less amount than that?

Thanks,
Caspar

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list