[LTP] [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

[LTP] [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

[Markos Chandras]

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Hi, please review the attached patch

-- 
markos

[-- Attachment #2: 0006-syscalls-unshare02-Replace-int-NULL-with-0.patch --]
[-- Type: text/plain, Size: 1179 bytes --]

From 269402e0cf64392442196ecf6c79d35d9e93c1af Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 22 Dec 2011 11:57:17 +0000
Subject: [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

On non-32bit arches, casting a pointer to integer throws a compiler warning
because integers and pointers have different sizes in these arches. Therefore,
we replace the (int)NULL cast with 0 which has the same effect.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 testcases/kernel/syscalls/unshare/unshare02.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/unshare/unshare02.c b/testcases/kernel/syscalls/unshare/unshare02.c
index 9f7b436..1a93932 100644
--- a/testcases/kernel/syscalls/unshare/unshare02.c
+++ b/testcases/kernel/syscalls/unshare/unshare02.c
@@ -181,7 +181,7 @@ int main(int ac, char **av) {
 				tst_brkm(TFAIL|TTERRNO, cleanup,
 					"fork() failed.");
 			} else if (TEST_RETURN == 0) {
-				TEST_RETURN = unshare((int)NULL);
+				TEST_RETURN = unshare(0);
 				if (TEST_RETURN == 0) {
 					tst_resm(TPASS, "Call succeeded");
 					rval = 0;
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

[Garrett Cooper]

On Tue, Jan 3, 2012 at 2:44 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> Hi, please review the attached patch

Reviewed-by: Garrett Cooper <yanegomi@gmail.com>

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 116 bytes --]

On Tuesday 03 January 2012 05:44:01 Markos Chandras wrote:
> Hi, please review the attached patch

looks good
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list