* [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes
@ 2012-01-03 11:10 Markos Chandras
2012-01-03 19:40 ` Garrett Cooper
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Markos Chandras @ 2012-01-03 11:10 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 49 bytes --]
Hi, please review the attached patch
--
markos
[-- Attachment #2: 0010-lib-parse_opts-Multiple-fixes.patch --]
[-- Type: text/plain, Size: 1348 bytes --]
From a1e992a25a19b7465c7a16dc317e10a104495b41 Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Mon, 21 Nov 2011 16:24:00 +0000
Subject: [PATCH 10/21] lib/parse_opts: Multiple fixes
- Fix TEST_RETURN definition
- drop undefined TIMING option
- Add missing argument for parse_opts when UNIT_TEST marco is used
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
lib/parse_opts.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/parse_opts.c b/lib/parse_opts.c
index 8a235b1..aa2433f 100644
--- a/lib/parse_opts.c
+++ b/lib/parse_opts.c
@@ -834,14 +834,13 @@ char *ptr;
struct usc_errno_t TEST_VALID_ENO[USC_MAX_ERRNO];
-int TEST_RETURN;
+long TEST_RETURN;
int TEST_ERRNO;
/* for test specific parse_opts options */
option_t Options[] = {
{ "help", &Help2, NULL }, /* -help option */
{ "h", &Help, NULL }, /* -h option */
- { TIMING, NULL, NULL}, /* disable -timing option */
#if INVALID_TEST_CASES
{ "missingflag", NULL, &ptr }, /* error */
@@ -858,7 +857,7 @@ int main(int argc, char **argv)
struct timeval t;
int cnt;
- if ((msg = parse_opts(argc, argv, Options)) != NULL) {
+ if ((msg = parse_opts(argc, argv, Options, NULL)) != NULL) {
printf("ERROR: %s\n", msg);
exit(1);
}
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes
2012-01-03 11:10 [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes Markos Chandras
@ 2012-01-03 19:40 ` Garrett Cooper
2012-01-03 20:40 ` Mike Frysinger
2012-01-04 14:49 ` Cyril Hrubis
2 siblings, 0 replies; 5+ messages in thread
From: Garrett Cooper @ 2012-01-03 19:40 UTC (permalink / raw)
To: Markos Chandras; +Cc: ltp-list
On Tue, Jan 3, 2012 at 3:10 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper <yanegomi@gmail.com>
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes
2012-01-03 11:10 [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes Markos Chandras
2012-01-03 19:40 ` Garrett Cooper
@ 2012-01-03 20:40 ` Mike Frysinger
2012-01-04 14:46 ` Cyril Hrubis
2012-01-04 14:49 ` Cyril Hrubis
2 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2012-01-03 20:40 UTC (permalink / raw)
To: ltp-list; +Cc: Markos Chandras
[-- Attachment #1.1: Type: Text/Plain, Size: 333 bytes --]
On Tuesday 03 January 2012 06:10:37 Markos Chandras wrote:
> Hi, please review the attached patch
looks good, but please write better changelogs
"- Fix TEST_RETURN definition" doesn't really tell much much. it should say
something like "Fix TEST_RETURN definition to match that of the exported API in
usctest.h".
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes
2012-01-03 20:40 ` Mike Frysinger
@ 2012-01-04 14:46 ` Cyril Hrubis
0 siblings, 0 replies; 5+ messages in thread
From: Cyril Hrubis @ 2012-01-04 14:46 UTC (permalink / raw)
To: Mike Frysinger; +Cc: ltp-list, Markos Chandras
Hi!
>
> "- Fix TEST_RETURN definition" doesn't really tell much much. it should say
> something like "Fix TEST_RETURN definition to match that of the exported API in
> usctest.h".
+1.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes
2012-01-03 11:10 [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes Markos Chandras
2012-01-03 19:40 ` Garrett Cooper
2012-01-03 20:40 ` Mike Frysinger
@ 2012-01-04 14:49 ` Cyril Hrubis
2 siblings, 0 replies; 5+ messages in thread
From: Cyril Hrubis @ 2012-01-04 14:49 UTC (permalink / raw)
To: Markos Chandras; +Cc: ltp-list
Hi!
> - Fix TEST_RETURN definition
> - drop undefined TIMING option
> - Add missing argument for parse_opts when UNIT_TEST marco is used
Commited, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-04 14:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-03 11:10 [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes Markos Chandras
2012-01-03 19:40 ` Garrett Cooper
2012-01-03 20:40 ` Mike Frysinger
2012-01-04 14:46 ` Cyril Hrubis
2012-01-04 14:49 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox