[LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

[LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

[Markos Chandras]

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Hi, please review the attached patch

-- 
markos

[-- Attachment #2: 0012-syscalls-getcontext-profil-Move-test.h-header-and-TC.patch --]
[-- Type: text/plain, Size: 2479 bytes --]

From 12fe59ab99a573210f38ca6c40b41aa68504ad37 Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Fri, 18 Nov 2011 16:08:21 +0000
Subject: [PATCH 12/21] syscalls/{getcontext,profil}: Move test.h header and TCID variable to the top

The tst_brkm() function is used independently of UCLIBC macro so
they need to be defined outside of #ifdef statement

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 .../kernel/syscalls/getcontext/getcontext01.c      |    8 +++++---
 testcases/kernel/syscalls/profil/profil01.c        |    8 +++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/testcases/kernel/syscalls/getcontext/getcontext01.c b/testcases/kernel/syscalls/getcontext/getcontext01.c
index 7cadc67..aea0b1d 100644
--- a/testcases/kernel/syscalls/getcontext/getcontext01.c
+++ b/testcases/kernel/syscalls/getcontext/getcontext01.c
@@ -34,6 +34,10 @@
  **********************************************************/
 
 #include <features.h>
+#include "test.h"
+
+char *TCID = "getcontext01";	/* Test program identifier.    */
+
 #if !defined(__UCLIBC__)
 
 #include <stdio.h>
@@ -41,13 +45,11 @@
 #include <errno.h>
 #include <ucontext.h>
 
-#include "test.h"
 #include "usctest.h"
 
 void setup();
 void cleanup();
 
-char *TCID = "getcontext01";	/* Test program identifier.    */
 int TST_TOTAL = 1;		/* Total number of test cases. */
 
 int exp_enos[] = { 0 };		/* must be a 0 terminated list */
@@ -102,4 +104,4 @@ int main()
 {
 	tst_brkm(TCONF, NULL, "system doesn't have getcontext support");
 }
-#endif
\ No newline at end of file
+#endif
diff --git a/testcases/kernel/syscalls/profil/profil01.c b/testcases/kernel/syscalls/profil/profil01.c
index 63bed83..1af7e5d 100644
--- a/testcases/kernel/syscalls/profil/profil01.c
+++ b/testcases/kernel/syscalls/profil/profil01.c
@@ -41,6 +41,10 @@
 #endif
 
 #include <features.h>
+#include "test.h"
+
+char *TCID = "profil01";
+
 #ifndef __UCLIBC__
 
 #ifdef __arm__
@@ -58,7 +62,6 @@
 #include <errno.h>
 #include <sys/types.h>
 #include <sys/wait.h>
-#include "test.h"
 #include "usctest.h"
 #define FAILED 0
 #define PASSED 1
@@ -73,7 +76,6 @@ volatile int t_flag;
 //char progname[]= "profil1()";
 
 /*****	LTP Port	*****/
-char *TCID = "profil01";
 int local_flag = PASSED;
 int block_number;
 FILE *temp;
@@ -310,4 +312,4 @@ int main(void)
 	/* uClibc does not have profiling support */
 	tst_exit();
 }
-#endif
\ No newline at end of file
+#endif
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

[Garrett Cooper]

On Tue, Jan 3, 2012 at 3:18 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> Hi, please review the attached patch

Reviewed-by: Garrett Cooper <yanegomi@gmail.com>

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 230 bytes --]

On Tuesday 03 January 2012 06:18:56 Markos Chandras wrote:
> Hi, please review the attached patch

the test.h header should be after all system includes.  moving it before them 
is not a good idea.  so NAK this patch.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

[Garrett Cooper]

On Tue, Jan 3, 2012 at 12:21 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tuesday 03 January 2012 06:18:56 Markos Chandras wrote:
>> Hi, please review the attached patch
>
> the test.h header should be after all system includes.  moving it before them
> is not a good idea.  so NAK this patch.

Good point. Rescinding my Reviewed-by...
Thanks,
-Garrett

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list