From: Markos Chandras <Markos.Chandras@imgtec.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH 16/21] kernel/vma: Add missing return statement for non-void functions
Date: Tue, 3 Jan 2012 13:21:48 +0000 [thread overview]
Message-ID: <4F0300EC.7040201@imgtec.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 49 bytes --]
Hi, please review the attached patch
--
markos
[-- Attachment #2: 0016-kernel-vma-Add-missing-return-statement-for-non-void.patch --]
[-- Type: text/plain, Size: 1442 bytes --]
From b5bec4470a937d9d63b05798d34c0c33c19348d4 Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 22 Dec 2011 15:04:50 +0000
Subject: [PATCH 16/21] kernel/vma: Add missing return statement for non-void functions
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
testcases/kernel/mem/vma/vma01.c | 2 ++
testcases/kernel/mem/vma/vma02.c | 5 +++++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/testcases/kernel/mem/vma/vma01.c b/testcases/kernel/mem/vma/vma01.c
index 398d7a1..14c0525 100644
--- a/testcases/kernel/mem/vma/vma01.c
+++ b/testcases/kernel/mem/vma/vma01.c
@@ -151,6 +151,8 @@ static void *get_end_addr(void *addr_s, char *mapfile)
}
fclose(fp);
tst_brkm(TBROK, cleanup, "no matched s = %p found.", addr_s);
+
+ return NULL;
}
static void check_status(int status)
diff --git a/testcases/kernel/mem/vma/vma02.c b/testcases/kernel/mem/vma/vma02.c
index a1c8f24..fe7cff6 100644
--- a/testcases/kernel/mem/vma/vma02.c
+++ b/testcases/kernel/mem/vma/vma02.c
@@ -152,6 +152,9 @@ int main(int argc, char** argv)
tst_brkm(TWARN|TERRNO, NULL, "munmap");
}
tst_exit();
+
+ /* We should never be here */
+ return 0;
}
void usage(void)
@@ -166,5 +169,7 @@ int main(void) {
#else /* no NUMA */
int main(void) {
tst_brkm(TCONF, NULL, "no NUMA development packages installed.");
+ /* We should never be here */
+ return 0;
}
#endif
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2012-01-03 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 13:21 Markos Chandras [this message]
2012-01-03 20:32 ` [LTP] [PATCH 16/21] kernel/vma: Add missing return statement for non-void functions Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0300EC.7040201@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox