Re: [LTP] [PATCH 16/21] kernel/vma: Add missing return statement for non-void functions

Mike Frysinger
2012-01-03T20:31:57Z

[-- Attachment #1.1: Type: Text/Plain, Size: 374 bytes --]

On Tuesday 03 January 2012 08:21:48 Markos Chandras wrote:
> Hi, please review the attached patch

two of these hunks are fallout of your tst_brkm() no attribute change. those
don't actually return, so there shouldn't be a need to add explicit returns.

the 3rd hunk (adding a return after tst_exit) is wrong -- that is marked
noreturn and isn't changing.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net